diff options
| author | Jacob Vosmaer <jacob@gitlab.com> | 2019-01-10 17:00:07 +0300 |
|---|---|---|
| committer | Jacob Vosmaer <jacob@gitlab.com> | 2019-01-10 17:00:07 +0300 |
| commit | 4a93fca6c3e172dc0b607402469cfc93cffa3021 (patch) | |
| tree | eea264b909a211a8215056a90c537b27b29d619e | |
| parent | ad82b8e701f84380282de2b1ee78e60ab41add37 (diff) | |
Add test for invalid argument
| -rw-r--r-- | internal/service/repository/raw_changes_test.go | 16 |
1 files changed, 13 insertions, 3 deletions
diff --git a/internal/service/repository/raw_changes_test.go b/internal/service/repository/raw_changes_test.go index a7bf87fba..a4a3ddec2 100644 --- a/internal/service/repository/raw_changes_test.go +++ b/internal/service/repository/raw_changes_test.go @@ -171,9 +171,10 @@ func TestGetRawChangesFailures(t *testing.T) { defer cleanupFn() testCases := []struct { - oldRev string - newRev string - code codes.Code + oldRev string + newRev string + code codes.Code + omitRepository bool }{ { oldRev: "", @@ -181,6 +182,12 @@ func TestGetRawChangesFailures(t *testing.T) { code: codes.InvalidArgument, }, { + oldRev: "cfe32cf61b73a0d5e9f13e774abde7ff789b1660", + newRev: "913c66a37b4a45b9769037c55c2d238bd0942d2e", + code: codes.InvalidArgument, + omitRepository: true, + }, + { // A Gitaly commit, unresolvable in gitlab-test oldRev: "32800ed8206c0087f65e90a1a396b76d3c33f648", newRev: "1a0b36b3cdad1d2ee32457c102a8c0b7056fa863", @@ -194,6 +201,9 @@ func TestGetRawChangesFailures(t *testing.T) { defer cancel() req := &gitalypb.GetRawChangesRequest{testRepo, tc.oldRev, tc.newRev} + if tc.omitRepository { + req.Repository = nil + } resp, err := client.GetRawChanges(ctx, req) require.NoError(t, err) |