diff options
| author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-01-12 17:17:35 +0300 |
|---|---|---|
| committer | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2021-01-12 17:28:25 +0300 |
| commit | a96949aef4bb5f7cb8bf10cca02c586ae0e7df4c (patch) | |
| tree | bd211d73c4a1dc93522a6fc21488382b165d5624 | |
| parent | 01ba5b2c1c0719d27aced511bd9497b56cd9384a (diff) | |
Enable feature flag go_user_delete_{branch,tag} by default
These flags have been on at 100% for almost a month now without any
reported issues. See
https://gitlab.com/gitlab-org/gitaly/-/issues/3371 and
https://gitlab.com/gitlab-org/gitaly/-/issues/3370 Let's turn them on
by default.
I was told in a chat with @zj-gitlab that he'd prefer the relevant
operation_service.rb code removed as well, but due to a race condition
on deployment we couldn't do this atomically, it had to be done as a
two-phase rollout.
I.e. as we deploy the Ruby code might be in the middle of
auto-restarting, so we could remove its code before the Go code has a
chance to update with its default, and would still want to call it. So
therefore you need to do any such removal in two gitlab.com release
cycles.
| -rw-r--r-- | changelogs/unreleased/avar-go-user-delete-branch-and-tag-by-default.yml | 5 | ||||
| -rw-r--r-- | internal/metadata/featureflag/feature_flags.go | 4 |
2 files changed, 7 insertions, 2 deletions
diff --git a/changelogs/unreleased/avar-go-user-delete-branch-and-tag-by-default.yml b/changelogs/unreleased/avar-go-user-delete-branch-and-tag-by-default.yml new file mode 100644 index 000000000..d35bdd84f --- /dev/null +++ b/changelogs/unreleased/avar-go-user-delete-branch-and-tag-by-default.yml @@ -0,0 +1,5 @@ +--- +title: Enable feature flag go_user_delete_{branch,tag} by default +merge_request: 2994 +author: +type: changed diff --git a/internal/metadata/featureflag/feature_flags.go b/internal/metadata/featureflag/feature_flags.go index 1221d0ea7..908b521b3 100644 --- a/internal/metadata/featureflag/feature_flags.go +++ b/internal/metadata/featureflag/feature_flags.go @@ -24,7 +24,7 @@ var ( // GoUserCreateBranch enables the Go implementation of UserCreateBranch GoUserCreateBranch = FeatureFlag{Name: "go_user_create_branch", OnByDefault: false} // GoUserDeleteBranch enables the Go implementation of UserDeleteBranch - GoUserDeleteBranch = FeatureFlag{Name: "go_user_delete_branch", OnByDefault: false} + GoUserDeleteBranch = FeatureFlag{Name: "go_user_delete_branch", OnByDefault: true} // GoUserSquash enables the Go implementation of UserSquash GoUserSquash = FeatureFlag{Name: "go_user_squash", OnByDefault: true} // GoUserCommitFiles enables the Go implementation of UserCommitFiles @@ -37,7 +37,7 @@ var ( // GoFetchRemote enables the Go implementation of FetchRemote GoFetchRemote = FeatureFlag{Name: "go_fetch_remote", OnByDefault: true} // GoUserDeleteTag enables the Go implementation of UserDeleteTag - GoUserDeleteTag = FeatureFlag{Name: "go_user_delete_tag", OnByDefault: false} + GoUserDeleteTag = FeatureFlag{Name: "go_user_delete_tag", OnByDefault: true} // GoUserCreateTag enables the Go implementation of UserCreateTag GoUserCreateTag = FeatureFlag{Name: "go_user_create_tag", OnByDefault: false} // GoUserRevert enables the Go implementation of UserRevert |