diff options
| author | Jacob Vosmaer <jacob@gitlab.com> | 2020-01-09 00:35:25 +0300 |
|---|---|---|
| committer | John Cai <jcai@gitlab.com> | 2020-01-09 00:35:25 +0300 |
| commit | fa6aa482e2aee9d0a9b8a0a31eb7bb2d6f970c3b (patch) | |
| tree | 5604005a960dc86b9a46a313f37431b9030b4e8b /CONTRIBUTING.md | |
| parent | 4fb323c51c38d1ef26a4e40bd49f3442794232c8 (diff) | |
Add review process tips
Diffstat (limited to 'CONTRIBUTING.md')
| -rw-r--r-- | CONTRIBUTING.md | 13 |
1 files changed, 1 insertions, 12 deletions
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 464f6e271..e3501a056 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -88,18 +88,7 @@ Merge requests need to **approval by at least two ### Review Process -The Gitaly team uses the following process: - -- When you merge request is ready for review, select two approvers from the Merge Request edit view. -- Assign the first reviewer -- When the first reviewer is done, they assign the second reviewer -- When the second reviewer is done - - If there are no discussions, they are free to merge - - Otherwise assign back to the author for next round of review. - -**Note**: the author-reviewer 1-reviewer 2-author cycle works best with small changes. -With larger changes feel free to use the traditional author-reviewer -1-author-reviewer 1-reviewer 2-author-reviewer 2-cycle. +See [REVIEWING.md](REVIEWING.md). ## Gitaly Developer Quick-start Guide |