diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-11-09 19:11:02 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-11-14 11:07:31 +0300 |
| commit | c2655af544aadbf8da425144239e494251e2aa55 (patch) | |
| tree | b850462f5d5956b257804a880a378e89b53eea79 /Makefile | |
| parent | a415ff702cfd0755db5d1a09c63c13ce13b54f58 (diff) | |
limithandler: Refactor tests to use `grpc_testing` gRPC service
The tests for our `limithandler` middleware use a custom gRPC service
definition to assert its behaviour. This is not necessary though as
`grpc-go` already provides a `grpc_testing` package that contains a gRPC
service that is designed for testing gRPC-specific behaviour.
Refactor the test to use this package and get rid of our own Protobuf
definitions.
Diffstat (limited to 'Makefile')
| -rw-r--r-- | Makefile | 3 |
1 files changed, 1 insertions, 2 deletions
@@ -487,8 +487,7 @@ proto: ${PROTOC} ${PROTOC_GEN_GO} ${PROTOC_GEN_GO_GRPC} ${PROTOC_GEN_GITALY_PROT ${PROTOC} ${SHARED_PROTOC_OPTS} -I ${SOURCE_DIR}/proto -I ${SOURCE_DIR}/internal -I ${PROTOC_INSTALL_DIR}/include --go_out=${SOURCE_DIR}/internal --go-grpc_out=${SOURCE_DIR}/internal \ ${SOURCE_DIR}/internal/praefect/mock/mock.proto \ ${SOURCE_DIR}/internal/middleware/cache/testdata/stream.proto \ - ${SOURCE_DIR}/internal/helper/chunk/testdata/test.proto \ - ${SOURCE_DIR}/internal/middleware/limithandler/testdata/test.proto + ${SOURCE_DIR}/internal/helper/chunk/testdata/test.proto ${PROTOC} ${SHARED_PROTOC_OPTS} -I ${SOURCE_DIR}/proto -I ${SOURCE_DIR}/tools -I ${PROTOC_INSTALL_DIR}/include --go_out=${SOURCE_DIR}/tools --go-grpc_out=${SOURCE_DIR}/tools ${SOURCE_DIR}/tools/protoc-gen-gitaly-lint/testdata/*.proto .PHONY: check-proto |