diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-12-01 12:31:52 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-12-01 14:55:28 +0300 |
| commit | 445d80ef0ea8aca7f5d5d0c283374ee3f02442ca (patch) | |
| tree | aa6bb165ec39e8121c121390d3b3bd2ab97e39ae /client | |
| parent | ef537ec502fe003fb9ae02ff24611b842fedb54f (diff) | |
testhelper: Improve creation of loggers
The testhelper has functions to create test loggers for us. These are
awkardly named though, and furthermore we have a global variable which
contains a reference to one of the functions which creates the logger
for us, which is bad design. Furthermore, this global variable isn't
modified by anything anymore, making it essentially the same as the
function it's aliasing.
Rename functions to match Go best practices and remove the global
variable.
Diffstat (limited to 'client')
| -rw-r--r-- | client/dial_test.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/client/dial_test.go b/client/dial_test.go index ca62bcfc2..d7231f4a0 100644 --- a/client/dial_test.go +++ b/client/dial_test.go @@ -640,4 +640,4 @@ func TestHealthCheckDialer(t *testing.T) { require.NoError(t, cc.Close()) } -func newLogger(t testing.TB) *logrus.Entry { return logrus.NewEntry(testhelper.NewTestLogger(t)) } +func newLogger(t testing.TB) *logrus.Entry { return logrus.NewEntry(testhelper.NewDiscardingLogger(t)) } |