diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2020-12-17 14:05:37 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2020-12-17 14:30:46 +0300 |
| commit | a8e04c61c8670fe3c16472c9550e4b03968a5114 (patch) | |
| tree | c635d26f66af8a2b23ea7beff783ee10e6d13000 /client | |
| parent | 6f95abefc38e6ed73977178cca104943ee7e44c6 (diff) | |
golangci: Do not use default excludes
The golangci-lint project has a set of default excludes for linters
which are applied by default. This means that we cannot choose ourselves
which linting messages we want to include, as some of them cannot be
controlled by us.
One noteworthy linting check which is excluded right now checks whether
comments for types and functions are prefixed with their respective
name. This is something which we try to enforce in Gitaly, too, but
naturally there's cases where it slips through review.
So let's disable the default excludes such that we can enable this
linting check. As it turns out, there's quite a lot of cases where we
failed to adhere to this style, which this commit also fixes. One thing
which we don't do though is to have per-package comments, so let's
actively ignore it for now.
Diffstat (limited to 'client')
| -rw-r--r-- | client/pool.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/client/pool.go b/client/pool.go index 84067f4ff..d7b2679cd 100644 --- a/client/pool.go +++ b/client/pool.go @@ -29,7 +29,7 @@ func NewPool(dialOptions ...grpc.DialOption) *Pool { return NewPoolWithOptions(WithDialOptions(dialOptions...)) } -// NewPool creates a new connection pool that's ready for use. +// NewPoolWithOptions creates a new connection pool that's ready for use. func NewPoolWithOptions(poolOptions ...PoolOption) *Pool { opts := applyPoolOptions(poolOptions) return &Pool{ |