diff options
| author | Sami Hiltunen <shiltunen@gitlab.com> | 2020-12-17 17:58:20 +0300 |
|---|---|---|
| committer | Sami Hiltunen <shiltunen@gitlab.com> | 2020-12-17 18:03:09 +0300 |
| commit | 11a3464a2cf8d9f54883afc0d06293e627da7da0 (patch) | |
| tree | a1d578ca7f58ead7bdde5e4d2bc9fe61b9aff10d /cmd | |
| parent | 7353b28c23855c5d639ae73ad4883a76116fc4d9 (diff) | |
return correct status codes from SetReplicationFactor
SetReplicationFactor currently returns always status `Unknown` on
errors. This commit returns `InvalidArgument` for errors caused
by invalid arguments and `Internal` for other errors.
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/praefect/subcmd_set_replication_factor_test.go | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/cmd/praefect/subcmd_set_replication_factor_test.go b/cmd/praefect/subcmd_set_replication_factor_test.go index 9808dbccb..632ba0636 100644 --- a/cmd/praefect/subcmd_set_replication_factor_test.go +++ b/cmd/praefect/subcmd_set_replication_factor_test.go @@ -45,22 +45,22 @@ func TestSetReplicationFactorSubcommand(t *testing.T) { { desc: "replication factor too small", args: []string{"-virtual-storage=virtual-storage", "-repository=relative-path", "-replication-factor=0"}, - error: status.Error(codes.Unknown, "set replication factor: attempted to set replication factor 0 but minimum is 1"), + error: status.Error(codes.InvalidArgument, "set replication factor: attempted to set replication factor 0 but minimum is 1"), }, { desc: "replication factor too big", args: []string{"-virtual-storage=virtual-storage", "-repository=relative-path", "-replication-factor=3"}, - error: status.Error(codes.Unknown, "set replication factor: attempted to set replication factor 3 but virtual storage only contains 2 storages"), + error: status.Error(codes.InvalidArgument, "set replication factor: attempted to set replication factor 3 but virtual storage only contains 2 storages"), }, { desc: "virtual storage not found", args: []string{"-virtual-storage=non-existent", "-repository=relative-path", "-replication-factor=2"}, - error: status.Error(codes.Unknown, `set replication factor: unknown virtual storage: "non-existent"`), + error: status.Error(codes.InvalidArgument, `set replication factor: virtual storage "non-existent" not found`), }, { desc: "repository not found", args: []string{"-virtual-storage=virtual-storage", "-repository=non-existent", "-replication-factor=2"}, - error: status.Error(codes.Unknown, `set replication factor: repository "virtual-storage"/"non-existent" not found`), + error: status.Error(codes.InvalidArgument, `set replication factor: repository "virtual-storage"/"non-existent" not found`), }, { desc: "successfully set", |