diff options
| author | Justin Tobler <jtobler@gitlab.com> | 2022-11-08 22:53:42 +0300 |
|---|---|---|
| committer | Justin Tobler <jtobler@gitlab.com> | 2022-11-11 16:57:55 +0300 |
| commit | d5303e924079c32961d8f5a8a7d96cfe09a3d892 (patch) | |
| tree | 52c21ec19258e9eaa0192d1817e8ef08dc8c2f84 /cmd | |
| parent | 1ba70888404fcb9719d4eb33481f57138bce7447 (diff) | |
Praefect: Remove clock drift readiness checkjt-readiness-rpc
Currently the Praefect readiness RPC performs a clock drift check when
invoked. This clock drift check calls the configured NTP service to
validate the time against. If the NTP service call fails, the readiness
check is considered failed. The clock drift check should not be included
in the readiness check as it is more of a host problem. Also for
deployments that depend on the readiness RPC to signal readiness, a
failed response from the NTP service could inaccurately reflect the
state of Praefect.
This change removes the clock drift check from the checks performed by
the readiness RPC.
Diffstat (limited to 'cmd')
| -rw-r--r-- | cmd/praefect/main.go | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/cmd/praefect/main.go b/cmd/praefect/main.go index 078db25df..daed37853 100644 --- a/cmd/praefect/main.go +++ b/cmd/praefect/main.go @@ -436,7 +436,7 @@ func run( protoregistry.GitalyProtoPreregistered, nodeSet.Connections(), primaryGetter, - service.AllChecks(), + service.ReadinessChecks(), ) ) metricsCollectors = append(metricsCollectors, transactionManager, coordinator, repl) |