Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitaly.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorZeger-Jan van de Weg <git@zjvandeweg.nl>2020-05-27 15:50:31 +0300
committerZeger-Jan van de Weg <git@zjvandeweg.nl>2020-05-29 11:16:29 +0300
commit4fa59a2930143998f91a3849556696bb3103c009 (patch)
tree14ae43310ba46716118187efa5a1a655fe84baa8 /config.praefect.toml.example
parenta1fe1986c75312d557b73f13fe35587462c4ca5f (diff)
failover: Default to enabling SQL strategy
Given the SQL strategy is a reasonable default, and tested well enough, this change makes the SQL strategy the preferred strategy. This was `local`, which creates dataloss scenarios when multiple Praefects are behind a load balancer. Additionally, this changes behaviour around the read only feature. This would default to being enabled. Currently availability is favoured over consistency. Now this is flipped. Fixes: https://gitlab.com/gitlab-org/gitaly/-/issues/2682
Diffstat (limited to 'config.praefect.toml.example')
-rw-r--r--config.praefect.toml.example4
1 files changed, 2 insertions, 2 deletions
diff --git a/config.praefect.toml.example b/config.praefect.toml.example
index 8b768a93d..9552c868b 100644
--- a/config.praefect.toml.example
+++ b/config.praefect.toml.example
@@ -31,8 +31,8 @@ listen_addr = "127.0.0.1:2305"
[failover]
enabled = true
-election_strategy = "local" # Options: local, sql
-read_only_after_failover = false # Switch the virtual storage to read-only mode after after a failover.
+election_strategy = "sql" # Options: local, sql. Defaults to 'sql'.
+read_only_after_failover = true # Switch the virtual storage to read-only mode after after a failover.
[[virtual_storage]]
name = 'praefect'