diff options
author | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2020-11-19 10:57:19 +0300 |
---|---|---|
committer | James Fargher <proglottis@gmail.com> | 2020-11-23 03:49:41 +0300 |
commit | 9b7bf8e3d25cf8ca9084078600919a05e8f25a40 (patch) | |
tree | af95570d52157ccec121da76e222b12b364e7c7e /doc | |
parent | 253f65193b68d2cec598f4ca9601cd2afb62f270 (diff) |
docs: Remove text that Gitaly doesn't use Git2Go
Diffstat (limited to 'doc')
-rw-r--r-- | doc/DESIGN.md | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/doc/DESIGN.md b/doc/DESIGN.md index 49a7e1ee1..b41786f9d 100644 --- a/doc/DESIGN.md +++ b/doc/DESIGN.md @@ -74,5 +74,4 @@ All design decisions should be added here. 1. By default all Go packages in the Gitaly repository use the `/internal` directory, unless we explicitly want to export something. The only exception is the `/cmd` directory for executables. 1. GitLab requests should use as few Gitaly gRPC calls as possible. This means it is OK to move GitLab application logic into Gitaly when it saves us gRPC round trips. 1. Defining new gRPC calls is cheap. It is better to define a new 'high level' gRPC call and save gRPC round trips than to chain / combine 'low level' gRPC calls. -1. Why doesn't Gitaly use a Git library like [git2go](https://github.com/libgit2/git2go) or [go-git](https://github.com/src-d/go-git)? We intentionally isolate Git queries in individual processes. We could (and may) use Git libraries to make custom query executables but we seem to get by well enough with regular `git`. 1. Why is Gitaly written in Go? At the time the project started the only practical options were Ruby and Go. We expected to be able to handle more traffic with fewer resources if we used Go. Today (Q3 2019), part of Gitaly is written in Ruby. On the particular Gitaly server that hosts gitlab-org/gitlab-ce, we have a pool of gitaly-ruby processes using a total 20GB of RSS and handling 5 requests per second. The single Gitaly Go process on that machine uses less than 3GB of memory and handles 90 requests per second. |