diff options
| author | Pavlo Strokov <pstrokov@gitlab.com> | 2021-02-12 12:03:50 +0300 |
|---|---|---|
| committer | Pavlo Strokov <pstrokov@gitlab.com> | 2021-02-16 19:01:04 +0300 |
| commit | f7615e3d21faf25521d63d0ed2948c80fa98aa65 (patch) | |
| tree | d239c373a85a6b660e593ebc865d742fcd98947d /doc | |
| parent | 9685d8b4dcdad5b0feebb41d1c3a429bbbd9b578 (diff) | |
Removal of git.NewCommand
After long rounds of refactoring we finally can remove
git.NewCommand function.
The change also includes removal of the TODO left because
of the NewCommand usage with the global config.Config variable.
And as a final step the doc is updated and now mentions usage
of the git.CommandFactory interface instead of git.NewCommand().
Part of: https://gitlab.com/gitlab-org/gitaly/-/issues/2699
Diffstat (limited to 'doc')
| -rw-r--r-- | doc/serverside_git_usage.md | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/doc/serverside_git_usage.md b/doc/serverside_git_usage.md index dafa58993..4826fc610 100644 --- a/doc/serverside_git_usage.md +++ b/doc/serverside_git_usage.md @@ -33,7 +33,7 @@ altered. #### Executing Git commands -When executing Git, developers should always use the `git.NewCommand()` and sibling +When executing Git, developers should always use the `git.CommandFactory` and sibling interfaces. These make sure Gitaly is protected against command injection, the correct `git` is used, and correct setup for observable command invocations are used. When working with `git(1)` in Ruby, please be sure to read the |