diff options
author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-15 15:09:50 +0300 |
---|---|---|
committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-04-19 08:50:38 +0300 |
commit | d0cd87646fef26355163517ffb685d98ddc670b7 (patch) | |
tree | 94c859fb3db8e5a774ea3d89b56a0e66972eda16 /go.mod | |
parent | 33850d9dd5cbcf33bd3437f20adea138665d7c0b (diff) |
proxy: Detect Goroutine leaks via goleak
We have been bitten by Goroutine leaks in the GRPC proxying code in some
cases, but until now we didn't have any meaningful way to detect this
kind of leak.
Fix the test gap by using go.uber.org/goleak to detect any leaked
Goroutines after the test. This nicely demonstrates that we currently do
have a Goroutine leak in the proxying code in `forwardClienToServers()`.
Diffstat (limited to 'go.mod')
-rw-r--r-- | go.mod | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -41,6 +41,7 @@ require ( github.com/uber/jaeger-client-go v2.15.0+incompatible gitlab.com/gitlab-org/gitlab-shell v1.9.8-0.20201117050822-3f9890ef73dc gitlab.com/gitlab-org/labkit v1.0.0 + go.uber.org/goleak v1.1.10 golang.org/x/exp v0.0.0-20200331195152-e8c3332aa8e5 // indirect golang.org/x/sync v0.0.0-20200625203802-6e8e738ad208 golang.org/x/sys v0.0.0-20210119212857-b64e53b001e4 |