diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2023-09-05 15:31:08 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2023-09-05 15:46:11 +0300 |
| commit | beb7fb699afbbd56efc6736f63e9c372609e3f83 (patch) | |
| tree | c83924c3bc4f94e5350ad467b0da1a23239ff95e /go.sum | |
| parent | 2e3b774032b4759603cc3f668d648eecf8066953 (diff) | |
grpc/backchannel: Simplify logging with yamux
We're currently passing in an `io.WriteCloser()` to Yamux that is then
being used as logger. This has the consequence that we're quite tied to
the actual implementation of the logger because `WriterLevel()` is not
something that's typically available in other logging libraries. But
more importantly, it means that all log messages are now written at the
error level, which isn't quite what we want.
The current setup is actually a limitation of the Yamux package itself:
we can either pass in a log writer, or a `log.Logger`. We don't really
want either though. This limitation has been fixed upstream via 13a7bc0
(Fix hashicorp/yamux#72, abstract logger into interface, 2019-04-15),
which converts starts to accept an interface instead of a `log.Logger`.
The library didn't release a new version since then though, and given
that this is change has been implemented four years ago, it seems quite
unlikely that a new release will be created soonish. That being said
though, upgrading to that unstable version should be fine as the only
change between our current v0.1.1 and that commit is the change to use
that logger interface.
Let's upgrade Yamux to the version including this change and refactor
our code to pass the `logrus.FieldLogger` directly instead of passing
an `io.Writer`.
Diffstat (limited to 'go.sum')
| -rw-r--r-- | go.sum | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -395,8 +395,8 @@ github.com/hashicorp/golang-lru v0.5.0/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ github.com/hashicorp/golang-lru v0.5.1/go.mod h1:/m3WP610KZHVQ1SGc6re/UDhFvYD7pJ4Ao+sR/qLZy8= github.com/hashicorp/golang-lru/v2 v2.0.6 h1:3xi/Cafd1NaoEnS/yDssIiuVeDVywU0QdFGl3aQaQHM= github.com/hashicorp/golang-lru/v2 v2.0.6/go.mod h1:QeFd9opnmA6QUJc5vARoKUSoFhyfM2/ZepoAG6RGpeM= -github.com/hashicorp/yamux v0.1.1 h1:yrQxtgseBDrq9Y652vSRDvsKCJKOUD+GzTS4Y0Y8pvE= -github.com/hashicorp/yamux v0.1.1/go.mod h1:CtWFDAQgb7dxtzFs4tWbplKIe2jSi3+5vKbgIO0SLnQ= +github.com/hashicorp/yamux v0.1.2-0.20220728231024-8f49b6f63f18 h1:IVujPV6DRIu1fYF4zUHrfhkngJzmYjelXa+iSUiFZSI= +github.com/hashicorp/yamux v0.1.2-0.20220728231024-8f49b6f63f18/go.mod h1:CtWFDAQgb7dxtzFs4tWbplKIe2jSi3+5vKbgIO0SLnQ= github.com/hhatto/gorst v0.0.0-20181029133204-ca9f730cac5b h1:Jdu2tbAxkRouSILp2EbposIb8h4gO+2QuZEn3d9sKAc= github.com/hhatto/gorst v0.0.0-20181029133204-ca9f730cac5b/go.mod h1:HmaZGXHdSwQh1jnUlBGN2BeEYOHACLVGzYOXCbsLvxY= github.com/hpcloud/tail v1.0.0 h1:nfCOvKYfkgYP8hkirhJocXT2+zOD8yUNjXaWfTlyFKI= |