diff options
author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-06-30 12:39:51 +0300 |
---|---|---|
committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2022-07-06 09:13:10 +0300 |
commit | 8a7bee35e279a75a4e861ccff4d1eb222df15adc (patch) | |
tree | 9257b08ac51a2523266d301d1f8f134722de5dc9 /internal/git2go/executor.go | |
parent | d460daf3ab1a1b11587a362e5b796d13b57947b1 (diff) |
git2go: Refactor featureflag subcommand to not use raw flags
The featureflag subcommand is only used for testing purposes to assert
that we can indeed pass feature flags from the `git2go.Executor()` to
the process we're about to spawn. We're using raw feature flags for this
purpose, but we're about to remove them in favor of using the type-safe
`FeatureFlag` structure.
Convert the subcommand to return a new `FeatureFlag` structure that we
can use to more thoroughly check whether things behave as expected and
remove usage of `RawFromContext()` to prepare for its removal.
Note that while this is a breaking change to the calling interface of
the `gitaly-git2go` executable, this command is only ever used in our
tests. So in practice, this doesn't matter.
Diffstat (limited to 'internal/git2go/executor.go')
0 files changed, 0 insertions, 0 deletions