diff options
| author | Sami Hiltunen <shiltunen@gitlab.com> | 2022-01-20 19:12:12 +0300 |
|---|---|---|
| committer | Sami Hiltunen <shiltunen@gitlab.com> | 2022-02-02 14:24:22 +0300 |
| commit | acaad3637701826dacac0c394411f3beb8cfe9c7 (patch) | |
| tree | ac0b3f173e07a67896363c91e9af016fedf9405e /internal/gitaly/service/repository/testhelper_test.go | |
| parent | a514eb9024d5b7b2583e44515a3dd2f706e72e26 (diff) | |
Disable metadata force creation in repository service tests
This commit disables metadata force creation in repository service
tests when it is ran with Praefect. This ensures any problems in
Praefect are not hidden by the hack. Disabling the hack surfaces few
behavior deviations with differing error messages.
The RenameRepository tests do not work with Praefect without the
metadata creation hack. This is due to a bug in Praefect where the
rename still gets applied even if the Gitalys failed the rename.
As this is an existing bug, the test is skipped for now with a link
to the tracking issue.
Diffstat (limited to 'internal/gitaly/service/repository/testhelper_test.go')
| -rw-r--r-- | internal/gitaly/service/repository/testhelper_test.go | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/internal/gitaly/service/repository/testhelper_test.go b/internal/gitaly/service/repository/testhelper_test.go index ea03e9e56..300f11de3 100644 --- a/internal/gitaly/service/repository/testhelper_test.go +++ b/internal/gitaly/service/repository/testhelper_test.go @@ -116,6 +116,8 @@ func assertModTimeAfter(t *testing.T, afterTime time.Time, paths ...string) bool } func runRepositoryServerWithConfig(t testing.TB, cfg config.Cfg, rubySrv *rubyserver.Server, opts ...testserver.GitalyServerOpt) string { + opts = append(opts, testserver.WithDisableMetadataForceCreation()) + return testserver.RunGitalyServer(t, cfg, rubySrv, func(srv *grpc.Server, deps *service.Dependencies) { gitalypb.RegisterRepositoryServiceServer(srv, NewServer( cfg, |