Static code analysis with govet

govet tool helps to identify a lot of common mistakes such as
unused\dead\unreachable code, wrong context usage\copy by value
of the locking primitives, etc.
It is enabled with disabled check for `uses unkeyed fields`.

2 files changed, 2 insertions, 1 deletions

diff --git a/internal/praefect/grpc-proxy/proxy/handler.go b/internal/praefect/grpc-proxy/proxy/handler.go
index 69012235e..5ea376e07 100644
--- a/internal/praefect/grpc-proxy/proxy/handler.go
+++ b/internal/praefect/grpc-proxy/proxy/handler.go
@@ -109,6 +109,7 @@ func (s *handler) handler(srv interface{}, serverStream grpc.ServerStream) error
 	defer params.RequestFinalizer()
 
 	clientCtx, clientCancel := context.WithCancel(params.Context())
+	defer clientCancel()
 	// TODO(mwitkow): Add a `forwarded` header to metadata, https://en.wikipedia.org/wiki/X-Forwarded-For.
 	clientStream, err := grpc.NewClientStream(clientCtx, clientStreamDescForProxying, params.Conn(), fullMethodName, params.CallOptions()...)
 	if err != nil {
diff --git a/internal/praefect/grpc-proxy/proxy/handler_test.go b/internal/praefect/grpc-proxy/proxy/handler_test.go
index 55e5a800d..0e247d8bd 100644
--- a/internal/praefect/grpc-proxy/proxy/handler_test.go
+++ b/internal/praefect/grpc-proxy/proxy/handler_test.go
@@ -140,7 +140,7 @@ type ProxyHappySuite struct {
 
 func (s *ProxyHappySuite) ctx() context.Context {
 	// Make all RPC calls last at most 1 sec, meaning all async issues or deadlock will not kill tests.
-	ctx, _ := context.WithTimeout(context.TODO(), 120*time.Second)
+	ctx, _ := context.WithTimeout(context.TODO(), 120*time.Second) // nolint: govet
 	return ctx
 }