diff options
| author | Pavlo Strokov <pstrokov@gitlab.com> | 2021-02-12 12:03:50 +0300 |
|---|---|---|
| committer | Pavlo Strokov <pstrokov@gitlab.com> | 2021-02-16 19:01:04 +0300 |
| commit | f7615e3d21faf25521d63d0ed2948c80fa98aa65 (patch) | |
| tree | d239c373a85a6b660e593ebc865d742fcd98947d /internal/praefect/info_service_test.go | |
| parent | 9685d8b4dcdad5b0feebb41d1c3a429bbbd9b578 (diff) | |
Removal of git.NewCommand
After long rounds of refactoring we finally can remove
git.NewCommand function.
The change also includes removal of the TODO left because
of the NewCommand usage with the global config.Config variable.
And as a final step the doc is updated and now mentions usage
of the git.CommandFactory interface instead of git.NewCommand().
Part of: https://gitlab.com/gitlab-org/gitaly/-/issues/2699
Diffstat (limited to 'internal/praefect/info_service_test.go')
| -rw-r--r-- | internal/praefect/info_service_test.go | 4 |
1 files changed, 0 insertions, 4 deletions
diff --git a/internal/praefect/info_service_test.go b/internal/praefect/info_service_test.go index d4cd89c74..d10aaea2f 100644 --- a/internal/praefect/info_service_test.go +++ b/internal/praefect/info_service_test.go @@ -26,10 +26,6 @@ func TestInfoService_RepositoryReplicas(t *testing.T) { cfg.Storages[i].Path = storagePath } - // TODO: this should be removed once we get rid of git.NewCommand function and replace it's usage with git.CommandFactory - defer func(old []gconfig.Storage) { gconfig.Config.Storages = old }(gconfig.Config.Storages) - gconfig.Config.Storages = cfg.Storages - gitalyAddr, cleanupGitaly := testserver.RunGitalyServer(t, cfg, nil) defer cleanupGitaly() |