Welcome to mirror list, hosted at ThFree Co, Russian Federation.

gitlab.com/gitlab-org/gitaly.git - Unnamed repository; edit this file 'description' to name the repository.
summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorPatrick Steinhardt <psteinhardt@gitlab.com>2020-06-22 14:41:33 +0300
committerPatrick Steinhardt <psteinhardt@gitlab.com>2020-07-01 08:50:17 +0300
commit1d645f9d7a5b46fc67cc38fc12fb933b1ff54afc (patch)
tree60b5ba65562921e56f806964f27ae4d0efee82f6 /internal/praefect/transactions
parent5f57584c189c2e551a8cb6ea3fbe53caa5d85c5a (diff)
transactions: Update outdated comment
Back when the transactions manager was introduced, it only handled a single voter at once. While this has changed to allow for multiple voters, a comment wasn't updated to reflect this. So let's update it to avoid any confusion.
Diffstat (limited to 'internal/praefect/transactions')
-rw-r--r--internal/praefect/transactions/manager.go7
1 files changed, 2 insertions, 5 deletions
diff --git a/internal/praefect/transactions/manager.go b/internal/praefect/transactions/manager.go
index 37c54e459..ec4047185 100644
--- a/internal/praefect/transactions/manager.go
+++ b/internal/praefect/transactions/manager.go
@@ -167,11 +167,8 @@ func (mgr *Manager) voteTransaction(ctx context.Context, transactionID uint64, n
}
// VoteTransaction is called by a client who's casting a vote on a reference
-// transaction. As we currently only have primary nodes which perform reference
-// transactions, this function doesn't yet do anything of interest but will
-// always instruct the node to commit, if given valid transaction parameters.
-// In future, it will wait for all clients of a given transaction to start the
-// transaction and perform a vote.
+// transaction. It will wait for all clients of a given transaction to start
+// the transaction and perform a vote.
func (mgr *Manager) VoteTransaction(ctx context.Context, transactionID uint64, node string, hash []byte) error {
start := time.Now()
defer func() {