diff options
author | Jacob Vosmaer <jacob@gitlab.com> | 2020-03-11 16:06:19 +0300 |
---|---|---|
committer | Jacob Vosmaer <jacob@gitlab.com> | 2020-03-11 16:06:19 +0300 |
commit | 778cc7245a367c73d8a8854385cc8014319fdc0b (patch) | |
tree | ccadd482c8960b5d7ad36f95dbd5970720492a21 /internal/service/commit/filter_shas_with_signatures_test.go | |
parent | 67d4350058a6f76a8a3d4133aaaaf96bf8a5698b (diff) | |
parent | a4a8b24b817429cb74656feb57ceabdd472f37d9 (diff) |
Merge branch 'jc-praefect-test-changes' into 'master'
Bypass praefect server in tests that check the error message
See merge request gitlab-org/gitaly!1799
Diffstat (limited to 'internal/service/commit/filter_shas_with_signatures_test.go')
-rw-r--r-- | internal/service/commit/filter_shas_with_signatures_test.go | 19 |
1 files changed, 1 insertions, 18 deletions
diff --git a/internal/service/commit/filter_shas_with_signatures_test.go b/internal/service/commit/filter_shas_with_signatures_test.go index f5715f225..877a58f5b 100644 --- a/internal/service/commit/filter_shas_with_signatures_test.go +++ b/internal/service/commit/filter_shas_with_signatures_test.go @@ -7,7 +7,6 @@ import ( "github.com/stretchr/testify/require" "gitlab.com/gitlab-org/gitaly/internal/testhelper" "gitlab.com/gitlab-org/gitaly/proto/go/gitalypb" - "google.golang.org/grpc/codes" ) func TestFilterShasWithSignaturesSuccessful(t *testing.T) { @@ -66,23 +65,7 @@ func TestFilterShasWithSignaturesSuccessful(t *testing.T) { } func TestFilterShasWithSignaturesValidationError(t *testing.T) { - ctx, cancel := testhelper.Context() - defer cancel() - - server, serverSocketPath := startTestServices(t) - defer server.Stop() - - client, conn := newCommitServiceClient(t, serverSocketPath) - defer conn.Close() - - stream, err := client.FilterShasWithSignatures(ctx) - require.NoError(t, err) - - require.NoError(t, stream.Send(&gitalypb.FilterShasWithSignaturesRequest{})) - require.NoError(t, stream.CloseSend()) - - _, err = recvFSWS(stream) - testhelper.RequireGrpcError(t, err, codes.InvalidArgument) + err := validateFirstFilterShasWithSignaturesRequest(&gitalypb.FilterShasWithSignaturesRequest{}) require.Contains(t, err.Error(), "no repository given") } |