Merge branch 'jc-praefect-test-changes' into 'master'

Bypass praefect server in tests that check the error message

See merge request gitlab-org/gitaly!1799

1 files changed, 1 insertions, 18 deletions

diff --git a/internal/service/commit/filter_shas_with_signatures_test.go b/internal/service/commit/filter_shas_with_signatures_test.go
index f5715f225..877a58f5b 100644
--- a/internal/service/commit/filter_shas_with_signatures_test.go
+++ b/internal/service/commit/filter_shas_with_signatures_test.go
@@ -7,7 +7,6 @@ import (
 	"github.com/stretchr/testify/require"
 	"gitlab.com/gitlab-org/gitaly/internal/testhelper"
 	"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
-	"google.golang.org/grpc/codes"
 )
 
 func TestFilterShasWithSignaturesSuccessful(t *testing.T) {
@@ -66,23 +65,7 @@ func TestFilterShasWithSignaturesSuccessful(t *testing.T) {
 }
 
 func TestFilterShasWithSignaturesValidationError(t *testing.T) {
-	ctx, cancel := testhelper.Context()
-	defer cancel()
-
-	server, serverSocketPath := startTestServices(t)
-	defer server.Stop()
-
-	client, conn := newCommitServiceClient(t, serverSocketPath)
-	defer conn.Close()
-
-	stream, err := client.FilterShasWithSignatures(ctx)
-	require.NoError(t, err)
-
-	require.NoError(t, stream.Send(&gitalypb.FilterShasWithSignaturesRequest{}))
-	require.NoError(t, stream.CloseSend())
-
-	_, err = recvFSWS(stream)
-	testhelper.RequireGrpcError(t, err, codes.InvalidArgument)
+	err := validateFirstFilterShasWithSignaturesRequest(&gitalypb.FilterShasWithSignaturesRequest{})
 	require.Contains(t, err.Error(), "no repository given")
 }