proto: Fix accessors mislabeled as mutators

Besides other things, the accessor/mutator label for RPCs influences
routing decisions, queueing of replication jobs and registration of
transactions. While accessors may get routed to any up-to-date node,
mutators will need to get routed either to the primary or to all nodes
at once when strong consistency is enabled. As a result, accessors are
typically served a lot more efficiently.

We currently have two functions which seem to be mislabeled as mutators
while they will only access repository info:

    - /gitaly.RepositoryService/RepositorySize: this reports the
      repository size by spawning `du -sk` on the repository.

    - /gitaly.SSHService/SSHUploadArchive: this spawns `git
      upload-archive`, which will create a Git archive on the server
      side and feed it into a client-side `git archive` call.

Both are readonly and thus shouldn't have a mutator label, so let's fix
this and reclassify them as accessors.

4 files changed, 48 insertions, 48 deletions

diff --git a/proto/go/gitalypb/repository-service.pb.go b/proto/go/gitalypb/repository-service.pb.go
index f5939f509..e868f994a 100644
--- a/proto/go/gitalypb/repository-service.pb.go
+++ b/proto/go/gitalypb/repository-service.pb.go
@@ -4153,48 +4153,48 @@ var fileDescriptor_e9b1768cf174c79b = []byte{
 	0x91, 0xd7, 0x95, 0x62, 0xf6, 0x25, 0x5c, 0x4b, 0xd6, 0x62, 0xd1, 0x4a, 0xf4, 0x1e, 0xcc, 0xab,
 	0x0d, 0x1b, 0xb7, 0x8a, 0xba, 0x53, 0x8c, 0xbf, 0x56, 0x88, 0x6f, 0xac, 0xea, 0xaa, 0xcd, 0x5c,
 	0x50, 0xe4, 0xd5, 0x66, 0x2e, 0x2c, 0xd8, 0xc6, 0xf4, 0x4e, 0x96, 0x41, 0xb5, 0xde, 0xb9, 0x15,
-	0x57, 0xad, 0x77, 0x7e, 0xf5, 0x34, 0x62, 0xec, 0x00, 0xca, 0x96, 0x2f, 0x51, 0xb4, 0x3d, 0x85,
-	0xd5, 0x54, 0xc3, 0x1c, 0x35, 0x24, 0x25, 0xe4, 0x00, 0x66, 0x62, 0x35, 0x3c, 0x14, 0x6d, 0x54,
-	0xb6, 0x32, 0x6a, 0xdc, 0xcc, 0xed, 0xcb, 0x1a, 0x3b, 0x9d, 0x74, 0x69, 0x63, 0x17, 0x94, 0x05,
-	0xb5, 0xb1, 0x0b, 0x4b, 0x7c, 0x21, 0xfb, 0x97, 0x00, 0xba, 0x52, 0xa5, 0x3d, 0x2e, 0x53, 0x63,
-	0xd3, 0x1e, 0x97, 0x2d, 0x6c, 0x85, 0xcc, 0x1e, 0x0b, 0x6d, 0xd3, 0x95, 0x27, 0xad, 0x6d, 0x41,
-	0xa1, 0x4b, 0x6b, 0x5b, 0x54, 0xb4, 0x8a, 0x47, 0x60, 0xa6, 0x94, 0xa3, 0x23, 0xb0, 0xa8, 0x80,
-	0xa5, 0x23, 0xb0, 0xb0, 0x0e, 0x14, 0xd9, 0xe3, 0xbf, 0x60, 0x6a, 0x27, 0x70, 0xce, 0xd0, 0x5c,
-	0x34, 0x45, 0x57, 0x81, 0x8c, 0xf9, 0x24, 0x31, 0x35, 0x75, 0x1b, 0xaa, 0x61, 0x21, 0x04, 0x2d,
-	0x26, 0xbc, 0x5d, 0x17, 0x75, 0x8c, 0x66, 0xb6, 0x23, 0xc5, 0xe6, 0x04, 0xae, 0x26, 0xaa, 0x18,
-	0x68, 0x39, 0x92, 0x9a, 0x53, 0x4c, 0x31, 0x56, 0x0a, 0x7a, 0x53, 0x96, 0x7b, 0x0e, 0xa0, 0xab,
-	0x0b, 0x7a, 0x9f, 0x33, 0x15, 0x10, 0xbd, 0xcf, 0x39, 0xc5, 0x88, 0x58, 0x20, 0x65, 0x0b, 0x04,
-	0x3a, 0x90, 0x0a, 0x0b, 0x16, 0x3a, 0x90, 0x8a, 0xeb, 0x0b, 0x91, 0xc6, 0x42, 0x48, 0x1a, 0xd2,
-	0x8f, 0x0b, 0x29, 0x28, 0x31, 0xc4, 0x85, 0x14, 0x55, 0x04, 0x22, 0x21, 0x34, 0x5b, 0x5a, 0x57,
-	0x50, 0x3c, 0xba, 0x5f, 0x14, 0x43, 0xc9, 0xca, 0x80, 0xf1, 0xe1, 0x8f, 0x8e, 0x4b, 0x59, 0xef,
-	0x18, 0xea, 0x71, 0x28, 0x1e, 0xdd, 0x4c, 0x32, 0x48, 0x60, 0x96, 0xc6, 0x72, 0x7e, 0x67, 0x72,
-	0x19, 0x8f, 0x4b, 0xe8, 0xe7, 0x60, 0x14, 0xa3, 0x91, 0xe8, 0xa3, 0x51, 0x3a, 0x26, 0x05, 0x7e,
-	0xfc, 0x3e, 0x43, 0x93, 0x2b, 0x7a, 0x50, 0x42, 0x7b, 0x50, 0x8b, 0x10, 0x72, 0xd4, 0x2c, 0xc2,
-	0xf7, 0x8d, 0xa5, 0x9c, 0x9e, 0x94, 0x75, 0xbe, 0x80, 0x7a, 0x1c, 0xf1, 0xd6, 0xd6, 0xc9, 0x01,
-	0xdb, 0xb5, 0x75, 0x72, 0x41, 0xf2, 0xf8, 0x91, 0xac, 0x31, 0xd3, 0xd8, 0x91, 0x9c, 0x01, 0x66,
-	0x63, 0x47, 0x72, 0x16, 0x64, 0x8d, 0x9c, 0xa6, 0x2d, 0xfe, 0x8e, 0x48, 0x02, 0x9d, 0x28, 0xfe,
-	0x7b, 0x42, 0x2e, 0xb2, 0xaa, 0x4f, 0xa1, 0x42, 0x94, 0x34, 0xb6, 0x9f, 0xdf, 0xc0, 0x6c, 0x06,
-	0xb9, 0xd4, 0x32, 0x8a, 0xa0, 0x52, 0x2d, 0xa3, 0x10, 0xf6, 0x8c, 0x56, 0xb1, 0x01, 0x15, 0xf5,
-	0x4f, 0x13, 0x5a, 0x88, 0x66, 0x25, 0x7e, 0x98, 0x32, 0x16, 0x33, 0xf4, 0x94, 0x65, 0x8f, 0x60,
-	0x26, 0x06, 0x6b, 0xa2, 0xf8, 0x1d, 0x91, 0x82, 0x2b, 0xb5, 0x65, 0x73, 0x70, 0xd0, 0xd8, 0xba,
-	0x7f, 0xc1, 0xb3, 0x9b, 0x11, 0x20, 0x23, 0xfa, 0x64, 0x94, 0x7f, 0xa6, 0x85, 0x3e, 0x7c, 0xbf,
-	0xc1, 0xa9, 0x55, 0xfd, 0x3f, 0x5c, 0x4d, 0x00, 0x66, 0xfa, 0x04, 0xce, 0x43, 0x35, 0xf5, 0x09,
-	0x9c, 0x8b, 0xb2, 0xc5, 0xd6, 0x76, 0x06, 0xf3, 0x79, 0x38, 0x06, 0xba, 0xab, 0xa3, 0xa2, 0x10,
-	0x91, 0x31, 0xee, 0x8d, 0x1e, 0x94, 0x11, 0xd6, 0x86, 0xd9, 0x0c, 0x28, 0xa4, 0x1d, 0xa8, 0x08,
-	0xc5, 0xd2, 0x0e, 0x54, 0x88, 0x28, 0xc5, 0x64, 0x60, 0x40, 0xd9, 0xd2, 0x10, 0x8a, 0xbd, 0x77,
-	0x0b, 0x2a, 0x54, 0xfa, 0x88, 0x1e, 0x51, 0x59, 0xd2, 0x87, 0x4b, 0x1b, 0x66, 0x33, 0xd5, 0x20,
-	0xbd, 0x94, 0xa2, 0xf2, 0x93, 0x5e, 0x4a, 0x61, 0x29, 0x29, 0xb6, 0x94, 0xd7, 0x70, 0x3d, 0x85,
-	0x5e, 0xa0, 0x5b, 0x89, 0x57, 0x43, 0x06, 0x6c, 0x31, 0x56, 0x0b, 0xfb, 0x53, 0xfe, 0x44, 0x60,
-	0x21, 0x1f, 0xa3, 0x40, 0x1f, 0xc4, 0x5c, 0xa7, 0x18, 0x1e, 0x31, 0xee, 0xff, 0xd8, 0xb0, 0x54,
-	0x68, 0x9f, 0xc0, 0xd5, 0x44, 0x7a, 0xad, 0x1d, 0x38, 0x0f, 0xf4, 0xd0, 0x0e, 0x9c, 0x0f, 0x38,
-	0x84, 0xcb, 0xf0, 0x52, 0x88, 0x44, 0x98, 0xb4, 0xa3, 0x7b, 0xb9, 0xf3, 0x53, 0xb0, 0x84, 0xf1,
-	0xc1, 0x8f, 0x8c, 0xca, 0xbe, 0x7b, 0xd3, 0xc9, 0x7a, 0x3c, 0x97, 0xcb, 0xc5, 0x06, 0xe2, 0xb9,
-	0x5c, 0x41, 0x9e, 0x9f, 0x60, 0x9f, 0xcc, 0xba, 0xe3, 0xec, 0x73, 0x91, 0x80, 0x38, 0xfb, 0x82,
-	0x84, 0x3d, 0x64, 0xdf, 0x85, 0xb9, 0x9c, 0x9c, 0x19, 0xc5, 0xfc, 0xbe, 0x28, 0xa9, 0x37, 0xee,
-	0x8e, 0x1c, 0x93, 0x7d, 0x89, 0x65, 0xb3, 0x64, 0x1d, 0x81, 0x85, 0x89, 0xb9, 0x8e, 0xc0, 0xe2,
-	0x24, 0x3b, 0x14, 0xb2, 0xf1, 0xf8, 0x35, 0x1f, 0xec, 0xd9, 0xed, 0x35, 0x87, 0xf4, 0x1f, 0xc9,
-	0xcf, 0x4f, 0x09, 0x3d, 0x7d, 0x24, 0x59, 0x3c, 0x12, 0x3f, 0x7e, 0x3f, 0x3a, 0x25, 0xaa, 0x3d,
-	0x68, 0xb7, 0xcb, 0x82, 0xf4, 0xf4, 0x9f, 0x01, 0x00, 0x00, 0xff, 0xff, 0xc8, 0x2b, 0x53, 0x99,
+	0x57, 0xad, 0x77, 0x7e, 0xf5, 0x34, 0xda, 0x3f, 0x07, 0x50, 0xb6, 0x7c, 0x89, 0xa2, 0xed, 0x29,
+	0xac, 0xa6, 0x1a, 0xe6, 0xa8, 0x21, 0x29, 0xed, 0x0f, 0x60, 0x26, 0x56, 0xc3, 0x43, 0xd1, 0x46,
+	0x65, 0x2b, 0xa3, 0xc6, 0xcd, 0xdc, 0xbe, 0xac, 0xb1, 0xd3, 0x49, 0x97, 0x36, 0x76, 0x41, 0x59,
+	0x50, 0x1b, 0xbb, 0xb0, 0xc4, 0x17, 0xb2, 0x7f, 0x09, 0xa0, 0x2b, 0x55, 0xda, 0xe3, 0x32, 0x35,
+	0x36, 0xed, 0x71, 0xd9, 0xc2, 0x56, 0xc8, 0xec, 0xb1, 0xd0, 0x36, 0x5d, 0x79, 0xd2, 0xda, 0x16,
+	0x14, 0xba, 0xb4, 0xb6, 0x45, 0x45, 0xab, 0x78, 0x04, 0x66, 0x4a, 0x39, 0x3a, 0x02, 0x8b, 0x0a,
+	0x58, 0x3a, 0x02, 0x0b, 0xeb, 0x40, 0x91, 0x3d, 0xfe, 0x0b, 0xa6, 0x76, 0x02, 0xe7, 0x0c, 0xcd,
+	0x45, 0x53, 0x74, 0x15, 0xc8, 0x98, 0x4f, 0x12, 0x53, 0x53, 0xb7, 0xa1, 0x1a, 0x16, 0x42, 0xd0,
+	0x62, 0xc2, 0xdb, 0x75, 0x51, 0xc7, 0x68, 0x66, 0x3b, 0x52, 0x6c, 0x4e, 0xe0, 0x6a, 0xa2, 0x8a,
+	0x81, 0x96, 0x23, 0xa9, 0x39, 0xc5, 0x14, 0x63, 0xa5, 0xa0, 0x37, 0x65, 0xb9, 0xe7, 0x00, 0xba,
+	0xba, 0xa0, 0xf7, 0x39, 0x53, 0x01, 0xd1, 0xfb, 0x9c, 0x53, 0x8c, 0x08, 0x55, 0x74, 0x00, 0x65,
+	0x0b, 0x04, 0x3a, 0x90, 0x0a, 0x0b, 0x16, 0x3a, 0x90, 0x8a, 0xeb, 0x0b, 0xf1, 0x68, 0xcd, 0x42,
+	0xfa, 0x71, 0x21, 0x05, 0x25, 0x86, 0xb8, 0x90, 0xa2, 0x8a, 0x40, 0x24, 0x84, 0x66, 0x4b, 0xeb,
+	0x0a, 0x8a, 0x47, 0xf7, 0x8b, 0x62, 0x28, 0x59, 0x19, 0x30, 0x3e, 0xfc, 0xd1, 0x71, 0x29, 0xeb,
+	0x1d, 0x43, 0x3d, 0x0e, 0xc5, 0xa3, 0x9b, 0x49, 0x06, 0x09, 0xcc, 0xd2, 0x58, 0xce, 0xef, 0x4c,
+	0x2e, 0xe3, 0x71, 0x09, 0xfd, 0x1c, 0x8c, 0x62, 0x34, 0x12, 0x7d, 0x34, 0x4a, 0xc7, 0xa4, 0xc0,
+	0x8f, 0xdf, 0x67, 0x68, 0x72, 0x45, 0x0f, 0x4a, 0x68, 0x0f, 0x6a, 0x11, 0x42, 0x8e, 0x9a, 0x45,
+	0xf8, 0xbe, 0xb1, 0x94, 0xd3, 0x93, 0xb2, 0xce, 0x17, 0x50, 0x8f, 0x23, 0xde, 0xda, 0x3a, 0x39,
+	0x60, 0xbb, 0xb6, 0x4e, 0x2e, 0x48, 0x1e, 0x3f, 0x92, 0x35, 0x66, 0x1a, 0x3b, 0x92, 0x33, 0xc0,
+	0x6c, 0xec, 0x48, 0xce, 0x82, 0xac, 0x91, 0xd3, 0xb4, 0xc5, 0xdf, 0x11, 0x49, 0xa0, 0x13, 0xc5,
+	0x7f, 0x4f, 0xc8, 0x45, 0x56, 0xf5, 0x29, 0x54, 0x88, 0x92, 0xc6, 0xf6, 0xf3, 0x1b, 0x98, 0xcd,
+	0x20, 0x97, 0x5a, 0x46, 0x11, 0x54, 0xaa, 0x65, 0x14, 0xc2, 0x9e, 0xd1, 0x2a, 0x36, 0xa0, 0xa2,
+	0xfe, 0x69, 0x42, 0x0b, 0xd1, 0xac, 0xc4, 0x0f, 0x53, 0xc6, 0x62, 0x86, 0x9e, 0xb2, 0xec, 0x11,
+	0xcc, 0xc4, 0x60, 0x4d, 0x14, 0xbf, 0x23, 0x52, 0x70, 0xa5, 0xb6, 0x6c, 0x0e, 0x0e, 0x1a, 0x5b,
+	0xf7, 0x2f, 0x78, 0x76, 0x33, 0x02, 0x64, 0x44, 0x9f, 0x8c, 0xf2, 0xcf, 0xb4, 0xd0, 0x87, 0xef,
+	0x37, 0x38, 0xb5, 0xaa, 0xff, 0x87, 0xab, 0x09, 0xc0, 0x4c, 0x9f, 0xc0, 0x79, 0xa8, 0xa6, 0x3e,
+	0x81, 0x73, 0x51, 0xb6, 0xd8, 0xda, 0xce, 0x60, 0x3e, 0x0f, 0xc7, 0x40, 0x77, 0x75, 0x54, 0x14,
+	0x22, 0x32, 0xc6, 0xbd, 0xd1, 0x83, 0x32, 0xc2, 0xda, 0x30, 0x9b, 0x01, 0x85, 0xb4, 0x03, 0x15,
+	0xa1, 0x58, 0xda, 0x81, 0x0a, 0x11, 0xa5, 0x98, 0x0c, 0x0c, 0x28, 0x5b, 0x1a, 0x42, 0xb1, 0xf7,
+	0x6e, 0x41, 0x85, 0x4a, 0x1f, 0xd1, 0x23, 0x2a, 0x4b, 0xfa, 0x70, 0x69, 0xc3, 0x6c, 0xa6, 0x1a,
+	0xa4, 0x97, 0x52, 0x54, 0x7e, 0xd2, 0x4b, 0x29, 0x2c, 0x25, 0xc5, 0x96, 0xf2, 0x1a, 0xae, 0xa7,
+	0xd0, 0x0b, 0x74, 0x2b, 0xf1, 0x6a, 0xc8, 0x80, 0x2d, 0xc6, 0x6a, 0x61, 0x7f, 0xca, 0x9f, 0x08,
+	0x2c, 0xe4, 0x63, 0x14, 0xe8, 0x83, 0x98, 0xeb, 0x14, 0xc3, 0x23, 0xc6, 0xfd, 0x1f, 0x1b, 0x96,
+	0x0a, 0xed, 0x13, 0xb8, 0x9a, 0x48, 0xaf, 0xb5, 0x03, 0xe7, 0x81, 0x1e, 0xda, 0x81, 0xf3, 0x01,
+	0x87, 0x70, 0x19, 0x5e, 0x0a, 0x91, 0x08, 0x93, 0x76, 0x74, 0x2f, 0x77, 0x7e, 0x0a, 0x96, 0x30,
+	0x3e, 0xf8, 0x91, 0x51, 0xd9, 0x77, 0x6f, 0x3a, 0x59, 0x8f, 0xe7, 0x72, 0xb9, 0xd8, 0x40, 0x3c,
+	0x97, 0x2b, 0xc8, 0xf3, 0x13, 0xec, 0x93, 0x59, 0x77, 0x9c, 0x7d, 0x2e, 0x12, 0x10, 0x67, 0x5f,
+	0x90, 0xb0, 0x87, 0xec, 0xbb, 0x30, 0x97, 0x93, 0x33, 0xa3, 0x98, 0xdf, 0x17, 0x25, 0xf5, 0xc6,
+	0xdd, 0x91, 0x63, 0xb2, 0x2f, 0xb1, 0x6c, 0x96, 0xac, 0x23, 0xb0, 0x30, 0x31, 0xd7, 0x11, 0x58,
+	0x9c, 0x64, 0x87, 0x42, 0x36, 0x1e, 0xbf, 0xe6, 0x83, 0x3d, 0xbb, 0xbd, 0xe6, 0x90, 0xfe, 0x23,
+	0xf9, 0xf9, 0x29, 0xa1, 0xa7, 0x8f, 0x24, 0x8b, 0x47, 0xe2, 0xc7, 0xef, 0x47, 0xa7, 0x44, 0xb5,
+	0x07, 0xed, 0x76, 0x59, 0x90, 0x9e, 0xfe, 0x33, 0x00, 0x00, 0xff, 0xff, 0x6f, 0x00, 0x86, 0xa9,
 	0x49, 0x2e, 0x00, 0x00,
 }
 
diff --git a/proto/go/gitalypb/ssh.pb.go b/proto/go/gitalypb/ssh.pb.go
index 2dfe9e58a..35f1eb7ab 100644
--- a/proto/go/gitalypb/ssh.pb.go
+++ b/proto/go/gitalypb/ssh.pb.go
@@ -450,10 +450,10 @@ var fileDescriptor_ef0eae71e2e883eb = []byte{
 	0x5d, 0xfb, 0x0d, 0xe8, 0xc1, 0xbf, 0xfb, 0xd7, 0x7d, 0x7d, 0xff, 0xe1, 0x06, 0xb6, 0xdc, 0x20,
 	0xec, 0xfe, 0xf9, 0x1e, 0xb5, 0xb6, 0x5a, 0x91, 0x73, 0xe8, 0xa0, 0xf7, 0x70, 0xb7, 0xee, 0x29,
 	0x5a, 0xbd, 0xdc, 0xfc, 0x00, 0xfe, 0xa3, 0x4d, 0x74, 0xad, 0xb8, 0x63, 0x8b, 0x13, 0x18, 0xae,
-	0xcb, 0x88, 0xf6, 0x1b, 0xb3, 0xd5, 0xbd, 0xf4, 0x83, 0xcd, 0x09, 0xcd, 0x16, 0x27, 0x87, 0xef,
-	0xae, 0xd2, 0x05, 0x99, 0x8c, 0x52, 0x39, 0x1b, 0x97, 0xc7, 0xa7, 0x52, 0xb1, 0x71, 0x59, 0x64,
-	0x6c, 0x5f, 0xff, 0x98, 0xc9, 0x2a, 0x2e, 0x26, 0x93, 0xae, 0x85, 0x8e, 0xff, 0x06, 0x00, 0x00,
-	0xff, 0xff, 0x5c, 0xe3, 0xe9, 0xf8, 0x66, 0x05, 0x00, 0x00,
+	0xcb, 0x88, 0xf6, 0x1b, 0xb3, 0xd5, 0xbd, 0xf4, 0x83, 0xcd, 0x09, 0xcd, 0xf9, 0x4f, 0x0e, 0xdf,
+	0x5d, 0xa5, 0x0b, 0x32, 0x19, 0xa5, 0x72, 0x36, 0x2e, 0x8f, 0x4f, 0xa5, 0x62, 0xe3, 0xb2, 0xc8,
+	0xd8, 0xbe, 0xfe, 0x31, 0x93, 0x55, 0x5c, 0x4c, 0x26, 0x5d, 0x0b, 0x1d, 0xff, 0x0d, 0x00, 0x00,
+	0xff, 0xff, 0x38, 0x5c, 0x3c, 0x09, 0x66, 0x05, 0x00, 0x00,
 }
 
 // Reference imports to suppress errors if they are not otherwise used.
diff --git a/proto/repository-service.proto b/proto/repository-service.proto
index 3b886d858..a4759fe49 100644
--- a/proto/repository-service.proto
+++ b/proto/repository-service.proto
@@ -35,7 +35,7 @@ service RepositoryService {
   }
   rpc RepositorySize(RepositorySizeRequest) returns (RepositorySizeResponse) {
     option (op_type) = {
-      op: MUTATOR
+      op: ACCESSOR
     };
   }
   rpc ApplyGitattributes(ApplyGitattributesRequest) returns (ApplyGitattributesResponse) {
diff --git a/proto/ssh.proto b/proto/ssh.proto
index 43367d330..e4f936017 100644
--- a/proto/ssh.proto
+++ b/proto/ssh.proto
@@ -25,7 +25,7 @@ service SSHService {
   // To forward 'git upload-archive' to Gitaly for SSH sessions
   rpc SSHUploadArchive(stream SSHUploadArchiveRequest) returns (stream SSHUploadArchiveResponse) {
     option (op_type) = {
-      op: MUTATOR
+      op: ACCESSOR
     };
   }
 }