diff options
| author | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2021-05-06 13:12:11 +0300 |
|---|---|---|
| committer | Zeger-Jan van de Weg <git@zjvandeweg.nl> | 2021-05-20 14:10:59 +0300 |
| commit | 1dc9b29665ca5138778a8b1c045cceae9ee60d38 (patch) | |
| tree | 0a91f2429544c15addfd473192ec35a73dbe5fc5 /ruby/lib | |
| parent | d39f7a0cb7a6ad7c89f1c8e79a0dd0661b0f7e88 (diff) | |
wiki: Remove DeletePage RPC
The Wiki service has functional duplication with the OperationService
RPCs. This means that if the clients are refactored, the wiki RPCs can
be removed. This change removes the DeletePage RPC as the client that
was using it, is no more: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/57106.
The proto is removed too, as the client is unable to call the RPC and
doesn't use it anymore.
Diffstat (limited to 'ruby/lib')
| -rw-r--r-- | ruby/lib/gitaly_server/wiki_service.rb | 11 | ||||
| -rw-r--r-- | ruby/lib/gitlab/git/wiki.rb | 12 |
2 files changed, 0 insertions, 23 deletions
diff --git a/ruby/lib/gitaly_server/wiki_service.rb b/ruby/lib/gitaly_server/wiki_service.rb index b92cd34ff..7c586e93f 100644 --- a/ruby/lib/gitaly_server/wiki_service.rb +++ b/ruby/lib/gitaly_server/wiki_service.rb @@ -2,17 +2,6 @@ module GitalyServer class WikiService < Gitaly::WikiService::Service include Utils - def wiki_delete_page(request, call) - repo = Gitlab::Git::Repository.from_gitaly(request.repository, call) - wiki = Gitlab::Git::Wiki.new(repo) - page_path = set_utf8!(request.page_path) - commit_details = commit_details_from_gitaly(request.commit_details) - - wiki.delete_page(page_path, commit_details) - - Gitaly::WikiDeletePageResponse.new - end - def wiki_write_page(call) repo = name = format = commit_details = nil content = "" diff --git a/ruby/lib/gitlab/git/wiki.rb b/ruby/lib/gitlab/git/wiki.rb index 445feb0a2..452351afd 100644 --- a/ruby/lib/gitlab/git/wiki.rb +++ b/ruby/lib/gitlab/git/wiki.rb @@ -31,10 +31,6 @@ module Gitlab gollum_write_page(name, format, content, commit_details) end - def delete_page(page_path, commit_details) - gollum_delete_page(page_path, commit_details) - end - def update_page(page_path, title, format, content, commit_details) gollum_update_page(page_path, title, format, content, commit_details) end @@ -137,14 +133,6 @@ module Gitlab raise Gitlab::Git::Wiki::DuplicatePageError, e.message end - def gollum_delete_page(page_path, commit_details) - assert_type!(commit_details, CommitDetails) - - with_committer_with_hooks(commit_details) do |committer| - gollum_wiki.delete_page(gollum_page_by_path(page_path), committer: committer) - end - end - def gollum_update_page(page_path, title, format, content, commit_details) assert_type!(format, Symbol) assert_type!(commit_details, CommitDetails) |