diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-09-21 13:03:49 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-10-06 12:53:41 +0300 |
| commit | 047b1e6afa6d3905c1432c45fd6adc545593c968 (patch) | |
| tree | 42c1d6b1909a6a6624e862ad568bd906cf565c85 /ruby | |
| parent | 9ed7528eb5e1bb2c2a00f938264956eb37e471ae (diff) | |
remote: Drop FetchInternalRemote RPC
The FetchInternalRemote RPC had been used internally to replicate
repositories across different Gitaly nodes. At some point in time, this
was converted to do a direct fetch though without an additional RPC call
because as it turned out, doing inter-Gitaly mutating RPC calls is
problematic in combination with transactions given that the remote side
would now try to cast votes against another Gitaly. Nowadays, there are
no callers left which use this RPC.
Remove the deprecated `FetchInternalRemote()` call. The backing logic
which is still internally called remains though for use in other parts
of Gitaly. We may eventually want to find a better place for it to live.
Changelog: removed
Diffstat (limited to 'ruby')
| -rw-r--r-- | ruby/proto/gitaly/remote_pb.rb | 9 | ||||
| -rw-r--r-- | ruby/proto/gitaly/remote_services_pb.rb | 4 |
2 files changed, 0 insertions, 13 deletions
diff --git a/ruby/proto/gitaly/remote_pb.rb b/ruby/proto/gitaly/remote_pb.rb index 78272e164..a5932587a 100644 --- a/ruby/proto/gitaly/remote_pb.rb +++ b/ruby/proto/gitaly/remote_pb.rb @@ -7,13 +7,6 @@ require 'lint_pb' require 'shared_pb' Google::Protobuf::DescriptorPool.generated_pool.build do add_file("remote.proto", :syntax => :proto3) do - add_message "gitaly.FetchInternalRemoteRequest" do - optional :repository, :message, 1, "gitaly.Repository" - optional :remote_repository, :message, 2, "gitaly.Repository" - end - add_message "gitaly.FetchInternalRemoteResponse" do - optional :result, :bool, 1 - end add_message "gitaly.UpdateRemoteMirrorRequest" do optional :repository, :message, 1, "gitaly.Repository" optional :remote, :message, 7, "gitaly.UpdateRemoteMirrorRequest.Remote" @@ -48,8 +41,6 @@ Google::Protobuf::DescriptorPool.generated_pool.build do end module Gitaly - FetchInternalRemoteRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.FetchInternalRemoteRequest").msgclass - FetchInternalRemoteResponse = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.FetchInternalRemoteResponse").msgclass UpdateRemoteMirrorRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.UpdateRemoteMirrorRequest").msgclass UpdateRemoteMirrorRequest::Remote = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.UpdateRemoteMirrorRequest.Remote").msgclass UpdateRemoteMirrorResponse = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.UpdateRemoteMirrorResponse").msgclass diff --git a/ruby/proto/gitaly/remote_services_pb.rb b/ruby/proto/gitaly/remote_services_pb.rb index fe5cb63aa..d6f316220 100644 --- a/ruby/proto/gitaly/remote_services_pb.rb +++ b/ruby/proto/gitaly/remote_services_pb.rb @@ -14,10 +14,6 @@ module Gitaly self.unmarshal_class_method = :decode self.service_name = 'gitaly.RemoteService' - # FetchInternalRemote used to fetch changes from a remote repository into - # the target repository. This RPC call is deprecated and shouldn't be used - # at all anymore. It will be removed in release v14.4. - rpc :FetchInternalRemote, Gitaly::FetchInternalRemoteRequest, Gitaly::FetchInternalRemoteResponse # UpdateRemoteMirror compares the references in the target repository and its remote mirror # repository. Any differences in the references are then addressed by pushing the differing # references to the mirror. Created and modified references are updated, removed references are |