diff options
| author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-10-18 09:18:57 +0300 |
|---|---|---|
| committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-11-03 09:34:38 +0300 |
| commit | 2f2a001d6d224209ea0952de50d420ff5369884c (patch) | |
| tree | 0de8d6b40a4efd9ba48ec9dc76c6b881aa731240 /ruby | |
| parent | 3b4c8b2211b024b86e3de99f38350ffd1f907417 (diff) | |
objectpool: Drop UnlinkRepostioryFromObjectPool RPC
The UnlikRepostioryFromObjectPool RPC is not used by anything anymore,
and the implementation from it is dangerous given that it doesn't
actually unlink a repository from its object pool: it only tries to
remove a remote named after the pool's project path, which we wouldn't
ever create in the first place. The RPC has thus been deprecated in
release v14.3.
Remove the RPC and its backing code.
Changelog: removed
Diffstat (limited to 'ruby')
| -rw-r--r-- | ruby/proto/gitaly/objectpool_pb.rb | 8 | ||||
| -rw-r--r-- | ruby/proto/gitaly/objectpool_services_pb.rb | 11 |
2 files changed, 0 insertions, 19 deletions
diff --git a/ruby/proto/gitaly/objectpool_pb.rb b/ruby/proto/gitaly/objectpool_pb.rb index cf12ea6a5..f841b88b6 100644 --- a/ruby/proto/gitaly/objectpool_pb.rb +++ b/ruby/proto/gitaly/objectpool_pb.rb @@ -24,12 +24,6 @@ Google::Protobuf::DescriptorPool.generated_pool.build do end add_message "gitaly.LinkRepositoryToObjectPoolResponse" do end - add_message "gitaly.UnlinkRepositoryFromObjectPoolRequest" do - optional :repository, :message, 1, "gitaly.Repository" - optional :object_pool, :message, 2, "gitaly.ObjectPool" - end - add_message "gitaly.UnlinkRepositoryFromObjectPoolResponse" do - end add_message "gitaly.ReduplicateRepositoryRequest" do optional :repository, :message, 1, "gitaly.Repository" end @@ -63,8 +57,6 @@ module Gitaly DeleteObjectPoolResponse = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.DeleteObjectPoolResponse").msgclass LinkRepositoryToObjectPoolRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.LinkRepositoryToObjectPoolRequest").msgclass LinkRepositoryToObjectPoolResponse = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.LinkRepositoryToObjectPoolResponse").msgclass - UnlinkRepositoryFromObjectPoolRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.UnlinkRepositoryFromObjectPoolRequest").msgclass - UnlinkRepositoryFromObjectPoolResponse = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.UnlinkRepositoryFromObjectPoolResponse").msgclass ReduplicateRepositoryRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.ReduplicateRepositoryRequest").msgclass ReduplicateRepositoryResponse = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.ReduplicateRepositoryResponse").msgclass DisconnectGitAlternatesRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.DisconnectGitAlternatesRequest").msgclass diff --git a/ruby/proto/gitaly/objectpool_services_pb.rb b/ruby/proto/gitaly/objectpool_services_pb.rb index e8c932bfd..1abbb56d0 100644 --- a/ruby/proto/gitaly/objectpool_services_pb.rb +++ b/ruby/proto/gitaly/objectpool_services_pb.rb @@ -18,17 +18,6 @@ module Gitaly rpc :DeleteObjectPool, Gitaly::DeleteObjectPoolRequest, Gitaly::DeleteObjectPoolResponse # Repositories are assumed to be stored on the same disk rpc :LinkRepositoryToObjectPool, Gitaly::LinkRepositoryToObjectPoolRequest, Gitaly::LinkRepositoryToObjectPoolResponse - # UnlinkRepositoryFromObjectPool does not unlink the repository from the - # object pool as you'd think, but all it really does is to remove the object - # pool's remote pointing to the repository. And even this is a no-op given - # that we'd try to remove the remote by the repository's `GlRepository()` - # name, which we never create in the first place. To unlink repositories - # from an object pool, you'd really want to execute DisconnectGitAlternates - # to remove the repository's link to the pool's object database. - # - # This function is never called by anyone and highly misleading. It's thus - # deprecated and will be removed in v14.4. - rpc :UnlinkRepositoryFromObjectPool, Gitaly::UnlinkRepositoryFromObjectPoolRequest, Gitaly::UnlinkRepositoryFromObjectPoolResponse rpc :ReduplicateRepository, Gitaly::ReduplicateRepositoryRequest, Gitaly::ReduplicateRepositoryResponse rpc :DisconnectGitAlternates, Gitaly::DisconnectGitAlternatesRequest, Gitaly::DisconnectGitAlternatesResponse rpc :FetchIntoObjectPool, Gitaly::FetchIntoObjectPoolRequest, Gitaly::FetchIntoObjectPoolResponse |