diff options
author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-09-15 10:30:22 +0300 |
---|---|---|
committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-09-15 10:34:27 +0300 |
commit | 50686040de4588533a8a4c8aae03ae373ae041fa (patch) | |
tree | 4d988801dfabd6fc6dbf8551c9bf9a97b335a72b /ruby | |
parent | ccd8ea3e1436d6464ac5f67e6bebd1ae317f4d50 (diff) |
objectpool: Deprecate `UnlinkRepositoryFromObjectPool()`
The `UnlinkRepositoryFromObjectPool()` function is supposed to unlink a
repository from its object pool. But tall it does is to call `Unlink()`,
which in turn only removes the corresponding remote which pointed to the
repository from the object pool's repository. In fact, it's not even
really doing that given that we never create this remote in the first
place. As can be guessed by this no-op action, this RPC call is never
executed by anything.
Deprecate the RPC such that we can remove it in release 14.4.
Changelog: deprecate
Diffstat (limited to 'ruby')
-rw-r--r-- | ruby/proto/gitaly/objectpool_services_pb.rb | 10 |
1 files changed, 10 insertions, 0 deletions
diff --git a/ruby/proto/gitaly/objectpool_services_pb.rb b/ruby/proto/gitaly/objectpool_services_pb.rb index a621571e3..e8c932bfd 100644 --- a/ruby/proto/gitaly/objectpool_services_pb.rb +++ b/ruby/proto/gitaly/objectpool_services_pb.rb @@ -18,6 +18,16 @@ module Gitaly rpc :DeleteObjectPool, Gitaly::DeleteObjectPoolRequest, Gitaly::DeleteObjectPoolResponse # Repositories are assumed to be stored on the same disk rpc :LinkRepositoryToObjectPool, Gitaly::LinkRepositoryToObjectPoolRequest, Gitaly::LinkRepositoryToObjectPoolResponse + # UnlinkRepositoryFromObjectPool does not unlink the repository from the + # object pool as you'd think, but all it really does is to remove the object + # pool's remote pointing to the repository. And even this is a no-op given + # that we'd try to remove the remote by the repository's `GlRepository()` + # name, which we never create in the first place. To unlink repositories + # from an object pool, you'd really want to execute DisconnectGitAlternates + # to remove the repository's link to the pool's object database. + # + # This function is never called by anyone and highly misleading. It's thus + # deprecated and will be removed in v14.4. rpc :UnlinkRepositoryFromObjectPool, Gitaly::UnlinkRepositoryFromObjectPoolRequest, Gitaly::UnlinkRepositoryFromObjectPoolResponse rpc :ReduplicateRepository, Gitaly::ReduplicateRepositoryRequest, Gitaly::ReduplicateRepositoryResponse rpc :DisconnectGitAlternates, Gitaly::DisconnectGitAlternatesRequest, Gitaly::DisconnectGitAlternatesResponse |