diff options
author | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-09-21 09:53:21 +0300 |
---|---|---|
committer | Patrick Steinhardt <psteinhardt@gitlab.com> | 2021-09-21 10:14:54 +0300 |
commit | 6cfa8f2dac97104cbfaa9140d59e834ab3560bc5 (patch) | |
tree | a4b7590516768302b35a7343802d5f3147db239e /ruby | |
parent | 9c57226c3c18791dc55622b481cffcdaa6552b3d (diff) |
repository: Remove `SetConfig()` RPC
Remove the deprecated `SetConfig()` RPC call. Modifying the on-disk
remote is not supported anymore by Gitaly.
Changelog: deprecated
Diffstat (limited to 'ruby')
-rw-r--r-- | ruby/lib/gitaly_server/repository_service.rb | 22 | ||||
-rw-r--r-- | ruby/proto/gitaly/repository-service_pb.rb | 17 | ||||
-rw-r--r-- | ruby/proto/gitaly/repository-service_services_pb.rb | 6 |
3 files changed, 0 insertions, 45 deletions
diff --git a/ruby/lib/gitaly_server/repository_service.rb b/ruby/lib/gitaly_server/repository_service.rb index d4861ec69..cd84ee180 100644 --- a/ruby/lib/gitaly_server/repository_service.rb +++ b/ruby/lib/gitaly_server/repository_service.rb @@ -4,28 +4,6 @@ module GitalyServer class RepositoryService < Gitaly::RepositoryService::Service include Utils - def set_config(request, call) - repo = Gitlab::Git::Repository.from_gitaly(request.repository, call) - - request.entries.each do |entry| - key = entry.key - value = case entry.value - when :value_str - entry.value_str - when :value_int32 - entry.value_int32 - when :value_bool - entry.value_bool - else - raise GRPC::InvalidArgument, "unknown entry type: #{entry.value}" - end - - repo.rugged.config[key] = value - end - - Gitaly::SetConfigResponse.new - end - def find_license(request, call) repo = Gitlab::Git::Repository.from_gitaly(request.repository, call) diff --git a/ruby/proto/gitaly/repository-service_pb.rb b/ruby/proto/gitaly/repository-service_pb.rb index 8753349d2..4db2937f4 100644 --- a/ruby/proto/gitaly/repository-service_pb.rb +++ b/ruby/proto/gitaly/repository-service_pb.rb @@ -175,20 +175,6 @@ Google::Protobuf::DescriptorPool.generated_pool.build do add_message "gitaly.GetConfigResponse" do optional :data, :bytes, 1 end - add_message "gitaly.SetConfigRequest" do - optional :repository, :message, 1, "gitaly.Repository" - repeated :entries, :message, 2, "gitaly.SetConfigRequest.Entry" - end - add_message "gitaly.SetConfigRequest.Entry" do - optional :key, :string, 1 - oneof :value do - optional :value_str, :string, 2 - optional :value_int32, :int32, 3 - optional :value_bool, :bool, 4 - end - end - add_message "gitaly.SetConfigResponse" do - end add_message "gitaly.RestoreCustomHooksRequest" do optional :repository, :message, 1, "gitaly.Repository" optional :data, :bytes, 2 @@ -392,9 +378,6 @@ module Gitaly CreateBundleFromRefListResponse = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.CreateBundleFromRefListResponse").msgclass GetConfigRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.GetConfigRequest").msgclass GetConfigResponse = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.GetConfigResponse").msgclass - SetConfigRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.SetConfigRequest").msgclass - SetConfigRequest::Entry = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.SetConfigRequest.Entry").msgclass - SetConfigResponse = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.SetConfigResponse").msgclass RestoreCustomHooksRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.RestoreCustomHooksRequest").msgclass RestoreCustomHooksResponse = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.RestoreCustomHooksResponse").msgclass BackupCustomHooksRequest = ::Google::Protobuf::DescriptorPool.generated_pool.lookup("gitaly.BackupCustomHooksRequest").msgclass diff --git a/ruby/proto/gitaly/repository-service_services_pb.rb b/ruby/proto/gitaly/repository-service_services_pb.rb index 409ee8a4e..37c2187f4 100644 --- a/ruby/proto/gitaly/repository-service_services_pb.rb +++ b/ruby/proto/gitaly/repository-service_services_pb.rb @@ -46,12 +46,6 @@ module Gitaly # GetConfig reads the target repository's gitconfig and streams its contents # back. Returns a NotFound error in case no gitconfig was found. rpc :GetConfig, Gitaly::GetConfigRequest, stream(Gitaly::GetConfigResponse) - # SetConfig writes a set of config entries into the target repository's - # gitconfig. This RPC is deprecated with no general replacement: modifying - # the on-disk gitconfig is not supported anymore. The only usecase that is - # still supported is writing "gitlab.fullpath" via the new `SetFullPath()` - # RPC. - rpc :SetConfig, Gitaly::SetConfigRequest, Gitaly::SetConfigResponse rpc :FindLicense, Gitaly::FindLicenseRequest, Gitaly::FindLicenseResponse rpc :GetInfoAttributes, Gitaly::GetInfoAttributesRequest, stream(Gitaly::GetInfoAttributesResponse) rpc :CalculateChecksum, Gitaly::CalculateChecksumRequest, Gitaly::CalculateChecksumResponse |