diff options
| author | Jacob Vosmaer <jacob@gitlab.com> | 2019-03-06 18:55:05 +0300 |
|---|---|---|
| committer | Paul Okstad <pokstad@gitlab.com> | 2019-03-06 18:55:05 +0300 |
| commit | b68b92af845a8377de2a49d8eb2cdf75d17ec982 (patch) | |
| tree | d753a8284dcc7483c4e05c1dcb0468274432f58f /ruby | |
| parent | b8cb00077a3b84a18c62212c11cd6653800f7ba5 (diff) | |
Stop using gitlab-shell hooks -- but keep using gitlab-shell config
Diffstat (limited to 'ruby')
| -rw-r--r-- | ruby/lib/gitlab/git/hook.rb | 4 | ||||
| -rw-r--r-- | ruby/lib/gitlab/git/repository.rb | 7 | ||||
| -rw-r--r-- | ruby/spec/lib/gitlab/git/repository_spec.rb | 2 |
3 files changed, 8 insertions, 5 deletions
diff --git a/ruby/lib/gitlab/git/hook.rb b/ruby/lib/gitlab/git/hook.rb index 1b2979cc2..222c93d3b 100644 --- a/ruby/lib/gitlab/git/hook.rb +++ b/ruby/lib/gitlab/git/hook.rb @@ -7,6 +7,10 @@ module Gitlab Gitlab.config.git.hooks_directory end + def self.legacy_hooks_directory + File.join(Gitlab.config.gitlab_shell.path, 'hooks') + end + GL_PROTOCOL = 'web' attr_reader :name, :path, :repository diff --git a/ruby/lib/gitlab/git/repository.rb b/ruby/lib/gitlab/git/repository.rb index 6f4bd9910..1a0b7d044 100644 --- a/ruby/lib/gitlab/git/repository.rb +++ b/ruby/lib/gitlab/git/repository.rb @@ -62,10 +62,9 @@ module Gitlab repo = Rugged::Repository.init_at(repo_path, true) repo.close - # TODO: remove this when self healing hooks has been merged at least - # one release ago: https://gitlab.com/gitlab-org/gitaly/merge_requests/886 - symlink_hooks_to = Gitlab::Git::Hook.directory - create_hooks(repo_path, symlink_hooks_to) if symlink_hooks_to.present? + # TODO: stop symlinking to the old hooks location in or after GitLab 12.0. + # https://gitlab.com/gitlab-org/gitaly/issues/1392 + create_hooks(repo_path, Gitlab::Git::Hook.legacy_hooks_directory) end def create_hooks(repo_path, global_hooks_path) diff --git a/ruby/spec/lib/gitlab/git/repository_spec.rb b/ruby/spec/lib/gitlab/git/repository_spec.rb index 677be7aa9..4364b8818 100644 --- a/ruby/spec/lib/gitlab/git/repository_spec.rb +++ b/ruby/spec/lib/gitlab/git/repository_spec.rb @@ -40,7 +40,7 @@ describe Gitlab::Git::Repository do # rubocop:disable Metrics/BlockLength describe '.create_hooks' do let(:repo_path) { File.join(storage_path, 'hook-test.git') } let(:hooks_dir) { File.join(repo_path, 'hooks') } - let(:target_hooks_dir) { Gitlab::Git::Hook.directory } + let(:target_hooks_dir) { Gitlab::Git::Hook.legacy_hooks_directory } let(:existing_target) { File.join(repo_path, 'foobar') } before do |