| Age | Commit message (Collapse) | Author |
|---|
|
In 1c30884b4 (Create help text style guide for project, 2023-06-12), we
have globally set the maximum line length to 120 characters. While fine
in general, this change also impacts commit messages. This conflicts
with our Danger rules though, which require a maximum line length of 72
characters
Amend the EditorConfig to address this issue.
|
|
|
|
We don't enforce any line limits in our project, but we still set up
some reasonable recommendations via our EditorConfig. Let's also
recommend a line length of 100 characters for Protobuf definitions,
which matches the line length we have specified for Go files.
|
|
The editorconfig is currently lacking a line length configuration for Go
code. This is probably by design given that we do not have an explicit
limit on line length in our style guide. But it's still helpful to have
a reasonable limit set, even if we're not going to enforce it.
Let's configure a line limit of 100 characters. This is not a new
requirement but should rather be seen as a recommendation and help for
users who use editorconfig.
|
|
While there is no real need to configure indentantion for Markdown
files, it makes sense to configure the maximum line width. A quick
survey suggested that many of our existing documents fit into a maximum
line width of 80 characters, so let's use that value.
|
|
The editorconfig file does not currently have any forced style for
Protobuf files. A quick survey shows that we're indenting these files by
two spaces -- let's extend the editorconfig to reflect this.
|
|
Add an editorconfig file that sets up the expected coding style for
several file types. Values for the given filetypes have been taken from
other GitLab projects and were verified for a small sample count.
|
