| Age | Commit message (Collapse) | Author |
|---|
|
The test `invalid_reference_aborts_the_entire_transaction` is flaky.
Let's quarantine it till we fix the issue.
|
|
ruby: Update dependency gitlab-labkit to '~> 0.31'
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5388
Merged-by: Toon Claes <toon@gitlab.com>
Approved-by: Matthias Käppler <mkaeppler@gitlab.com>
Approved-by: Toon Claes <toon@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
go: Update module github.com/jackc/pgtype to v1.14.0
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5381
Merged-by: karthik nayak <knayak@gitlab.com>
Approved-by: James Fargher <proglottis@gmail.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
[ci skip]
|
|
|
|
|
|
Dangerfile: Don't check old names of renamed files
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5387
Merged-by: Toon Claes <toon@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Toon Claes <toon@gitlab.com>
Co-authored-by: Will Chandler <wchandler@gitlab.com>
|
|
Our `changes_size` Dangerfile currently uses the `added_files` and
`modified_files` methods to get a list of all files to check. However,
`modified_files` may return the old name of a renamed file. When this
occurs, the `diff` property for that file may be `nil`, causing the
danger job to error out with:
bundler: failed to load command: danger (/builds/gitlab-org/gitaly/_build/cache/ruby/ruby/3.0.0/bin/danger)
/builds/gitlab-org/gitaly/_build/cache/ruby/ruby/3.0.0/gems/danger-9.2.0/lib/danger/danger_core/plugins/dangerfile_git_plugin.rb:144:in `info_for_file': \e[31m (Danger::DSLError)
[!] Invalid `Dangerfile` file: \e[31m
[!] Invalid `Dangerfile` file: undefined method `[]' for nil:NilClass\e[0m
# from danger/rules/changes_size/Dangerfile:8
# -------------------------------------------
#
> info = git.info_for_file(file)
#
# -------------------------------------------
\e[0m
# from danger/rules/changes_size/Dangerfile:8
See [0] for full output.
A fix for this was attempted in d763b7b6d (Dangerfile: Fix segfault
when computing change size with renamed files, 2023-01-19), but in this
case `file` is `nil`, rather than `info`.
To prevent this from occurring, capture the list of renames and
remove the old names from the list of files to check. A previously
failing pipeline that now passes can be viewed at [1].
[0] https://gitlab.com/gitlab-org/gitaly/-/jobs/3764808135
[1] https://gitlab.com/gitlab-org/gitaly/-/jobs/3769648816
|
|
|
|
gitaly: Quarantine transaction manager subtest
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5383
Merged-by: Toon Claes <toon@gitlab.com>
Approved-by: Toon Claes <toon@gitlab.com>
Co-authored-by: Justin Tobler <jtobler@gitlab.com>
|
|
Currently the `propose_returns_if_context_is_canceled_before_admission`
subtest in `TestTransactionManager` is flaky and resulting in
intermittent pipeline failures. This change quarantines the test to
prevent execution of the flaky test.
|
|
|
|
blob: Quarantine `TestListAllLFSPointers` tests
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5382
Merged-by: Will Chandler <wchandler@gitlab.com>
Approved-by: James Fargher <proglottis@gmail.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Co-authored-by: Justin Tobler <jtobler@gitlab.com>
|
|
Some tests in `TestListAllLFSPointers` have begun consistently failing.
This change quarantines the test to skip the failing tests.
|
|
|
|
|
|
go: Update golang.org/x/exp digest to 46f607a
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5374
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
|
|
RemoveAll RPC
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5291
Merged-by: James Fargher <proglottis@gmail.com>
Approved-by: Sami Hiltunen <shiltunen@gitlab.com>
Reviewed-by: Sami Hiltunen <shiltunen@gitlab.com>
Reviewed-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: James Fargher <jfargher@gitlab.com>
|
|
|
|
[ci skip]
|
|
[ci skip]
|
|
[ci skip]
|
|
|
|
[ci skip]
|
|
|
|
|
|
go: Update github.com/ProtonMail/go-crypto digest to d1d05f4
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5369
Merged-by: James Fargher <proglottis@gmail.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Approved-by: James Fargher <proglottis@gmail.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
This RPC is unusual in that it needs to erase a lot of repositories in
bulk. We are not expecting to route and replicate the changes as we
would for a typical repository operation. To accommodate this we
intercept the call in order to bulk update the database.
|
|
The RPC will eventually want to bulk erase all repositories from the
praefect DB, as well as telling each gitaly to remove the physical
storage.
|
|
The gitaly implementation here simply removes the entire contents of the
storage directory, hence removing all repositories. It's unlikely that
this RPC will ever be atomic because that would require enough storage
for all the repositories deleted plus all the repositories restored.
Changelog: added
|
|
This RPC is designed to clear a storage before starting a full restore.
The prevents a certain class of bug where if repositories are created
after a backup is taken, then a full restore from backup takes place,
gitlab can no longer creates projects. This is because restore only
removes repositories that it is about to restore, and this eventually
clashes with the repositories created after the backup is taken.
|
|
|
|
template: Add flaky test issue template
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5373
Merged-by: John Cai <jcai@gitlab.com>
Approved-by: John Cai <jcai@gitlab.com>
Co-authored-by: Andras Horvath <ahorvath@gitlab.com>
Co-authored-by: Justin Tobler <jtobler@gitlab.com>
|
|
|
|
dnsresolver: Support DNS scheme in client dial functions
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5367
Merged-by: John Cai <jcai@gitlab.com>
Approved-by: John Cai <jcai@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
|
|
|
|
|
|
go: Update grpc to v1.53.0
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5372
Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: Will Chandler <wchandler@gitlab.com>
|
|
go: Update module github.com/getsentry/sentry-go to v0.18.0
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5370
Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
|
|
In order to standardize the creation of flaky test issues, a new issue
template has been added. This template ensures that the appropriate
labels are applied automatically and tracks whether the flaky test has
been quarantined.
|
|
Update grpc-go to v1.53.0. This requires a small adjustment to
`TestDialNodes` as the error message format for failed connections has
changed slightly.
|
|
|
|
testhelper: Skip quarantined tests
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5362
Merged-by: John Cai <jcai@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Toon Claes <toon@gitlab.com>
Reviewed-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Reviewed-by: John Cai <jcai@gitlab.com>
Co-authored-by: Justin Tobler <jtobler@gitlab.com>
|
|
git: Upgrade to Git security release v2.38.4.gl1 and v2.39.2
See merge request https://gitlab.com/gitlab-org/security/gitaly/-/merge_requests/79
Merged-by: Reuben Pereira <2967854-rpereira2@users.noreply.gitlab.com>
Approved-by: Christian Couder <chriscool@tuxfamily.org>
Approved-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
grpc-proxy: Fix flake caused by race between serving and stopping
Closes #4595
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5366
Merged-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Pavlo Strokov <pstrokov@gitlab.com>
Reviewed-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
housekeeping: Unconditionally write bitmap lookup tables
Closes #4744
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5343
Merged-by: Toon Claes <toon@gitlab.com>
Approved-by: Toon Claes <toon@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
Change dir to SOURCE_DIR prior to go build
Closes #4645
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5363
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Sami Hiltunen <shiltunen@gitlab.com>
Co-authored-by: john.mcdonnell <jmcdonnell@gitlab.com>
|
|
datastore: Increase timeout for storage cleanup test
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5364
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Sami Hiltunen <shiltunen@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
