Age | Commit message (Collapse) | Author |
|
Enable mailmap_options feature flag
Signed-off-by: Siddharth Asthana <siddharthasthana31@gmail.com>
|
|
Use secure ciphers for TLS
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6073
Merged-by: John Cai <jcai@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Co-authored-by: Justin Tobler <jtobler@gitlab.com>
|
|
[ci skip]
|
|
Fix cgroup's MacOS-specific linter failures
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6057
Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Reviewed-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Reviewed-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
|
|
catfile: Implement `--batch-command` mode behind a FF
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6040
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Sami Hiltunen <shiltunen@gitlab.com>
Reviewed-by: Sami Hiltunen <shiltunen@gitlab.com>
Reviewed-by: John Cai <jcai@gitlab.com>
Reviewed-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Karthik Nayak <knayak@gitlab.com>
|
|
'master'
tools/golangci-lint: Update module github.com/spf13/viper to v1.16.0
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5889
Merged-by: karthik nayak <knayak@gitlab.com>
Approved-by: Toon Claes <toon@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
Run hooks in ReceivePack tests
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6061
Merged-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Reviewed-by: Will Chandler <wchandler@gitlab.com>
Reviewed-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Co-authored-by: Will Chandler <wchandler@gitlab.com>
Co-authored-by: Sami Hiltunen <shiltunen@gitlab.com>
|
|
|
|
go: Update module google.golang.org/grpc to v1.56.2
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6074
Merged-by: karthik nayak <knayak@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
go: Update golang.org/x/exp digest to 613f0c0
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6066
Merged-by: karthik nayak <knayak@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
Add more metrics and logs to spawn token
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6039
Merged-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Reviewed-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Reviewed-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
|
|
The viper updates from v1.12.0 onwards breaks backward compatibility.
See https://github.com/spf13/viper/pull/1577. To keep the bot from
updating, let's update the exclude version.
|
|
doc: Refresh Gitaly README.md
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6050
Merged-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Evan Read <eread@gitlab.com>
Reviewed-by: Andras Horvath <ahorvath@gitlab.com>
Reviewed-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Evan Read <eread@gitlab.com>
Co-authored-by: Andras Horvath <ahorvath@gitlab.com>
|
|
In https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5547, we
added the support for CgroupV2. It also introduced some linting
offenses on MacOS. They are mostly about unused functions or types. On
Linux, everything is fine. But on MacOS, files with specific build tags
are not included.
|
|
|
|
|
|
|
|
|
|
The `tls.Config` used to configure the Praefect server does not specify
a cipher suite to be used. Consequently, the default cipher suite
defined by the `tls` package is used which contains ciphers with known
security issues. The Go language maintains a list of cipher suites
without known security issues that can be accessed through
`tls.CipherSuites()`.
Explicitly configure the `tls.Config` for Praefect servers to use the
list of secure cipher suites maintained by Go.
|
|
ci: Fix job rules for `rails-specs` and `rails-specs-cleanup`
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6072
Merged-by: John Cai <jcai@gitlab.com>
Approved-by: John Cai <jcai@gitlab.com>
Co-authored-by: Justin Tobler <jtobler@gitlab.com>
|
|
The `tls.Config` used to configure the Gitaly server does not specify a
cipher suite to be used. Consequently, the default cipher suite defined
by the `tls` package is used which contains ciphers with known security
issues. The Go language maintains a list of cipher suites without known
security issues that can be accessed through `tls.CipherSuites()`.
Explicitly configure the `tls.Config` for Gitaly servers to use the list
of secure cipher suites maintained by Go.
|
|
git2go: Remove "apply" and "commit" subcommands
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6049
Merged-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Approved-by: John Cai <jcai@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
Consume stream to finish in tests
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6063
Merged-by: Toon Claes <toon@gitlab.com>
Approved-by: Toon Claes <toon@gitlab.com>
Co-authored-by: Sami Hiltunen <shiltunen@gitlab.com>
|
|
Remove repository even if there is a failed deletion
Closes #5422
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6043
Merged-by: Will Chandler <wchandler@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Co-authored-by: Sami Hiltunen <shiltunen@gitlab.com>
|
|
For the CI pipeline to run correctly the `rail-specs` job needs the
`start-rails-specs` job to run and the `rails-specs-cleanup` job needs
the `rails-specs` job to run. These jobs have mismatched rules though
preventing them from executing in the same context, which can lead to
pipeline errors.
Make the CI rules for the three jobs all use `rules_run_on_merge` to
ensure they run in the same context.
|
|
|
|
|
|
|
|
|
|
conflicts: Add new field `skip_content_parsing`
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6064
Merged-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Co-authored-by: Karthik Nayak <knayak@gitlab.com>
|
|
Add server-side flag to gitaly-backup create
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6026
Merged-by: Toon Claes <toon@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Toon Claes <toon@gitlab.com>
Co-authored-by: James Fargher <jfargher@gitlab.com>
|
|
conflicts: Implement `ResolveConflicts` with Git
Closes #4580
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5954
Merged-by: Toon Claes <toon@gitlab.com>
Approved-by: John Cai <jcai@gitlab.com>
Reviewed-by: Toon Claes <toon@gitlab.com>
Reviewed-by: John Cai <jcai@gitlab.com>
Reviewed-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Karthik Nayak <knayak@gitlab.com>
|
|
In the previous commit, we introduced the new field `SkipContentParsing`
in the proto definition of `ListConflictFilesRequest`. The field will be
used to skip conflicted file's content parsing and streaming.
Let's implement the usage of the field by simply skipping the content
parsing and streaming section within the `ListConflictFiles` RPC. Also
add a test to test for this new functionality.
|
|
The `ListConflictFiles` RPC merges the provided tree-ish objects and
returns the conflicted files along with their contents. Sometimes, we
don't really care about the content of the conflicted files (for e.g.
merge compatibility checks in CI/CD pipelines).
Parsing file contents and streaming them is a laborious process and
slows down the RPC. We should allow the clients to decide if they really
need the contents of the conflicted files. The new fields will help us
implement the functionality where the RPC would simply check for
conflicts and return the conflicted filenames without the contents.
While we're updating the proto with the new field. We also add missing
documentation for `ListConflictFilesRequest`.
|
|
Don't assert relative paths in various tests
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6062
Merged-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: John Cai <jcai@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Co-authored-by: Sami Hiltunen <shiltunen@gitlab.com>
|
|
Move createBundleFromRefListSender type
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6070
Merged-by: John Cai <jcai@gitlab.com>
Approved-by: John Cai <jcai@gitlab.com>
Co-authored-by: James Fargher <jfargher@gitlab.com>
|
|
This type is used to send refs to the CreateBundleFromRefList RPC. Now
that backup.Repository is extracted it should be moved closer to where
it is used.
|
|
'master'
Switch to using backticks for multiline strings for many commands
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6059
Merged-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Co-authored-by: Evan Read <eread@gitlab.com>
|
|
|
|
TestFailedUserUpdateBranchDueToHooks is asserting the repository's
as it checks that the hooks is executed in the repository. The paths
are subject to change and should not be asserted. Do the same assertion
by checking that PWD matches GIT_DIR.
|
|
TestUserUpdateSubmodule is asserting the repository's path in an
error message. This should be avoided as the repository path may change.
Fix the test to not assert the exact repository path.
|
|
TestUserMergeBranch_failingHooks is not consuming the stream to finish.
This causes unexpected behavior as the RPC is still open when the test
ends. Avoid this by consuming the stream to finish in the test.
|
|
TestUserMergeBranch_failingHooks is not closing the stream in test
scenarios that don't lead to an error. This causes unexpected behavior
as the RPC is still open when the test ends. Avoid this by consuming
the stream to finish in the test.
|
|
TestTagHookOutput is asserting the hooks path in an error message.
The hook path is subject to change and should not be asserted for
equality. Fix the test to not assert the exact path.
|
|
TestBranchHookOutput is asserting the hooks path in an error
message. The hook path is subject to change and should not be asserted
for equality. Fix the test to not assert the exact path.
|
|
git: Implement new function to validate reference names
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6018
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Sami Hiltunen <shiltunen@gitlab.com>
Reviewed-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Reviewed-by: Sami Hiltunen <shiltunen@gitlab.com>
Reviewed-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
|
|
Update Gitaly's Team Member Onboarding.md
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5995
Merged-by: karthik nayak <knayak@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Approved-by: Furhan Shabir <fshabir@gitlab.com>
Co-authored-by: Andras Horvath <ahorvath@gitlab.com>
|
|
Ensure backup.Sink get cleaned up properly
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6046
Merged-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Reviewed-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Reviewed-by: John Cai <jcai@gitlab.com>
Co-authored-by: James Fargher <jfargher@gitlab.com>
|
|
Don't assert repository paths in errors in tests
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6023
Merged-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Reviewed-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Co-authored-by: Sami Hiltunen <shiltunen@gitlab.com>
|