| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
Test WAL with SHA256 in CI
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6468
Merged-by: Toon Claes <toon@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Sami Hiltunen <shiltunen@gitlab.com>
|
|
Standardize on referring to log positions with LSN
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6467
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Reviewed-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
|
|
praefect: Remove DatalossCheck RPC and messages
Closes #5556
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6466
Merged-by: karthik nayak <knayak@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: John Cai <jcai@gitlab.com>
|
|
tempdir: Deduplicate storage paths before cleaning
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6398
Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: James Fargher <jfargher@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: Will Chandler <wchandler@gitlab.com>
|
|
proto: Improve docs in operations.proto
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6443
Merged-by: James Fargher <jfargher@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: James Fargher <jfargher@gitlab.com>
Reviewed-by: James Fargher <jfargher@gitlab.com>
Reviewed-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Co-authored-by: James Liu <jliu@gitlab.com>
|
|
proto: Document Diff Service
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6192
Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Reviewed-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Reviewed-by: Evan Read <eread@gitlab.com>
Co-authored-by: John Cai <jcai@gitlab.com>
|
|
|
|
|
|
proto: Add more documentation
Closes #5114
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6441
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Sami Hiltunen <shiltunen@gitlab.com>
Reviewed-by: Sami Hiltunen <shiltunen@gitlab.com>
Reviewed-by: John Cai <jcai@gitlab.com>
Reviewed-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Karthik Nayak <knayak@gitlab.com>
|
|
LSN or log sequence number is the usual term used to refer to a given
position in a log. Our code is currently using log index in most places.
This commit standardizes the name to LSN by renaming each use of log index
to LSN. This way we'll have easier time also writing documentation later
that refers to LSNs.
|
|
The Snapshot type contained previously more fields. With the introduction
of the file system level snapshots, we no longer had to track for example
the version of the hooks that should be used in the transaction. Nowadays
the Snapshot only contains the read index field, which is the log index the
transaction is reading the partition's state at. Simplify by removing the
Snapshot type and replacing it with snapshotLSN field that directly records
the LSN the transaction is reading at.
|
|
Add missing comments for the definitions in commit.proto.
Delete definitions which aren't in use anymore.
|
|
The documentation for PaginationParams and PaginationCursor is not
consistent at this point. So let's make it consistent and also point to
the documentation for the messages themselves to centralize the
documenation.
|
|
Remove mentions of the `internal/allowed` endpoint from the comments for
error responses as this functionality may be handled differently in the
near future.
|
|
The user field shares the same semantics across RPCs in
operations.proto:
- It defines the actor to execute the action as, such as merging or
creating a branch.
- It's used for external authentication and authorization checks, e.g
via the Rails' `internal/allowed` endpoint.
Since this field is used in the same way, make the comments consistent
across all usages.
|
|
|
|
|
|
|
|
The `pre_receive_error` and `git_error` fields in the
`UserRebaseConfirmableResponse` are no longer being used by the
implementing code. Deprecate these fields and add a comment explaining
that a structured error will be returned.
Changelog: deprecated
|
|
|
|
|
|
|
|
|
|
|
|
As suggested by the documentation, `branch` is no longer used and should
be considered deprecated. Add the protobuf field option to solidify
this.
Changelog: deprecated
|
|
|
|
|
|
tools/goimports: Update module golang.org/x/tools to v0.14.0
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6452
Merged-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Christian Couder <chriscool@tuxfamily.org>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
doc: Add instructions on invoking gRPC endpoints locally
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6456
Merged-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Evan Read <eread@gitlab.com>
Reviewed-by: Will Chandler <wchandler@gitlab.com>
Reviewed-by: Evan Read <eread@gitlab.com>
Co-authored-by: Evan Read <eread@gitlab.com>
Co-authored-by: James Liu <jliu@gitlab.com>
|
|
Currently we run the tempdir against every storage configured for
Gitaly. However, some installations may list every storage present in
rails in the Gitaly config, using the same path for all of them. This
allows admins to share a Gitaly config across all Gitaly servers, but
means that we cannot assume that each storage configured is unique.
To cut down on duplicate cleaning runs, let's deduplicate the configured
storages by path. This will have a relatively small performance impact,
as the first cleaning run against a path will have done all the work,
but it will cut down on duplicate entries that clutter Gitaly's logs
during startup.
|
|
global: Replace use of ctxlogrus with injected logger (pt.4)
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6464
Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Reviewed-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
We're currently running TransactionManager's tests with SHA256 as
part of the SHA256 enabled tests. We're not running the `test-wal`
and `test-with-praefect-wal` jobs with SHA256. Those jobs will wire
up transaction management into the test server and run all of our
service tests with WAL enabled. Let's run them also as part of the
SHA256 tests to ensure the service tests work fine with WAL and
SHA256.
|
|
The DatalossCheck RPC has been replaced by the Dataloss RPC. Let's
remove the code, the RPC definition, and associated messages.
|
|
Fix flaky PartitionManager test
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6457
Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: Sami Hiltunen <shiltunen@gitlab.com>
|
|
go: Update module google.golang.org/grpc to v1.58.3
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6463
Merged-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Christian Couder <chriscool@tuxfamily.org>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
TestPartitionManager/starting_transaction_failed_due_to_cancelled_context
is asserting that context cancellation is taken into account while beginning
a transaction. The test is currently flaky as it may be that the
TransactionManager finishes initializing before Begin() is called. This then
triggers indeterministic behavior in Begin(). Either the transaction begins
successfully, or the context cancelation is noticed and it errors out. Fix
this flake by preventing the TransactionManager from running in the test so
it never initializes and the Begin will time out.
|
|
PartitionManager currently depends on the concrete TransactionManager
type. This makes testing some scenarios difficult as we can't mock
out TransactionManager's behavior. This commit changes the
PartitionManager to take in an interface instead.
|
|
'master'
Update Team Member Onboarding.md to inlcude how to request gcp-host-profiles-sg group access
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6417
Merged-by: Andras Horvath <ahorvath@gitlab.com>
Approved-by: Andras Horvath <ahorvath@gitlab.com>
Reviewed-by: karthik nayak <knayak@gitlab.com>
Reviewed-by: Eric Ju <eju@gitlab.com>
Co-authored-by: Eric Ju <eju@gitlab.com>
|
|
|
|
Update our STYLE.md to reflect modern best practices around
context-aware logging. Most importantly, we don't use the ctxlogrus
package anymore and instead use context-aware logging functions like
`DebugContext()` and related functions.
|
|
|
|
Prepare tests for plugging in transactions
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/6461
Merged-by: James Liu <jliu@gitlab.com>
Approved-by: James Liu <jliu@gitlab.com>
Reviewed-by: Sami Hiltunen <shiltunen@gitlab.com>
Co-authored-by: Sami Hiltunen <shiltunen@gitlab.com>
|
|
We have replaced all external users of the ctxlogrus-based functions
`log.FromContext()` and `log.LgorusLogger.ToContext()` to instead use
logging functions like `DebugContext()` and related. Let's thus make the
ctxlogrus-based functionality private.
|
|
The ctxlogrus package is going away with the replacement being log
fields extracted from the context via `log.DebugContext()` et al.
Refactor the code to stop using ctxlogrus by injecting a logger and
using the new context-based logging methods.
|
|
The ctxlogrus package is going away with the replacement being log
fields extracted from the context via `log.DebugContext()` et al.
Refactor the code to stop using ctxlogrus by injecting a logger and
using the new context-based logging methods.
|
|
The ctxlogrus package is going away with the replacement being log
fields extracted from the context via `log.DebugContext()` et al.
Refactor the code to stop using ctxlogrus by injecting a logger and
using the new context-based logging methods.
|
|
The ctxlogrus package is going away with the replacement being log
fields extracted from the context via `log.DebugContext()` et al.
Refactor the code to stop using ctxlogrus by injecting a logger and
using the new context-based logging methods.
|
|
The ctxlogrus package is going away with the replacement being log
fields extracted from the context via `log.DebugContext()` et al.
Refactor the code to stop using ctxlogrus by injecting a logger and
using the new context-based logging methods.
|
