| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
Ignore ruby vendored or temp files in rubocop
See merge request gitlab-org/gitaly!937
|
|
|
|
Don't confuse govendor license with ruby gem .go files
See merge request gitlab-org/gitaly!935
|
|
|
|
Expose prepare-tests from top-level Makefile
See merge request gitlab-org/gitaly!934
|
|
Preparing the test environment would've stayed coupled to make test, but
that is too slow when just testing one package. This would allow users
that know this task exists just run `make prepare-tests`.
|
|
Require storage directories to exist at startup
Closes #1341
See merge request gitlab-org/gitaly!675
|
|
Explicitly set user email before tagging in a test
See merge request gitlab-org/gitaly!930
|
|
Before this commit, I got a local failure:
```
--- FAIL: TestSuccessfulUpdateRemoteMirrorRequest (0.17s)
testhelper.go:158: git [-C /home/zegerjan/src/gitlab.com/gitlab-org/gitaly/internal/testhelper/testdata/data/TestSuccessfulUpdateRemoteMirrorRequest312234598 tag -fam Overriding tag v1.0.0 0b4bc9a49b562e85de7cc9e834518ea6828729b9]
testhelper.go:159:
*** Please tell me who you are.
Run
git config --global user.email "you@example.com"
git config --global user.name "Your Name"
to set your account's default identity.
Omit --global to set the identity only in this repository.
fatal: unable to auto-detect email address (got 'zegerjan@zegerjan-XPS-15-9570.(none)')
testhelper.go:160: exit status 128
```
The problem my system has, is the fact that the email adress can't be
auto detected. This could be fixed on my system, but that might keep the
problem for other developers.
What I don't understand right now, is that I did set the `user.email` on
my local machine. So my first thought is that my user config, located in
$HOME is not respected during tests. Probably because $HOME is not the
same as for my local user.
|
|
Right now GitLab tries to check if the disks are reachable, but this is
not it's responsibility.
This gave a couple of options to how Gitaly would do this, and I've
opted to detect at boot if the storage is reachable. A forgotten mount
will be clear this way, and logged without being hidden between lots of
other messages.
|
|
Make Makefile more predictable by bootstrapping
See merge request gitlab-org/gitaly!913
|
|
Update Prometheus vendoring
See merge request gitlab-org/gitaly!922
|
|
Prevent stale packed-refs file when Gitaly is running on top of NFS
Closes #1339
See merge request gitlab-org/gitaly!924
|
|
Users of the Linux NFS client v4.0 (and even v4.1) may encounter stale file
handles or stale data if git gc is running for a long time. A patch for this
kernel bug is here: https://marc.info/?l=linux-nfs&m=153816500525563&w=2
This workaround calls stat() on the packed-refs file to force the kernel to do
a directory entry validation on the inode.
Closes https://gitlab.com/gitlab-org/gitaly/issues/1339
|
|
Standardize git command invocation
See merge request gitlab-org/gitaly!915
|
|
This propagates our git.GitEnv variables properly, plus DRYes the code
|
|
Update grpc to v1.15.x in gitaly-ruby
See merge request gitlab-org/gitaly!918
|
|
|
|
Fix order in config.toml.example
Closes #1368
See merge request gitlab-org/gitaly!923
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
Bump Code Quality CI/CD Job
See merge request gitlab-org/gitaly!921
|
|
Update client_golang and common vendoring to latest release
* Improves text rendering performance.
* Pin to v0.9.x release.
|
|
Skip lfs smudge for alternate object directoy tests
Closes #1360
See merge request gitlab-org/gitaly!916
|
|
Since Rubocop was introduced pipelines succeeded with warnings, as
Rubocop was newer than the quality checks that ran.
This commit replaces the sample with the one listed in the docs:
https://docs.gitlab.com/ee/ci/examples/code_quality.html
The biggest change is the fact that this does now run a version of these
checks based on CI_SERVER_VERSION. This might break our pipeline, or
create new offences at a moments notice. Given `allow_failure` is still
set to true, this could be alright and saves maintainence time.
|
|
Add unit tests for Blob from gitlab-ce + setup code
See merge request gitlab-org/gitaly!920
|
|
|
|
Enable Rubocop on CI
See merge request gitlab-org/gitaly!919
|
|
To make Rubocop on CI somewhat useful, it has been enabled with some
cops, using the `--auto-correct` flag.
|
|
|
|
Given Rubocop wasn't enfored for a while, this change makes sure there
are no failures. Eventhough this is limited in its usefulness, it allows
for a commit that hopefully passed CI on this branch.
Hooks into `make verify`, ensuring it runs.
|
|
gitlab-styles works on the assumption that ActiveSupport is loaded, and
other Rails stuff is present. Leading to bugs in the rewrite rules.
Defaulting to Rubocop seemed better, and faster for now.
|
|
Fix formatting
See merge request gitlab-org/gitaly!917
|
|
|
|
Force english output on git commands
See merge request gitlab-org/gitaly!898
|
|
For some reason my git got localized in spanish, and we had some tests
failing because they relied on error messages being on english, as well
as some code failing if the text wasn't ASCII-8BIT compatible. These
changes fix those issues.
|
|
Free Rugged open file descriptors in gRPC middleware
Closes #1359
See merge request gitlab-org/gitaly!911
|
|
Fix git protocol prometheus metrics
Closes #1362
See merge request gitlab-org/gitaly!908
|
|
|
|
|
|
Remove deprecated methods
See merge request gitlab-org/gitaly!910
|
