| Age | Commit message (Collapse) | Author |
|---|
|
|
|
|
|
|
|
Once the cache middleware was removed, it created new failures in CI
that alert us to where ref hook options are needed. This updates those
places and removes places where it is no longer needed due to updates in
internal/git/subcommand.go
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
ruby: rename deprecated with_clean_env method
See merge request gitlab-org/gitaly!2757
|
|
operations: Fix error message when UserMergeToRef conflicts
See merge request gitlab-org/gitaly!2756
|
|
When creating the merge commit in UserMergeToRef fails with a conflicf,
then we create an error messages "Failed to create merge commit" with
some details filled in. The error message currently confuses the target
SHA and target reference though.
Fix the error message and add a test to verify we got it correct.
|
|
The with_clean_env method is deprecated since bundler 2.1.0. Now
calling it emits:
[DEPRECATED] `Bundler.wi th_clean_env` has been deprecated in
favor of `Bundler.with_unbundled_env`. If you instead want the
environment before bundler was originally loaded, use
`Bundler.with_original_env` (called at /home/avar/g.gl/gd
k/gitlab-development-kit/gitaly/ruby/lib/gitlab/git/hook.rb:34
We've been warning on 'bundle exec rspec' in the ruby/ directory since
6b8f365b ("Update to Ruby bundler v2.1.4", 2020-10-30). Let's just
rename the method. See [1] for the relevant upstream code.
1. https://github.com/rubygems/bundler/commit/c77f26d53bb56e753c9c612b62d25e6f54fed6b8
|
|
Log LFS smudge activity to gitaly_lfs_smudge.log
See merge request gitlab-org/gitaly!2734
|
|
Group CI yaml template includes together
See merge request gitlab-org/gitaly!2754
|
|
|
|
|
|
|
|
This commit improves the observabiilty of the Gitaly LFS smudge filter
by writing JSON-formatted log messages into `gitaly_lfs_smudge.log`. For
example:
```
{
"content_length_bytes": 1277812,
"correlation_id": "12345",
"gl_repository": "project-206",
"level": "info",
"msg": "completed HTTP request",
"oid": "943b4ffc85218949ba11e45e079d407124c28a36dd172af64450f592fe947761",
"path": "/lfs?oid=943b4ffc85218949ba11e45e079d407124c28a36dd172af64450f592fe947761&gl_repository=project-206",
"status_code": 200,
"time": "2020-11-01T00:29:19-07:00"
}
```
|
|
operations: Always set GL_PROTOCOL in hooks
Closes #3271
See merge request gitlab-org/gitaly!2753
|
|
There were two statements of `include:` in `.gitlab-ci.yml`, the latter
ruled out the first. So bring them together and keep them closer to the
top for better visibility.
Related issue:
https://gitlab.com/gitlab-org/gitaly/-/issues/3264
|
|
Resolve dependency on global state in rubyserver.SetHeaders
See merge request gitlab-org/gitaly!2745
|
|
When updating references via `updateReferenceWithHooks`, then we need to
assemble the envvars to post to the service. But one envvar actually got
lost in the conversion from Ruby to Go, which is the `GL_PROTOCOL`
variable. Not setting this variable may cause GitLab to misinterpret a
change's source and thus fail to correctly apply access control rules.
Add the missing variable. As the function will only ever be called from
other RPCs in the OperationsService, its safe to assume that it'll
always we "web".
|
|
templates: Add feature roll out scoped label
See merge request gitlab-org/gitaly!2752
|
|
Implement a router on the per repository elector stack
See merge request gitlab-org/gitaly!2731
|
|
issues: Remove inaccurate step in feature flag rollout template
See merge request gitlab-org/gitaly!2751
|
|
Store repository host node assignments
See merge request gitlab-org/gitaly!2737
|
|
To understand the issue roll out status faster, and to make the roll out
issues appear on the issue board, the template was updated for new
issues.
|
|
The feature flag rollout template has a step which instructs the user to
enable the fflag for individual groups or projects. Given that Gitaly
doesn't support scoped feature flags at all, this step doesn't make a
lot of sense.
Remove it to avoid any confusion.
|
|
Use labkit-ruby 0.13.2
Closes gitlab-com/gl-infra/scalability#634
See merge request gitlab-org/gitaly!2743
|
|
|
|
Quality of life improvements for feature sets
See merge request gitlab-org/gitaly!2740
|
|
hooks: Remove reftx arguments workaround
Closes #3250
See merge request gitlab-org/gitaly!2736
|
|
Refactor passing of Git envvars to use options
See merge request gitlab-org/gitaly!2735
|
|
README: Fix supported Git versions
See merge request gitlab-org/gitaly!2748
|
|
Move cmd conflicts in a separate package
See merge request gitlab-org/gitaly!2673
|
|
This commit adds a router implementation based on the per repository
elector stack. The behavior deviates in few ways from the current
nodeManager router:
1. RouteStorageMutator is unimplemented as it doesn't appear we should
receive such requests any more with hashed storage. All mutators
should be repository scoped given repository scoped primaries.
2. RouteStorageAccessor routes the requests to any healthy node. We can't
match the behavior of nodeManagerRouter as we don't have a primary for
a virtual storage. This should be fine though, as the only RPC that
is scoped like this only makes a remote call and doesn't depend on any
state on the server.
3. Repository scoped messages respect repository specific primaries as
opposed to virtual storage scoped primaries in the nodeManagerRouter.
This commit does not yet hook up the router to the rest of the code.
|
|
Splits nodeManagerRouter's implementation in its own file in
preparation for adding other router implementations.
|
|
While our minimum required Git version was bumped to v2.29.0, the README
claims that we support v2.26.x and v2.27.x. Fix this inconsistency.
|
|
Restrict node interface in coordinator
See merge request gitlab-org/gitaly!2730
|
|
Require documenting gRPC-protobuf interface
See merge request gitlab-org/gitaly!2722
|
|
|
|
The featureset helper currently doesn't have any tests, but it has grown
to be a widely used helper which did have bugs. This commit adds a few
tests to verify it behaves as expected.
|
