| Age | Commit message (Collapse) | Author |
|---|
|
It happens that goroutine started to Serve() doesn't terminate
after test completion and that fails the test (all started
goroutines must be terminated on test completion).
Now the test waits for all started goroutines to be terminated.
The result returned from the Server() method is also controlled
now and checked for correctness.
Closes: https://gitlab.com/gitlab-org/gitaly/-/issues/3916
|
|
We don't need to call Close() for the listeners as gRPC server
calls it on Stop()/Shutdown() invocation, it is called by the
factory.
|
|
Missing Stop() calls added to terminate all running servers.
|
|
The LimiterMiddleware is not the main subject to test. It makes test
harder to read and understand. It also adds additional functionality
we don't want to test here. We drop it to remove all those concerns.
|
|
'qmnguyen0711/4440-repository-searchfilesbyname-doesn-t-work-well-with-non-ascii-file-names' into 'master'
Fix bug that Repository SearchFilesByName doesn't work well with non-ASCII file names
See merge request gitlab-org/gitaly!4827
|
|
gitlab: Copy client code from `gitlab-shell`
Closes #4341
See merge request gitlab-org/gitaly!4819
|
|
Repository SearchFilesByName doesn't work well with non-ASCII file
names. Underlying, this RPC uses git-ls-tree to get the file names. Git
automatically escapes non-ASCII characters and add the quotes around the
paths. Git defines this behavior with core.quotePath option.
SearchFilesByName did not handle this case well. The solution is to
force git-ls-tree to use NULL-byte termination.
Issue: https://gitlab.com/gitlab-org/gitaly/-/issues/4440
Changelog: fixed
|
|
These files were directly copied over from 'gitlab-shell' in
823a6893bb4275f7d21035a34c778317af7d3d16. Let's fix the linter issues
pre-existing in these files.
|
|
Instead of using the external 'client' package from 'gitlab-shell', use
the internally created one 'internal/gitlab/client'. This drops the
dependency on 'gitlab-shell'.
Run 'go mod tidy' to remove the dependency on 'gitlab-shell' from our
'go.{mod, sum}' files.
|
|
Currently 'gitlab-shell' contains the code for the gitlab client. We use
this in our 'gitaly' code, but this causes a cyclic dependency since
'gitlab-shell' also imports parts of our code.
To remove this cyclic dependency, we decided to move most of the code
in-house. In this commit we do this by copying over the following files:
1. gitlabnet.go
2. httpclient.go
from 'gitlab-shell' without modification to a new 'client' package under
'internal/gitlab'.
We do not copy over the tests, since our repo has its own helpers for
tests which we'll leverage to rewrite the tests.
|
|
go: Update module github.com/pelletier/go-toml to v2
See merge request gitlab-org/gitaly!4652
|
|
With this change we upgrade go-toml to v2. This includes changing the
import paths to include v2.
|
|
go-toml v2 forces us to use `TextMarshaller` and this means we now need
the Duration wrapper in several packages. To prevent import loops, this
requires moving the type to its own package.
|
|
doc: Fix incorrect dashboard URLs
See merge request gitlab-org/gitaly!4824
|
|
'master'
go: Update module gitlab.com/gitlab-org/gitlab-shell/v14 to v14.11.0
See merge request gitlab-org/gitaly!4832
|
|
ruby: Update dependencies
Closes #4430 and #4371
See merge request gitlab-org/gitaly!4826
|
|
[ci skip]
|
|
Currently the README has two images which also serve as hyperlinks, this
is confusing cause its not obvious. Let's make them explicit.
|
|
Update `rails-html-sanitizer` and `addressable` gems to remediate
securitiy vulnerabilities.
|
|
Add support for MulanPSL-2.0 in license detection
See merge request gitlab-org/gitaly!4825
|
|
Revert "config: Set autocrlf to false"
See merge request gitlab-org/gitaly!4833
|
|
This reverts commit d0e60a800ddadd6531a5c4030d86b09564004a21. Due to an
issue with some tests in the main GitLab project this commit needs to be
reverted to unblock the update flow and allow time for further
investigation.
|
|
Remove custom duration type
See merge request gitlab-org/gitaly!4829
|
|
|
|
gitaly: Exit code 1 on error
Closes #4238
See merge request gitlab-org/gitaly!4821
|
|
Back in the day, a custom duration type was added to Gitaly's config
package as the TOML parser used didn't support parsing duration types
natively. The TOML parser used these days supports the native
time.Duration type of Go. Remove the custom type and update all sites
to use the native duration type.
|
|
Update rack and rouge gems to match GitLab Rails
See merge request gitlab-org/gitaly!4817
|
|
go: Update Postgres dependencies
See merge request gitlab-org/gitaly!4818
|
|
Update pg_query gem to v2.1.3
See merge request gitlab-org/gitaly!4815
|
|
Update ffi gem to v1.15.5
See merge request gitlab-org/gitaly!4816
|
|
Counterpart PR in gitlab: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94948
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Changelog: other
|
|
Makefile: Refactor `make git` target
See merge request gitlab-org/gitaly!4804
|
|
The dashboard URLs are pointing to the old gitlab.com URLs, we now use
gitlab.net for dashboards. Lets change the URLs in README.md and
observability.md.
Signed-off-by: Karthik Nayak <knayak@gitlab.com>
|
|
config: Set autocrlf to false
Closes #3476
See merge request gitlab-org/gitaly!4801
|
|
repository: Use git-cat-file to calculate repository size
Closes gitlab#368150
See merge request gitlab-org/gitaly!4797
|
|
Use git-cat-file to list all objects and accumulate the sizes in order
to get a number of the total size of a repository.
Changelog: changed
|
|
Gitaly should be agnostic as a datastore and not transform line
endings. Currently by default `core.autocrlf` is set to `input` which
can transform line endings on commit. This change updates the default
global configuration of `core.autocrlf` to `false` which stops Gitaly
from transforming line endings.
|
|
gitpipe: Support SHA256 object hash
See merge request gitlab-org/gitaly!4798
|
|
Currently in Gitaly when `run()` returns an error and exits the exit
code returned is always 0. On error the exit code should be 1 to reflect
that the process terminated due to an error. This change checks for
errors returned by `run()` and exits with the appropriate error code.
|
|
This matches the versions used in GitLab Rails and helps reduce some
space in the Omnibus build.
Changelog: changed
|
|
This matches the version used in GitLab Rails and helps reduce some
space in the Omnibus build.
Changelog: changed
|
|
This matches the version used in GitLab Rails and helps
reduce some space in the Omnibus build.
Changelog: changed
|
|
|
|
Default enable Praefect generated replica paths
See merge request gitlab-org/gitaly!4809
|
|
fsck: Update fsck ignore rules configuration
Closes #4265 and #4404
See merge request gitlab-org/gitaly!4777
|
|
Added tests to ensure correct configuration of git-fsck(1) is generated
and applied to the command when executed.
|
|
Currently fsck ignore rules configuration only applies to
git-fetch-pack(1) and git-receive-pack(1) commands. These rules should
also apply to the git-fsck(1) command itself. This change unifies the
configuration.
|
|
Use semantic sort for tags
See merge request gitlab-org/gitaly!4336
|
|
Remove default MR template
See merge request gitlab-org/gitaly!4811
|
|
The default MR template creates unnecessary work since we already take
pains to write a coherent and detailed commit message. Once the MR
template supports automatic importing of commit messages, we can add a
default template once again.
|
