| Age | Commit message (Collapse) | Author |
|---|
|
Issue: https://gitlab.com/gitlab-org/gitaly/-/issues/4440
Changelog: fixed
|
|
Update rack and rouge gems to match GitLab Rails
See merge request gitlab-org/gitaly!4817
|
|
go: Update Postgres dependencies
See merge request gitlab-org/gitaly!4818
|
|
Update pg_query gem to v2.1.3
See merge request gitlab-org/gitaly!4815
|
|
Update ffi gem to v1.15.5
See merge request gitlab-org/gitaly!4816
|
|
Makefile: Refactor `make git` target
See merge request gitlab-org/gitaly!4804
|
|
config: Set autocrlf to false
Closes #3476
See merge request gitlab-org/gitaly!4801
|
|
repository: Use git-cat-file to calculate repository size
Closes gitlab#368150
See merge request gitlab-org/gitaly!4797
|
|
Use git-cat-file to list all objects and accumulate the sizes in order
to get a number of the total size of a repository.
Changelog: changed
|
|
Gitaly should be agnostic as a datastore and not transform line
endings. Currently by default `core.autocrlf` is set to `input` which
can transform line endings on commit. This change updates the default
global configuration of `core.autocrlf` to `false` which stops Gitaly
from transforming line endings.
|
|
gitpipe: Support SHA256 object hash
See merge request gitlab-org/gitaly!4798
|
|
This matches the versions used in GitLab Rails and helps reduce some
space in the Omnibus build.
Changelog: changed
|
|
This matches the version used in GitLab Rails and helps reduce some
space in the Omnibus build.
Changelog: changed
|
|
This matches the version used in GitLab Rails and helps
reduce some space in the Omnibus build.
Changelog: changed
|
|
|
|
Default enable Praefect generated replica paths
See merge request gitlab-org/gitaly!4809
|
|
fsck: Update fsck ignore rules configuration
Closes #4265 and #4404
See merge request gitlab-org/gitaly!4777
|
|
Added tests to ensure correct configuration of git-fsck(1) is generated
and applied to the command when executed.
|
|
Currently fsck ignore rules configuration only applies to
git-fetch-pack(1) and git-receive-pack(1) commands. These rules should
also apply to the git-fsck(1) command itself. This change unifies the
configuration.
|
|
Use semantic sort for tags
See merge request gitlab-org/gitaly!4336
|
|
Remove default MR template
See merge request gitlab-org/gitaly!4811
|
|
The default MR template creates unnecessary work since we already take
pains to write a coherent and detailed commit message. Once the MR
template supports automatic importing of commit messages, we can add a
default template once again.
|
|
Adapt the gitpipe package to support repositories that use SHA256 as
object hash by automatically detecting the repository format and enable
testing this package with SHA256.
|
|
The gitpipe tests are not parallelized right now. Fix this by adding the
missing calls to `t.Parallel()`.
|
|
Refactor the Pipeline tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
Refactor the ForEachRef tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
Refactor the Revision tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
Refactor the LsTree tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
Refactor the DiffTree tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
Refactor the CatfileObject tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
Refactor the CatfileInfo tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
golangci-lint: Add the `thelper` linter to enforce more-consistent test style
See merge request gitlab-org/gitaly!4806
|
|
The `thelper` linter has a rule that will flag test helper functions
that don't call `t.Helper()`. Unfortunately, this will also flag all
kinds of functions that really shouldn't have this call, which makes the
linter effectively useless for us.
Document why we disable it to not keep folks wondering.
|
|
Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/17801
**Problem**
Default sort by name for tags often does not produce the expected
result.
```
v1.1.0
v1.10.0
v1.2.0
```
**Solution**
Use semantic sort for tag names
```
v1.1.0
v1.2.0
v1.10.0
```
Changelog: changed
|
|
Enforce consistent naming of `testing.TB` variables, which should be
called `tb`, and adapt tests that violate this rule.
|
|
Enforce that `testing.T` et al must be the first parameter of test
functions. Unfortuntately, the linter explicitly allows for contexts to
precede `testing.T`, which causes us to still not enforce a uniform
style for our test functions.
Fix cases where we violate this rule.
|
|
Add the `thelper` linter, which knows to enforce consistent code styles
around tests:
- `testing.T` should be the first parameter in test-related
functions.
- Functions called by tests should call `t.Helper()`.
- `testing.T`, `testing.B` and testing.TB` variables should be
consistently named as `t`, `b`, and `tb`, respectively.
Right now we still have all rules disabled that would trigger warnings.
|
|
We currently exclude a revive rule that `context.Context` should be the
first parameter for our test sources. This can be handled better though
because golangci-lint allows us to exclude certain types from this rule.
Adapt the rule to allow `testing.T` et al before `context.Context` and
remove the excluded rule. Interestingly, this now surfaces a whole bunch
of `nolint: revive` annotations that aren't needed anymore, so we fix
them in the same commit.
|
|
Update golangci-lint to v1.48.0 and fix two warnings it starts to
surface due to that update.
|
|
gittest: Consolidate functions to create test repositories
See merge request gitlab-org/gitaly!4795
|
|
git: Fix warning on startup about Git binary fallback
See merge request gitlab-org/gitaly!4805
|
|
This commit default enables Praefect generated replica paths feature
flag. The feature flag has been enabled on production since 2022-07-25.
The changes have been exercised on GitLab.com with new repositories that
are mainly forks of GitLab projects that live on the Gitaly Cluster. There
have been no reports of issues and the logs don't surface anything that
seems problematic.
Changelog: changed
|
|
While it makes sense for tests to skip repository creation via the
`CreateRepository()` RPC when they are not testing in a context where
they have a gRPC server available, there should in the general case not
be a reason to skip this in our service-related tests. There still is a
bunch of tests that do this though.
Adjust the tests to not skip the RPC calls to create the repository and
refactor some that didn't make the server address available via the
Gitaly configuration. Note that we need to some touch up some tests
which erroneously created the repository multiple times, which would now
fail with Praefect.
|
|
Consolidate the unused InitRepo and CloneRepo functions. All existing
callers are using CreateRepository with `SkipCreationViaService` set to
`true.
|
|
Convert all callers of CloneRepo to use CreateRepository.
|
|
Convert all callers of InitRepo to use CreateRepository.
|
|
We have two sets of functions to create repositories for testing
purposes:
- CreateRepository creates the repository by calling the respective
RPCs of the RepositoryService. This allows us to properly test
with Praefect as a proxy, which requires the RPC to be called so
that it can set up the repositories in the database.
- InitRepo and CloneRepo, which both will create the repository
without doing an RPC call. These should only be used in contexts
where we don't have a gRPC service available.
It's confusing at times which of both should be used, and we're not
quite consistent.
Unify all functionality to create repositories into CreateRepository and
add a new option `SkipCreationViaService`. If set, this will behave the
same as InitRepo and CloneRepo, which allows us to consolidate the
functions into a single one. Callers that want to skip creation via the
RepositoryService will thus need to explicitly opt-in to this behaviour
and cannot just use InitRepo respectively CloneRepo without knowing
about the ramifications.
|
|
'master'
objectpool: Default-enable pruning of refs to fix reference conflicts
See merge request gitlab-org/gitaly!4807
|
|
limithandler: Remove RateLimiting feature flag
See merge request gitlab-org/gitaly!4796
|
|
'4257-usermergebranch-does-not-verify-it-got-a-user-name-and-email' into 'master'
usermergebranch: add validation for user.{email, name}
Closes #4257
See merge request gitlab-org/gitaly!4800
|
