| Age | Commit message (Collapse) | Author |
|---|
|
Change dir to SOURCE_DIR prior to go build
Closes #4645
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5363
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Sami Hiltunen <shiltunen@gitlab.com>
Co-authored-by: john.mcdonnell <jmcdonnell@gitlab.com>
|
|
datastore: Increase timeout for storage cleanup test
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5364
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Sami Hiltunen <shiltunen@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
Extract file and executable permissions to perm package
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5359
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Reviewed-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: James Fargher <jfargher@gitlab.com>
|
|
git: Fix race between cancelling git-version(1) and reading its output
Closes #4740
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5344
Merged-by: Toon Claes <toon@gitlab.com>
Approved-by: Pavlo Strokov <pstrokov@gitlab.com>
Approved-by: Toon Claes <toon@gitlab.com>
Reviewed-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
These files are only written once and must only be read by gitaly.
|
|
Bulk update all file and executable permissions to use the new perm
package.
Strictly speaking changing os.ModePerm to perm.PublicFile is a
permission change (it goes from executable to normal), but since
ModePerm is only used in tests this should be safe.
|
|
This is in preparation for a bulk permission replace.
|
|
Since these function calls were using untyped constants, the compiler
hadn't picked up that the order of the parameters is wrong. This wont
work once we start using typed permission constants.
|
|
655 is executable by group and other but not user. This doesn't
make a lot of sense. So we change it here to non-executable-shared.
|
|
These directory permissions were missed in the previous MR.
|
|
These "group private executable" permissions are only used in this test.
Instead of creating a constant for this, we just convert it to a more
common permission.
|
|
Onboarding Issue Template: Add PTO Calendar Integration
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5244
Merged-by: John Cai <jcai@gitlab.com>
Approved-by: Andras Horvath <ahorvath@gitlab.com>
|
|
go: Update module github.com/rubenv/sql-migrate to v1.3.1
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5355
Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Pavlo Strokov <pstrokov@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
ssh: Refactor tests for SSHReceivePack
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5358
Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: James Fargher <proglottis@gmail.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
'renovate-tools/golangci-lint/github.com-golangci-golangci-lint-1.x' into 'master'
tools/golangci-lint: Update module github.com/golangci/golangci-lint to v1.51.1
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5337
Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
limithandler: Log queue duration in limit.concurrency_queue_ms log field
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5333
Merged-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Reviewed-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Reviewed-by: Will Chandler <wchandler@gitlab.com>
Co-authored-by: Igor Wiedler <iwiedler@gitlab.com>
|
|
go: Update module golang.org/x/sys to v0.5.0
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5356
Merged-by: Pavlo Strokov <pstrokov@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Approved-by: Pavlo Strokov <pstrokov@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
|
|
[ci skip]
|
|
We've recently seen one of our tests for storage cleanup flake because
it hit the timeout of two seconds. This isn't all that surprising on
machines that are as slow as our CI runners.
Bump the timeout to a full minute. While it would be very much
preferable to refactor the code so that it doesn't need any timeouts in
the first place it doesn't feel worth it to refactor the code now.
|
|
Fixes https://gitlab.com/gitlab-org/gitaly/-/issues/4645 by avoiding situations where the working dir may be
a symlink, but SOURCE_DIR is the resolved path.
|
|
|
|
|
|
|
|
updateref: Fix handling of context cancellation errors
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5345
Merged-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Reviewed-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Reviewed-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
tests: Unseed repositories to enable SHA256 testing
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5353
Merged-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
|
|
go: Fix dependencies which have been inadvertently downgraded
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5354
Merged-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
Approved-by: James Fargher <proglottis@gmail.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
global: Convert generic packages to test with SHA256 object format
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5352
Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
|
|
templates: Update issue template labels
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5342
Merged-by: Andras Horvath <ahorvath@gitlab.com>
Approved-by: Andras Horvath <ahorvath@gitlab.com>
Co-authored-by: Justin Tobler <jtobler@gitlab.com>
|
|
Implement merges using the new 'git merge-tree' command
Closes #4154
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/4479
Merged-by: John Cai <jcai@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: karthik nayak <knayak@gitlab.com>
Reviewed-by: Justin Tobler <jtobler@gitlab.com>
Reviewed-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Christian Couder <chriscool@tuxfamily.org>
|
|
'master'
datastore: Do no enqueue duplicate events
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5325
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Sami Hiltunen <shiltunen@gitlab.com>
Reviewed-by: Sami Hiltunen <shiltunen@gitlab.com>
Reviewed-by: karthik nayak <knayak@gitlab.com>
Co-authored-by: Karthik Nayak <knayak@gitlab.com>
|
|
backup: Resolve locator test linter error
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5349
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Co-authored-by: Justin Tobler <jtobler@gitlab.com>
|
|
go: Update github.com/ProtonMail/go-crypto digest to a47887b
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5273
Merged-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Co-authored-by: GitLab Renovate Bot <gitlab-bot@gitlab.com>
|
|
git: Wire up Git v2.39 execution environment
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5339
Merged-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Approved-by: Pavlo Strokov <pstrokov@gitlab.com>
Reviewed-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Reviewed-by: Pavlo Strokov <pstrokov@gitlab.com>
|
|
Fix dnsresolver flakes
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5350
Merged-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Approved-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Approved-by: Pavlo Strokov <pstrokov@gitlab.com>
Reviewed-by: Patrick Steinhardt <psteinhardt@gitlab.com>
Co-authored-by: Quang-Minh Nguyen <qmnguyen@gitlab.com>
|
|
supervisor: Wait for notifiers to shut down
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5346
Merged-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Will Chandler <wchandler@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
ssh: Remove duplicate and flaky tests for SSHReceivePack
Closes #4777
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5357
Merged-by: Justin Tobler <jtobler@gitlab.com>
Approved-by: Justin Tobler <jtobler@gitlab.com>
Co-authored-by: Patrick Steinhardt <psteinhardt@gitlab.com>
|
|
The helper functions `setupSSHClone()` and `testCloneAndPush()` are
misleadingly named:
- `setupSSHClone()` sounds as if it was setting up a clone via SSH
in some way. But what it's really doing is to set up a repository
from which we can push a change to a remote repository.
- `testCloneAndPush()` sounds as if it was trying to clone and then
push somehow. But it's simply a wrapper that handles creation of
the local repository and pushing to the remote repository in one
function call.
Rename those functions to `setupRepoWithChange()` and
`setupRepoAndPush()` to hopefully clarify the intent.
|
|
Add a bullet for new employees to integrate their PTO-Roots with the
shared Gitaly Team Calendar.
|
|
Stop using a seed repository for SSHReceivePack tests and instead
generate the two test commits at runtime.
|
|
The push parameters structure contains all information required to
perform an SSH-based test push. But ultimately all it is used for is to
set up the `SSHReceivePackRequest` while not even reducing the number of
parameters that need to be provided.
Remove the indirection and just pass requests directly.
|
|
The way the push parameters and clone details are set up is extremely
confused:
- Push parameters contain a subset of the details required to push
to the remote repository.
- Clone details contain details of a newly created local repo that
has a change in it, as well as some additional parameters required
to push to the remote repository.
Disentangle this mess so that the push parameters contain everything
required to push, and clone details contain only information about the
local repository we've set up.
|
|
The `setupSSHClone()` helper sets up a new Git repository that we'll use
as the source of a push. It then returns both the details of that repo
as well as a cleanup function to delete both the created repo's path as
well as the repo we're ultimately pushing into.
Given that we write these repositories into temporary directories that
get cleaned up at the end of the test anyway it is not necessary to
invoke the cleanup function manually. Remove it.
|
|
The `testCloneAndPush()` funciton accepts the socket path of the server
it shall connect to as parameter. This is redundant though given that we
already pass the `config.Cfg` of the server.
Remove the redundant parameter.
|
|
One of our tests for invalid SSHReceivePack requests is duplicated as we
already test for the same condition in `TestReceivePack_validation()`.
Let's merge the other local testcase into our validation tests and
delete the redundant tests.
|
|
With 8a29ef511 (Implement basic transaction processing with write-ahead
logging, 2022-10-14) we have implemented the basic logic for write-ahead
logging of references. As this MR introduced a bunch of logic it has
been taking a comparatively long time to get it reviewed and landed. As
part of that there had seemingly be a merge conflict in the `go.mod`
file that was mis-merged and that caused us to downgrade the following
dependencies:
- github.com/getsentry/sentry-go 0.17.0 => 0.16.0
- github.com/rubenv/sql-migrate 1.3.0 => 1.2.0
- golang.org/x/sys 0.4.0 => 0.3.0
- golang.org/x/time 0.3.0 => 0.2.0
Revert these downgrades so that we're using the intended dependency
versions again.
Changelog: fixed
|
|
Default enable invalid metadata deletion in Praefect
Closes #4429
See merge request https://gitlab.com/gitlab-org/gitaly/-/merge_requests/5321
Merged-by: Sami Hiltunen <shiltunen@gitlab.com>
Approved-by: Toon Claes <toon@gitlab.com>
Approved-by: John Cai <jcai@gitlab.com>
|
|
Convert tests to work with the SHA256 object format by removing the need
for seed repositories.
|
