| Age | Commit message (Collapse) | Author |
|---|
|
It's annoying to keep the list of maintainers up-to-date, so just refer
to the group of maintainers.
|
|
Specify who needs to give approval on Merge Requests.
|
|
[ci skip]
|
|
Add support for MulanPSL-2.0 in license detection
See merge request gitlab-org/gitaly!4825
|
|
Revert "config: Set autocrlf to false"
See merge request gitlab-org/gitaly!4833
|
|
This reverts commit d0e60a800ddadd6531a5c4030d86b09564004a21. Due to an
issue with some tests in the main GitLab project this commit needs to be
reverted to unblock the update flow and allow time for further
investigation.
|
|
Remove custom duration type
See merge request gitlab-org/gitaly!4829
|
|
gitaly: Exit code 1 on error
Closes #4238
See merge request gitlab-org/gitaly!4821
|
|
Back in the day, a custom duration type was added to Gitaly's config
package as the TOML parser used didn't support parsing duration types
natively. The TOML parser used these days supports the native
time.Duration type of Go. Remove the custom type and update all sites
to use the native duration type.
|
|
Update rack and rouge gems to match GitLab Rails
See merge request gitlab-org/gitaly!4817
|
|
go: Update Postgres dependencies
See merge request gitlab-org/gitaly!4818
|
|
Update pg_query gem to v2.1.3
See merge request gitlab-org/gitaly!4815
|
|
Update ffi gem to v1.15.5
See merge request gitlab-org/gitaly!4816
|
|
Counterpart PR in gitlab: https://gitlab.com/gitlab-org/gitlab/-/merge_requests/94948
Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
Changelog: other
|
|
Makefile: Refactor `make git` target
See merge request gitlab-org/gitaly!4804
|
|
config: Set autocrlf to false
Closes #3476
See merge request gitlab-org/gitaly!4801
|
|
repository: Use git-cat-file to calculate repository size
Closes gitlab#368150
See merge request gitlab-org/gitaly!4797
|
|
Use git-cat-file to list all objects and accumulate the sizes in order
to get a number of the total size of a repository.
Changelog: changed
|
|
Gitaly should be agnostic as a datastore and not transform line
endings. Currently by default `core.autocrlf` is set to `input` which
can transform line endings on commit. This change updates the default
global configuration of `core.autocrlf` to `false` which stops Gitaly
from transforming line endings.
|
|
gitpipe: Support SHA256 object hash
See merge request gitlab-org/gitaly!4798
|
|
Currently in Gitaly when `run()` returns an error and exits the exit
code returned is always 0. On error the exit code should be 1 to reflect
that the process terminated due to an error. This change checks for
errors returned by `run()` and exits with the appropriate error code.
|
|
This matches the versions used in GitLab Rails and helps reduce some
space in the Omnibus build.
Changelog: changed
|
|
This matches the version used in GitLab Rails and helps reduce some
space in the Omnibus build.
Changelog: changed
|
|
This matches the version used in GitLab Rails and helps
reduce some space in the Omnibus build.
Changelog: changed
|
|
|
|
Default enable Praefect generated replica paths
See merge request gitlab-org/gitaly!4809
|
|
fsck: Update fsck ignore rules configuration
Closes #4265 and #4404
See merge request gitlab-org/gitaly!4777
|
|
Added tests to ensure correct configuration of git-fsck(1) is generated
and applied to the command when executed.
|
|
Currently fsck ignore rules configuration only applies to
git-fetch-pack(1) and git-receive-pack(1) commands. These rules should
also apply to the git-fsck(1) command itself. This change unifies the
configuration.
|
|
Use semantic sort for tags
See merge request gitlab-org/gitaly!4336
|
|
Remove default MR template
See merge request gitlab-org/gitaly!4811
|
|
The default MR template creates unnecessary work since we already take
pains to write a coherent and detailed commit message. Once the MR
template supports automatic importing of commit messages, we can add a
default template once again.
|
|
Adapt the gitpipe package to support repositories that use SHA256 as
object hash by automatically detecting the repository format and enable
testing this package with SHA256.
|
|
The gitpipe tests are not parallelized right now. Fix this by adding the
missing calls to `t.Parallel()`.
|
|
Refactor the Pipeline tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
Refactor the ForEachRef tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
Refactor the Revision tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
Refactor the LsTree tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
Refactor the DiffTree tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
Refactor the CatfileObject tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
Refactor the CatfileInfo tests to not use seeded repositories with
hardcoded object IDs. Instead, the tests are changed such that they
generate test data at runtime so that we can easily support different
object hashes.
|
|
golangci-lint: Add the `thelper` linter to enforce more-consistent test style
See merge request gitlab-org/gitaly!4806
|
|
The `thelper` linter has a rule that will flag test helper functions
that don't call `t.Helper()`. Unfortunately, this will also flag all
kinds of functions that really shouldn't have this call, which makes the
linter effectively useless for us.
Document why we disable it to not keep folks wondering.
|
|
Contributes to https://gitlab.com/gitlab-org/gitlab/-/issues/17801
**Problem**
Default sort by name for tags often does not produce the expected
result.
```
v1.1.0
v1.10.0
v1.2.0
```
**Solution**
Use semantic sort for tag names
```
v1.1.0
v1.2.0
v1.10.0
```
Changelog: changed
|
|
Enforce consistent naming of `testing.TB` variables, which should be
called `tb`, and adapt tests that violate this rule.
|
|
Enforce that `testing.T` et al must be the first parameter of test
functions. Unfortuntately, the linter explicitly allows for contexts to
precede `testing.T`, which causes us to still not enforce a uniform
style for our test functions.
Fix cases where we violate this rule.
|
|
Add the `thelper` linter, which knows to enforce consistent code styles
around tests:
- `testing.T` should be the first parameter in test-related
functions.
- Functions called by tests should call `t.Helper()`.
- `testing.T`, `testing.B` and testing.TB` variables should be
consistently named as `t`, `b`, and `tb`, respectively.
Right now we still have all rules disabled that would trigger warnings.
|
|
We currently exclude a revive rule that `context.Context` should be the
first parameter for our test sources. This can be handled better though
because golangci-lint allows us to exclude certain types from this rule.
Adapt the rule to allow `testing.T` et al before `context.Context` and
remove the excluded rule. Interestingly, this now surfaces a whole bunch
of `nolint: revive` annotations that aren't needed anymore, so we fix
them in the same commit.
|
|
Update golangci-lint to v1.48.0 and fix two warnings it starts to
surface due to that update.
|
|
gittest: Consolidate functions to create test repositories
See merge request gitlab-org/gitaly!4795
|
