| Age | Commit message (Collapse) | Author |
|---|
|
These helpers should make parsing typed environment variables more
consistent.
|
|
The new "v14" version of the Gitaly module is named to match
the next GitLab release. The module versioning is needed in
order to pull gitaly as a dependency in other projects. The
change updates all imports to include v14 version. The go.mod
file was modified as well after go mod tidy execution. And
the changes in dependency licenses are reflected in the NOTICE
file.
Part of: https://gitlab.com/gitlab-org/gitaly/-/issues/3177
|
|
We're currently explicitly killing the spawned test process in
`TestStolenPid()`. Convert this to instead use `exec.CommandContext()`,
which will automatically kill the child process in case the context gets
canceled. This allows us to get rid of one more linter ignore rule.
|
|
There are several code sites where we do not check the error code of
various functions of the `os` pakcage. Fix this by using
`require.NoError()`, which also uncovers that we're trying to remove a
directory in `RebaseInProgress()` tests which has already been removed
via its parent repository.
|
|
In go1.14+, the go runtime issues SIGURG as an interrupt to support
pre-emptible system calls on Linux. We ignore this signal since it's not
relevant to the Gitaly process.
This reduces a significant amount of log noise.
Relates to https://gitlab.com/gitlab-org/gitaly/-/issues/3454
|
|
Praefect was generating timestamps in the form of
`2021-02-11T17:18:09Z`, while Gitaly included millisecond precision in
`2021-02-11T17:26:53.011Z`.
Closes https://gitlab.com/gitlab-org/gitaly/-/issues/3427
|
|
Package path should be used to manipulate
abstract slash-delimited paths only,
not real file paths.
|
|
When the gitaly PID file is malformed log warning and ignore it.
Malformed the file will be overwritten when the new gitaly process
starts.
relates #2453
Signed-off-by: Mateusz Nowotyński <maxmati4@gmail.com>
|
|
Move bootstrap env vars into bootstrap constructor
See merge request gitlab-org/gitaly!1670
|
|
Both Gitaly and Praefect use the bootstrap package and need to play well
with gitaly-wrapper. This changes praefect to use the same env vars as
gitaly. It also moves the env var retrieval inside the bootstrap
constructor.
|
|
|
|
|
|
|
|
pidfile content may be a reassigned to a new process and gitaly-wrapper will
not start a new gitaly instance.
This commit checks if the process path includes gitaly before adopting a child
process.
|
|
|
