From c926efd9f8b95f69e59efa16fd2ec54413fba713 Mon Sep 17 00:00:00 2001 From: Jacob Vosmaer Date: Mon, 5 Nov 2018 17:47:43 +0100 Subject: Remove migration issue templates --- .gitlab/issue_templates/Conversation_Migration.md | 25 ---- .../Migration_Acceptance_Testing.md | 148 --------------------- .gitlab/issue_templates/Migration_Analysis.md | 20 --- .gitlab/issue_templates/N+1_Query.md | 36 ----- .gitlab/issue_templates/Potential_Endpoint.md | 12 -- 5 files changed, 241 deletions(-) delete mode 100644 .gitlab/issue_templates/Conversation_Migration.md delete mode 100644 .gitlab/issue_templates/Migration_Acceptance_Testing.md delete mode 100644 .gitlab/issue_templates/Migration_Analysis.md delete mode 100644 .gitlab/issue_templates/N+1_Query.md delete mode 100644 .gitlab/issue_templates/Potential_Endpoint.md (limited to '.gitlab') diff --git a/.gitlab/issue_templates/Conversation_Migration.md b/.gitlab/issue_templates/Conversation_Migration.md deleted file mode 100644 index 986a0cfc8..000000000 --- a/.gitlab/issue_templates/Conversation_Migration.md +++ /dev/null @@ -1,25 +0,0 @@ ------------------------------------------------------------- - -**Stages**: - -- [ ] ~"RPC Design": [Link to MR] - -- [ ] ~"Server Implementation": [Link to MR] - -- [ ] ~"Client Implementation": [Link to MR] - -- [ ] ~"Acceptance Testing": [Create Issue](https://gitlab.com/gitlab-org/gitaly/issues/new?issuable_template=Migration_Acceptance_Testing) - -**RPC Endpoints**: - - `Endpoint::Name` - -**Known Client Routes**: - - Known client endpoints - ------------------------------------------------------------- - -/label ~Conversation -/label ~Migration -/label ~"Migration:Ready-for-Development" -/label ~"To Do" -/label ~Gitaly diff --git a/.gitlab/issue_templates/Migration_Acceptance_Testing.md b/.gitlab/issue_templates/Migration_Acceptance_Testing.md deleted file mode 100644 index ccfa3c386..000000000 --- a/.gitlab/issue_templates/Migration_Acceptance_Testing.md +++ /dev/null @@ -1,148 +0,0 @@ -~Conversation: #CONVERSATION_NUMBER - -See the [Migration Process documentation](https://gitlab.com/gitlab-org/gitaly/blob/master/doc/MIGRATION_PROCESS.md#acceptance-testing-acceptance-testing) -for more information on the Acceptance Testing stage of the process. - -## Details -- **Feature Toggle Name**: `GITALY_FEATURE_NAME` -- **GRPC Service**: `GRPC_SERVICE_NAME::GRPC_METHOD_NAME` -- **Required Gitaly Version**: `vX.X.X` -- **Required GitLab Version**: `vX.X` - --------------------------------------------------------------------------------- - -## 1. Preparation - -- [ ] **Routes**: what routes use this migration? - 1. Please list a set of routes that are known to use this endpoint... - 2. ... - 3. ... - -## 2. Development Trial - -#### Check Dev Server Versions -- [ ] Gitaly: [Gitaly Dev Version Tracker Dashboard](https://dashboards.gitlab.net/dashboard/db/gitaly-version-tracker?orgId=1&var-job=gitaly-dev) -- [ ] GitLab: https://dev.gitlab.org/help - -#### Enable on `dev.gitlab.org`: -- [ ] `!feature-set GITALY_FEATURE_NAME true` in [`#dev-gitlab`](https://gitlab.slack.com/messages/C6WQ87MU3) - -Then leave running while monitoring and performing some testing through web, api or SSH. - -#### Monitor (initially ) - -- [ ] **Monitor Grafana** feature dashboard on dev: [Gitaly Feature Status Dashboard](https://dashboards.gitlab.net/dashboard/db/gitaly-feature-status?from=now-12h&to=now&orgId=1&var-method=GRPC_METHOD_NAME&var-job=gitaly-dev&refresh=5m) -- [ ] **Inspect logs** in ELK: - - [GRPC_METHOD_NAME invocations, last hour](https://kibana.gprd.gitlab.com/app/kibana#/discover?_a=%28index%3A'gitaly-*'%2Cquery%3A%28query_string%3A%28query%3A'grpc.method:GRPC_METHOD_NAME%20AND%20hostname:dev'%29%29%29&_g=%28refreshInterval:%28display:Off,pause:!f,value:0%29,time:%28from:now-1h,mode:quick,to:now%29%29) for unusual activity - - [GRPC_METHOD_NAME errors, last hour](https://kibana.gprd.gitlab.com/app/kibana#/discover?_a=%28index%3A'gitaly-*'%2Cquery%3A%28query_string%3A%28query%3A'grpc.method:GRPC_METHOD_NAME%20AND%20hostname:dev%20AND%20NOT%20grpc.code:OK%20AND%20message:finished'%29%29%29&_g=%28refreshInterval:%28display:Off,pause:!f,value:0%29,time:%28from:now-1h,mode:quick,to:now%29%29) for unusual activity -- [ ] **Check for errors** in [Gitaly Dev Sentry](https://sentry.gitlap.com/gitlab/devgitlaborg-gitaly/?query=is%3Aunresolved+grpc.method%3A%2Fgitaly.GRPC_SERVICE_NAME%2FGRPC_METHOD_NAME) -- [ ] **Check for errors** in [GitLab Dev Sentry](https://sentry.gitlap.com/gitlab/devgitlaborg/?query=is%3Aunresolved+gitaly) - -#### Continue? - -- [ ] On unexpectedly high calls rates, error rates, CPU activity, etc, disable trial immediately with `!feature-set GITALY_FEATURE_NAME false` in [`#dev-gitlab`](https://gitlab.slack.com/messages/C6WQ87MU3) otherwise leave running and proceed proceed to next stage. - -## 3. Staging Trial - -#### Check Staging Server Versions -- [ ] Gitaly: [Gitaly Staging Version Tracker Dashboard](https://dashboards.gitlab.net/dashboard/db/gitaly-version-tracker?orgId=1&var-job=gitaly-staging) -- [ ] GitLab: https://staging.gitlab.com/help - -#### Enable on `staging.gitlab.com` -- [ ] `!feature-set GITALY_FEATURE_NAME true` in [`#development`](https://gitlab.slack.com/messages/C02PF508L/) - -Then leave running while monitoring for at least **15 minutes** while performing some testing through web, api or SSH. - -#### Monitor (at least every 5 minutes, preferably real-time) - -- [ ] **Monitor Grafana** feature dashboard on staging: [Gitaly Feature Status Dashboard](https://dashboards.gitlab.net/dashboard/db/gitaly-feature-status?from=now-12h&to=now&orgId=1&var-method=GRPC_METHOD_NAME&var-job=gitaly-nfs-staging&refresh=5m) -- [ ] **Inspect logs** in ELK: - - [GRPC_METHOD_NAME invocations, last hour](https://kibana.gprd.gitlab.com/app/kibana#/discover?_a=%28index%3A'gitaly-*'%2Cquery%3A%28query_string%3A%28query%3A'grpc.method:GRPC_METHOD_NAME%20AND%20hostname:nfs5'%29%29%29&_g=%28refreshInterval:%28display:Off,pause:!f,value:0%29,time:%28from:now-1h,mode:quick,to:now%29%29) for unusual activity - - [GRPC_METHOD_NAME errors, last hour](https://kibana.gprd.gitlab.com/app/kibana#/discover?_a=%28index%3A'gitaly-*'%2Cquery%3A%28query_string%3A%28query%3A'grpc.method:GRPC_METHOD_NAME%20AND%20hostname:nfs5%20AND%20NOT%20grpc.code:OK%20AND%20message:finished'%29%29%29&_g=%28refreshInterval:%28display:Off,pause:!f,value:0%29,time:%28from:now-1h,mode:quick,to:now%29%29) for unusual activity -- [ ] **Check for errors** in [Gitaly Staging Sentry](https://sentry.gitlap.com/gitlab/staginggitlabcom-gitaly/?query=is%3Aunresolved+grpc.method%3A%2Fgitaly.GRPC_SERVICE_NAME%2FGRPC_METHOD_NAME) -- [ ] **Check for errors** in [GitLab Staging Sentry](https://sentry.gitlap.com/gitlab/staginggitlabcom/?query=is%3Aunresolved+gitaly) - -#### Continue? - -- [ ] On unexpectedly high calls rates, error rates, CPU activity, etc, disable trial immediately using `!feature-set GITALY_FEATURE_NAME false` in [`#development`](https://gitlab.slack.com/messages/C02PF508L/) otherwise leave running and proceed to next stage. - -## 4. Production Server Version Check - -- [ ] Gitaly: [Gitaly Production Version Tracker Dashboard](https://dashboards.gitlab.net/dashboard/db/gitaly-version-tracker?orgId=1&var-job=gitaly-production) -- [ ] GitLab: https://gitlab.com/help - -## 5. Initial Impact Check - -- [ ] Create an issue in the infrastructure tracker: [Create issue now](https://gitlab.com/gitlab-com/infrastructure/issues/new?issue[title]=Testing%20of%20Gitaly%20Feature%20GITALY_FEATURE_NAME&issue[description]=https%3A%2F%2Fgitlab.com%2Fgitlab-org%2Fgitaly%2Fissues%2FACCEPTANCE_TEST_ISSUE_NUMBER%0A%0A%2Flabel%20~gitaly%20~change) -- [ ] Set Gitaly to 1% using the command `/chatops run feature set GITALY_FEATURE_NAME 1` in [`#production`](https://gitlab.slack.com/messages/C101F3796/) - -Then leave running while monitoring for at least **15 minutes** while performing some testing through web, api or SSH. - -#### Monitor (at least every 5 minutes, preferably real-time) -- [ ] **Monitor Grafana** feature dashboard on production: [Gitaly Feature Status Dashboard](https://dashboards.gitlab.net/dashboard/db/gitaly-feature-status?from=now-12h&to=now&orgId=1&var-method=GRPC_METHOD_NAME&var-job=gitaly-production&refresh=5m) -- [ ] **Inspect logs** in ELK: - - [GRPC_METHOD_NAME invocations, last hour](https://kibana.gprd.gitlab.com/app/kibana#/discover?_a=%28index%3A'gitaly-*'%2Cquery%3A%28query_string%3A%28query%3A'grpc.method:GRPC_METHOD_NAME%20AND%20NOT%20hostname:dev'%29%29%29&_g=%28refreshInterval:%28display:Off,pause:!f,value:0%29,time:%28from:now-1h,mode:quick,to:now%29%29) for unusual activity - - [GRPC_METHOD_NAME errors, last hour](https://kibana.gprd.gitlab.com/app/kibana#/discover?_a=%28index%3A'gitaly-*'%2Cquery%3A%28query_string%3A%28query%3A'grpc.method:GRPC_METHOD_NAME%20AND%20NOT%20hostname:dev%20AND%20NOT%20grpc.code:OK%20AND%20message:finished'%29%29%29&_g=%28refreshInterval:%28display:Off,pause:!f,value:0%29,time:%28from:now-1h,mode:quick,to:now%29%29) for unusual activity -- [ ] **Check for errors** in [Gitaly Sentry](https://sentry.gitlap.com/gitlab/gitaly-production/?query=is%3Aunresolved+grpc.method%3A%2Fgitaly.GRPC_SERVICE_NAME%2FGRPC_METHOD_NAME) -- [ ] **Check for errors** in [GitLab Sentry](https://sentry.gitlap.com/gitlab/gitlabcom/?query=is%3Aunresolved+gitaly) - -#### Continue? - -- [ ] On unexpectedly high calls rates, error rates, CPU activity, etc, disable trial immediately with `!feature-set GITALY_FEATURE_NAME false` in [`#production`](https://gitlab.slack.com/messages/C101F3796/) otherwise leave running and proceed to next stage. - -## 6. Low Impact Trial - -- [ ] Set Gitaly to 5% using the command `/chatops run feature set GITALY_FEATURE_NAME 5` in [`#production`](https://gitlab.slack.com/messages/C101F3796/) - -Then leave running while monitoring for at least **2 hours**. - -#### Monitor (at least every 20 minutes) -- [ ] **Monitor Grafana** feature dashboard on production: [Gitaly Feature Status Dashboard](https://dashboards.gitlab.net/dashboard/db/gitaly-feature-status?from=now-12h&to=now&orgId=1&var-method=GRPC_METHOD_NAME&var-job=gitaly-production&refresh=5m) -- [ ] **Inspect logs** in ELK: - - [GRPC_METHOD_NAME invocations, last 2 hours](https://kibana.gprd.gitlab.com/app/kibana#/discover?_a=%28index%3A'gitaly-*'%2Cquery%3A%28query_string%3A%28query%3A'grpc.method:GRPC_METHOD_NAME%20AND%20NOT%20hostname:dev'%29%29%29&_g=%28refreshInterval:%28display:Off,pause:!f,value:0%29,time:%28from:now-2h,mode:quick,to:now%29%29) for unusual activity - - [GRPC_METHOD_NAME errors, last 2 hours](https://kibana.gprd.gitlab.com/app/kibana#/discover?_a=%28index%3A'gitaly-*'%2Cquery%3A%28query_string%3A%28query%3A'grpc.method:GRPC_METHOD_NAME%20AND%20NOT%20hostname:dev%20AND%20NOT%20grpc.code:OK%20AND%20message:finished'%29%29%29&_g=%28refreshInterval:%28display:Off,pause:!f,value:0%29,time:%28from:now-2h,mode:quick,to:now%29%29) for unusual activity -- [ ] **Check for errors** in [Gitaly Sentry](https://sentry.gitlap.com/gitlab/gitaly-production/?query=is%3Aunresolved+grpc.method%3A%2Fgitaly.GRPC_SERVICE_NAME%2FGRPC_METHOD_NAME) -- [ ] **Check for errors** in [GitLab Sentry](https://sentry.gitlap.com/gitlab/gitlabcom/?query=is%3Aunresolved+gitaly) - -#### Continue? - -- [ ] On unexpectedly high calls rates, error rates, CPU activity, etc, disable trial immediately with `!feature-set GITALY_FEATURE_NAME false` in [`#production`](https://gitlab.slack.com/messages/C101F3796/) otherwise leave running and proceed to next stage. - -## 7. Mid Impact Trial - -- [ ] Set Gitaly to 50% using the command `/chatops run feature set GITALY_FEATURE_NAME 50` in [`#production`](https://gitlab.slack.com/messages/C101F3796/) - -Then leave running while monitoring for at least **24 hours**. - -#### Monitor (at least every few hours) -- [ ] **Monitor Grafana** feature dashboard on production: [Gitaly Feature Status Dashboard](https://dashboards.gitlab.net/dashboard/db/gitaly-feature-status?from=now-12h&to=now&orgId=1&var-method=GRPC_METHOD_NAME&var-job=gitaly-production&refresh=5m) -- [ ] **Inspect logs** in ELK: - - [GRPC_METHOD_NAME invocations, last 24 hours](https://kibana.gprd.gitlab.com/app/kibana#/discover?_a=%28index%3A'gitaly-*'%2Cquery%3A%28query_string%3A%28query%3A'grpc.method:GRPC_METHOD_NAME%20AND%20NOT%20hostname:dev'%29%29%29&_g=%28refreshInterval:%28display:Off,pause:!f,value:0%29,time:%28from:now-24h,mode:quick,to:now%29%29) for unusual activity - - [GRPC_METHOD_NAME errors, last 24 hours](https://kibana.gprd.gitlab.com/app/kibana#/discover?_a=%28index%3A'gitaly-*'%2Cquery%3A%28query_string%3A%28query%3A'grpc.method:GRPC_METHOD_NAME%20AND%20NOT%20hostname:dev%20AND%20NOT%20grpc.code:OK%20AND%20message:finished'%29%29%29&_g=%28refreshInterval:%28display:Off,pause:!f,value:0%29,time:%28from:now-24h,mode:quick,to:now%29%29) for unusual activity -- [ ] **Check for errors** in [Gitaly Sentry](https://sentry.gitlap.com/gitlab/gitaly-production/?query=is%3Aunresolved+grpc.method%3A%2Fgitaly.GRPC_SERVICE_NAME%2FGRPC_METHOD_NAME) -- [ ] **Check for errors** in [GitLab Sentry](https://sentry.gitlap.com/gitlab/gitlabcom/?query=is%3Aunresolved+gitaly) - -#### Continue? - -- [ ] On unexpectedly high calls rates, error rates, CPU activity, etc, disable trial immediately with `!feature-set GITALY_FEATURE_NAME false` in [`#production`](https://gitlab.slack.com/messages/C101F3796/) otherwise leave running and proceed to next stage. - -## 8. Full Impact Trial - -- [ ] Set Gitaly to 100% using the command `/chatops run feature set GITALY_FEATURE_NAME 100` in [`#production`](https://gitlab.slack.com/messages/C101F3796/) - -Then leave running while monitoring for at least **1 week**. - -#### Monitor (at least every day) -- [ ] **Monitor Grafana** feature dashboard on production: [Gitaly Feature Status Dashboard](https://dashboards.gitlab.net/dashboard/db/gitaly-feature-status?from=now-12h&to=now&orgId=1&var-method=GRPC_METHOD_NAME&var-job=gitaly-production&refresh=5m) -- [ ] **Inspect logs** in ELK: - - [GRPC_METHOD_NAME invocations, last 7 days](https://kibana.gprd.gitlab.com/app/kibana#/discover?_a=%28index%3A'gitaly-*'%2Cquery%3A%28query_string%3A%28query%3A'grpc.method:GRPC_METHOD_NAME%20AND%20NOT%20hostname:dev'%29%29%29&_g=%28refreshInterval:%28display:Off,pause:!f,value:0%29,time:%28from:now-7d,mode:quick,to:now%29%29) for unusual activity - - [GRPC_METHOD_NAME errors, last 7 days](https://kibana.gprd.gitlab.com/app/kibana#/discover?_a=%28index%3A'gitaly-*'%2Cquery%3A%28query_string%3A%28query%3A'grpc.method:GRPC_METHOD_NAME%20AND%20NOT%20hostname:dev%20AND%20NOT%20grpc.code:OK%20AND%20message:finished'%29%29%29&_g=%28refreshInterval:%28display:Off,pause:!f,value:0%29,time:%28from:now-7d,mode:quick,to:now%29%29) for unusual activity -- [ ] **Check for errors** in [Gitaly Sentry](https://sentry.gitlap.com/gitlab/gitaly-production/?query=is%3Aunresolved+grpc.method%3A%2Fgitaly.GRPC_SERVICE_NAME%2FGRPC_METHOD_NAME) -- [ ] **Check for errors** in [GitLab Sentry](https://sentry.gitlap.com/gitlab/gitlabcom/?query=is%3Aunresolved+gitaly) - -#### Success? - -- [ ] Close this issue and mark the ~Conversation as ~"Migration:Opt-In" - -/label ~"Acceptance Testing" -/label ~Gitaly diff --git a/.gitlab/issue_templates/Migration_Analysis.md b/.gitlab/issue_templates/Migration_Analysis.md deleted file mode 100644 index 83c5e817d..000000000 --- a/.gitlab/issue_templates/Migration_Analysis.md +++ /dev/null @@ -1,20 +0,0 @@ -~Conversation: TBD - -## Perform a Migration Analysis - -- **Client**: `GitLab-CE`/`Workhorse`/`GitLab-Shell` (choose one) -- **Route**: - -## Expected Artefacts - -See the [Migration Process documentation](https://gitlab.com/gitlab-org/gitaly/blob/master/doc/MIGRATION_PROCESS.md#migration-analysis-migration-analysis) -for more information on the analysis stage of the process. - -- [ ] **Decision to move ahead with migration**. Is it worth the effort right now? -- [ ] **Existing reusable RPC endpoints**. What have we already implemented? -- [ ] **New RPC endpoints to be implemented**. Just names. Leave the full design to the ~"RPC Design" stage next. -- [ ] **Effort - for each new and existing RPC endpoint**, roughly (small/medium/large) how much effort will be required to implement it? - - -/label ~"Migration Analysis" -/label ~Gitaly diff --git a/.gitlab/issue_templates/N+1_Query.md b/.gitlab/issue_templates/N+1_Query.md deleted file mode 100644 index faa63faf5..000000000 --- a/.gitlab/issue_templates/N+1_Query.md +++ /dev/null @@ -1,36 +0,0 @@ -Corresponding gitlab-rails issue: LINK - ------------------------------------------------------------- - -**Stages**: - -- [ ] Investigate - -- [ ] Assess priority - -- [ ] Server-side fixed LINK - -- [ ] Client-side fixed LINK - -**Affected RPC's**: - - `Endpoint::Name` - ------------------------------------------------------------- - -Process explanation: - -### Investigate - -If it's not clear what RPC's add up to the N+1 violation, do a new CI run on gitlab-ce/ee to find out. - -### Assess priority - -- Does this N+1 degrade the user experience? -- Does it cause more than 100 (extra) requests per second on gitlab.com? - -If the answer to both questions is 'no' then downgrade the priority of this issue to `v1.1`. - ------------------------------------------------------------- - -/label ~"v1.0" -/label ~Gitaly diff --git a/.gitlab/issue_templates/Potential_Endpoint.md b/.gitlab/issue_templates/Potential_Endpoint.md deleted file mode 100644 index bfc8f1a12..000000000 --- a/.gitlab/issue_templates/Potential_Endpoint.md +++ /dev/null @@ -1,12 +0,0 @@ ------- - -- Ruby method: `FoobarService#transmogrify` **replace fake value** -- Filename: `app/services/foobar_service.rb` **replace fake value** -- GitLab-EE permalink **LINK** - -Conversation (if applicable): [Create Issue](https://gitlab.com/gitlab-org/gitaly/issues/new?issuable_template=Conversation_Migration) - ------- - -/label ~"Potential Endpoint" -/label ~Gitaly -- cgit v1.2.3