From 12b29b5ed6d50683fb760a8ca229001a532096f7 Mon Sep 17 00:00:00 2001 From: Will Chandler Date: Tue, 14 Feb 2023 10:11:52 -0500 Subject: Dangerfile: add some debugging prints Don't merge me --- danger/rules/changes_size/Dangerfile | 19 ++++++++++++++++++- 1 file changed, 18 insertions(+), 1 deletion(-) diff --git a/danger/rules/changes_size/Dangerfile b/danger/rules/changes_size/Dangerfile index fc3b6f118..5986c4e58 100644 --- a/danger/rules/changes_size/Dangerfile +++ b/danger/rules/changes_size/Dangerfile @@ -2,7 +2,10 @@ thresholds = helper.config.code_size_thresholds -lines_changed = (git.added_files + git.modified_files).sum do |file| +old_names = git.renamed_files.map {|f| f[:before] } +new_names = git.renamed_files.map {|f| f[:after] } + +lines_changed = (git.added_files + git.modified_files + new_names - old_names).uniq.sum do |file| next 0 if file.end_with?('.pb.go') || file.end_with?('_pb.rb') info = git.info_for_file(file) @@ -12,6 +15,20 @@ lines_changed = (git.added_files + git.modified_files).sum do |file| info[:insertions] end +puts "new total: #{lines_changed}" + +old_lines_changed = (git.added_files + git.modified_files).sum do |file| + next 0 if file.end_with?('.pb.go') || file.end_with?('_pb.rb') || git.diff.stats[:files][file].nil? + + info = git.info_for_file(file) + + next 0 if info.nil? + + info[:insertions] +end + +puts "old total: #{old_lines_changed}" + if lines_changed > thresholds[:high] warn "This merge request is definitely too big (#{lines_changed} lines changed), please split it into multiple merge requests." elsif lines_changed > thresholds[:medium] -- cgit v1.2.3