From ba1e9d756fd2f9180a0968182303d73c03f3c6b5 Mon Sep 17 00:00:00 2001 From: Pavlo Strokov Date: Fri, 17 Sep 2021 13:25:16 +0300 Subject: lint: Remove SA1019 exclude rules As there are no more deprecated usages we can remove exclusion rule for the SA1019 error. Part of: https://gitlab.com/gitlab-org/gitaly/-/issues/1628 --- internal/gitaly/service/operations/rebase.go | 2 -- internal/gitaly/service/operations/rebase_test.go | 2 -- internal/praefect/grpc-proxy/proxy/examples_test.go | 4 ---- internal/praefect/grpc-proxy/proxy/handler.go | 4 ---- 4 files changed, 12 deletions(-) diff --git a/internal/gitaly/service/operations/rebase.go b/internal/gitaly/service/operations/rebase.go index 8d9ba5f42..9549a9a3a 100644 --- a/internal/gitaly/service/operations/rebase.go +++ b/internal/gitaly/service/operations/rebase.go @@ -1,7 +1,5 @@ package operations -//lint:file-ignore SA1019 due to planned removal in issue https://gitlab.com/gitlab-org/gitaly/issues/1628 - import ( "errors" "fmt" diff --git a/internal/gitaly/service/operations/rebase_test.go b/internal/gitaly/service/operations/rebase_test.go index aca107a66..9468cbd6d 100644 --- a/internal/gitaly/service/operations/rebase_test.go +++ b/internal/gitaly/service/operations/rebase_test.go @@ -1,7 +1,5 @@ package operations -//lint:file-ignore SA1019 due to planned removal in issue https://gitlab.com/gitlab-org/gitaly/issues/1628 - import ( "context" "fmt" diff --git a/internal/praefect/grpc-proxy/proxy/examples_test.go b/internal/praefect/grpc-proxy/proxy/examples_test.go index 06b4a6c99..a8747f5c0 100644 --- a/internal/praefect/grpc-proxy/proxy/examples_test.go +++ b/internal/praefect/grpc-proxy/proxy/examples_test.go @@ -1,10 +1,6 @@ // Copyright 2017 Michal Witkowski. All Rights Reserved. // See LICENSE for licensing terms. -// TODO: remove the following linter override when the deprecations are fixed -// in issue https://gitlab.com/gitlab-org/gitaly/issues/1663 -//lint:file-ignore SA1019 Ignore all gRPC deprecations until issue #1663 - package proxy_test import ( diff --git a/internal/praefect/grpc-proxy/proxy/handler.go b/internal/praefect/grpc-proxy/proxy/handler.go index ea8d790ec..58fcdc828 100644 --- a/internal/praefect/grpc-proxy/proxy/handler.go +++ b/internal/praefect/grpc-proxy/proxy/handler.go @@ -1,10 +1,6 @@ // Copyright 2017 Michal Witkowski. All Rights Reserved. // See LICENSE for licensing terms. -// TODO: remove the following linter override when the deprecations are fixed -// in issue https://gitlab.com/gitlab-org/gitaly/issues/1663 -//lint:file-ignore SA1019 Ignore all gRPC deprecations until issue #1663 - package proxy import ( -- cgit v1.2.3