1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
|
package main
import (
"bytes"
"fmt"
"os"
"path/filepath"
"testing"
"github.com/golang/protobuf/jsonpb"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/git"
"gitlab.com/gitlab-org/gitaly/internal/git/updateref"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
)
const keepAroundNamespace = "refs/keep-around"
func TestVisibilityOfHiddenRefs(t *testing.T) {
ctx, cancel := testhelper.Context()
defer cancel()
cfg, repo, repoPath := testcfg.BuildWithRepo(t)
testhelper.ConfigureGitalySSHBin(t, cfg)
testhelper.ConfigureGitalyHooksBin(t, cfg)
socketPath := testhelper.GetTemporaryGitalySocketFileName(t)
_, clean := runServer(t, false, cfg, "unix", socketPath)
defer clean()
_, clean = runServer(t, false, cfg, "unix", cfg.GitalyInternalSocketPath())
defer clean()
// Create a keep-around ref
existingSha := "1e292f8fedd741b75372e19097c76d327140c312"
keepAroundRef := fmt.Sprintf("%s/%s", keepAroundNamespace, existingSha)
gitCmdFactory := git.NewExecCommandFactory(cfg)
updater, err := updateref.New(ctx, cfg, gitCmdFactory, repo)
require.NoError(t, err)
require.NoError(t, updater.Create(git.ReferenceName(keepAroundRef), existingSha))
require.NoError(t, updater.Wait())
testhelper.MustRunCommand(t, nil, "git", "-C", repoPath, "config", "transfer.hideRefs", keepAroundNamespace)
output := testhelper.MustRunCommand(t, nil, "git", "ls-remote", repoPath, keepAroundNamespace)
require.Empty(t, output, "there should be no keep-around refs in normal ls-remote output")
wd, err := os.Getwd()
require.NoError(t, err)
tests := []struct {
name string
GitConfigOptions []string
HiddenRefFound bool
}{
{
name: "With no custom GitConfigOptions passed",
GitConfigOptions: []string{},
HiddenRefFound: true,
},
{
name: "With custom GitConfigOptions passed",
GitConfigOptions: []string{fmt.Sprintf("transfer.hideRefs=%s", keepAroundRef)},
HiddenRefFound: false,
},
}
for _, test := range tests {
t.Run(test.name, func(t *testing.T) {
pbMarshaler := &jsonpb.Marshaler{}
payload, err := pbMarshaler.MarshalToString(&gitalypb.SSHUploadPackRequest{
Repository: repo,
GitConfigOptions: test.GitConfigOptions,
})
require.NoError(t, err)
env := []string{
fmt.Sprintf("GITALY_PAYLOAD=%s", payload),
fmt.Sprintf("GITALY_ADDRESS=unix:%s", socketPath),
fmt.Sprintf("GITALY_WD=%s", wd),
fmt.Sprintf("PATH=.:%s", os.Getenv("PATH")),
fmt.Sprintf("GIT_SSH_COMMAND=%s upload-pack", filepath.Join(cfg.BinDir, "gitaly-ssh")),
}
stdout := &bytes.Buffer{}
cmd, err := gitCmdFactory.NewWithoutRepo(ctx, git.SubCmd{
Name: "ls-remote",
Args: []string{
fmt.Sprintf("%s:%s", "git@localhost", repoPath),
keepAroundRef,
},
}, git.WithEnv(env...), git.WithStdout(stdout))
require.NoError(t, err)
err = cmd.Wait()
require.NoError(t, err)
if test.HiddenRefFound {
require.Equal(t, fmt.Sprintf("%s\t%s\n", existingSha, keepAroundRef), stdout.String())
} else {
require.NotEqual(t, fmt.Sprintf("%s\t%s\n", existingSha, keepAroundRef), stdout.String())
}
})
}
}
|
