1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
|
package main
import (
"bytes"
"testing"
"github.com/olekukonko/tablewriter"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v15/internal/praefect/config"
)
func TestListStorages_FlagSet(t *testing.T) {
t.Parallel()
cmd := &listStorages{}
fs := cmd.FlagSet()
require.NoError(t, fs.Parse([]string{"--virtual-storage", "vs"}))
require.Equal(t, "vs", cmd.virtualStorage)
}
func TestListStorages_Exec(t *testing.T) {
t.Parallel()
testCases := []struct {
desc string
virtualStorages []*config.VirtualStorage
args []string
expectedOutput func(*tablewriter.Table)
}{
{
desc: "one virtual storage",
virtualStorages: []*config.VirtualStorage{
{
Name: "vs-1",
Nodes: []*config.Node{
{
Storage: "storage-1",
Address: "tcp://1.2.3.4",
},
{
Storage: "storage-2",
Address: "tcp://4.3.2.1",
},
},
},
},
args: []string{},
expectedOutput: func(t *tablewriter.Table) {
t.Append([]string{"vs-1", "storage-1", "tcp://1.2.3.4"})
t.Append([]string{"vs-1", "storage-2", "tcp://4.3.2.1"})
},
},
{
desc: "multiple virtual storages but only show one",
virtualStorages: []*config.VirtualStorage{
{
Name: "vs-1",
Nodes: []*config.Node{
{
Storage: "storage-1",
Address: "tcp://1.2.3.4",
},
{
Storage: "storage-2",
Address: "tcp://4.3.2.1",
},
},
},
{
Name: "vs-2",
Nodes: []*config.Node{
{
Storage: "storage-3",
Address: "tcp://1.1.3.4",
},
{
Storage: "storage-4",
Address: "tcp://1.3.2.1",
},
},
},
{
Name: "vs-3",
Nodes: []*config.Node{
{
Storage: "storage-5",
Address: "tcp://2.1.3.4",
},
{
Storage: "storage-6",
Address: "tcp://2.3.2.1",
},
},
},
},
args: []string{"-virtual-storage", "vs-2"},
expectedOutput: func(t *tablewriter.Table) {
t.Append([]string{"vs-2", "storage-3", "tcp://1.1.3.4"})
t.Append([]string{"vs-2", "storage-4", "tcp://1.3.2.1"})
},
},
{
desc: "one virtual storage with virtual storage arg",
virtualStorages: []*config.VirtualStorage{
{
Name: "vs-1",
Nodes: []*config.Node{
{
Storage: "storage-1",
Address: "tcp://1.2.3.4",
},
{
Storage: "storage-2",
Address: "tcp://4.3.2.1",
},
},
},
},
args: []string{"-virtual-storage", "vs-1"},
expectedOutput: func(t *tablewriter.Table) {
t.Append([]string{"vs-1", "storage-1", "tcp://1.2.3.4"})
t.Append([]string{"vs-1", "storage-2", "tcp://4.3.2.1"})
},
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
var expectedOutput bytes.Buffer
table := tablewriter.NewWriter(&expectedOutput)
table.SetHeader([]string{"VIRTUAL_STORAGE", "NODE", "ADDRESS"})
table.SetHeaderAlignment(tablewriter.ALIGN_LEFT)
table.SetAutoFormatHeaders(false)
table.SetAlignment(tablewriter.ALIGN_LEFT)
table.SetCenterSeparator("")
table.SetColumnSeparator("")
table.SetRowSeparator("")
table.SetHeaderLine(false)
table.SetBorder(false)
table.SetTablePadding("\t") // pad with tabs
table.SetNoWhiteSpace(true)
tc.expectedOutput(table)
table.Render()
var out bytes.Buffer
cmd := &listStorages{
w: &out,
}
fs := cmd.FlagSet()
require.NoError(t, fs.Parse(tc.args))
require.NoError(t, cmd.Exec(fs, config.Config{
VirtualStorages: tc.virtualStorages,
}))
assert.Equal(t, expectedOutput.String(), out.String())
})
}
t.Run("virtual storage arg matches no virtual storages", func(t *testing.T) {
var out bytes.Buffer
cmd := &listStorages{
w: &out,
}
fs := cmd.FlagSet()
require.NoError(t, fs.Parse([]string{"-virtual-storage", "vs-2"}))
require.NoError(t, cmd.Exec(fs, config.Config{
VirtualStorages: []*config.VirtualStorage{
{
Name: "vs-1",
Nodes: []*config.Node{
{
Storage: "storage-1",
Address: "tcp://1.2.3.4",
},
{
Storage: "storage-2",
Address: "tcp://4.3.2.1",
},
},
},
},
}))
assert.Equal(t, "No virtual storages named vs-2.\n", out.String())
})
}
|
