1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
|
//go:build postgres
// +build postgres
package main
import (
"flag"
"fmt"
"path/filepath"
"testing"
"time"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/client"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/service/setup"
"gitlab.com/gitlab-org/gitaly/internal/praefect/config"
"gitlab.com/gitlab-org/gitaly/internal/praefect/datastore"
"gitlab.com/gitlab-org/gitaly/internal/praefect/datastore/glsql"
"gitlab.com/gitlab-org/gitaly/internal/praefect/nodes"
"gitlab.com/gitlab-org/gitaly/internal/praefect/protoregistry"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/promtest"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testserver"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
)
func TestTrackRepository_FlagSet(t *testing.T) {
cmd := &trackRepository{}
fs := cmd.FlagSet()
require.NoError(t, fs.Parse([]string{"--virtual-storage", "vs", "--repository", "repo", "--authoritative-storage", "storage-0"}))
require.Equal(t, "vs", cmd.virtualStorage)
require.Equal(t, "repo", cmd.relativePath)
require.Equal(t, "storage-0", cmd.authoritativeStorage)
}
func TestTrackRepository_Exec_invalidArgs(t *testing.T) {
t.Run("not all flag values processed", func(t *testing.T) {
cmd := trackRepository{}
flagSet := flag.NewFlagSet("cmd", flag.PanicOnError)
require.NoError(t, flagSet.Parse([]string{"stub"}))
err := cmd.Exec(flagSet, config.Config{})
require.EqualError(t, err, "cmd doesn't accept positional arguments")
})
t.Run("virtual-storage is not set", func(t *testing.T) {
cmd := trackRepository{}
err := cmd.Exec(flag.NewFlagSet("", flag.PanicOnError), config.Config{})
require.EqualError(t, err, `"virtual-storage" is a required parameter`)
})
t.Run("repository is not set", func(t *testing.T) {
cmd := trackRepository{virtualStorage: "stub"}
err := cmd.Exec(flag.NewFlagSet("", flag.PanicOnError), config.Config{})
require.EqualError(t, err, `"repository" is a required parameter`)
})
t.Run("authoritative-storage is not set", func(t *testing.T) {
cmd := trackRepository{virtualStorage: "stub", relativePath: "path/to/repo"}
err := cmd.Exec(flag.NewFlagSet("", flag.PanicOnError), config.Config{Failover: config.Failover{ElectionStrategy: config.ElectionStrategyPerRepository}})
require.EqualError(t, err, `"authoritative-storage" is a required parameter`)
})
t.Run("db connection error", func(t *testing.T) {
cmd := trackRepository{virtualStorage: "stub", relativePath: "stub", authoritativeStorage: "storage-0"}
cfg := config.Config{DB: config.DB{Host: "stub", SSLMode: "disable"}}
err := cmd.Exec(flag.NewFlagSet("", flag.PanicOnError), cfg)
require.Error(t, err)
require.Contains(t, err.Error(), "connect to database: dial tcp: lookup stub")
})
}
func TestTrackRepository_Exec(t *testing.T) {
g1Cfg := testcfg.Build(t, testcfg.WithStorages("gitaly-1"))
g2Cfg := testcfg.Build(t, testcfg.WithStorages("gitaly-2"))
g1Srv := testserver.StartGitalyServer(t, g1Cfg, nil, setup.RegisterAll, testserver.WithDisablePraefect())
g2Srv := testserver.StartGitalyServer(t, g2Cfg, nil, setup.RegisterAll, testserver.WithDisablePraefect())
defer g2Srv.Shutdown()
defer g1Srv.Shutdown()
g1Addr := g1Srv.Address()
db := getDB(t)
var database string
require.NoError(t, db.QueryRow(`SELECT current_database()`).Scan(&database))
dbConf := glsql.GetDBConfig(t, database)
virtualStorageName := "praefect"
conf := config.Config{
SocketPath: testhelper.GetTemporaryGitalySocketFileName(t),
VirtualStorages: []*config.VirtualStorage{
{
Name: virtualStorageName,
Nodes: []*config.Node{
{Storage: g1Cfg.Storages[0].Name, Address: g1Addr},
{Storage: g2Cfg.Storages[0].Name, Address: g2Srv.Address()},
},
DefaultReplicationFactor: 2,
},
},
DB: dbConf,
}
gitalyCC, err := client.Dial(g1Addr, nil)
require.NoError(t, err)
defer func() { require.NoError(t, gitalyCC.Close()) }()
ctx, cancel := testhelper.Context()
defer cancel()
gitaly1RepositoryClient := gitalypb.NewRepositoryServiceClient(gitalyCC)
createRepoThroughGitaly1 := func(relativePath string) error {
_, err := gitaly1RepositoryClient.CreateRepository(
ctx,
&gitalypb.CreateRepositoryRequest{
Repository: &gitalypb.Repository{
StorageName: g1Cfg.Storages[0].Name,
RelativePath: relativePath,
},
})
return err
}
testCases := map[string]struct {
failoverConfig config.Failover
authoritativeStorage string
}{
"sql election": {
failoverConfig: config.Failover{
Enabled: true,
ElectionStrategy: config.ElectionStrategySQL,
},
authoritativeStorage: "",
},
"per repository election": {
failoverConfig: config.Failover{
Enabled: true,
ElectionStrategy: config.ElectionStrategyPerRepository,
},
authoritativeStorage: g1Cfg.Storages[0].Name,
},
}
logger := testhelper.NewTestLogger(t)
for tn, tc := range testCases {
t.Run(tn, func(t *testing.T) {
addCmdConf := conf
addCmdConf.Failover = tc.failoverConfig
t.Run("ok", func(t *testing.T) {
nodeMgr, err := nodes.NewManager(testhelper.DiscardTestEntry(t), addCmdConf, db.DB, nil, promtest.NewMockHistogramVec(), protoregistry.GitalyProtoPreregistered, nil, nil)
require.NoError(t, err)
nodeMgr.Start(0, time.Hour)
relativePath := fmt.Sprintf("path/to/test/repo_%s", tn)
repoDS := datastore.NewPostgresRepositoryStore(db, conf.StorageNames())
require.NoError(t, createRepoThroughGitaly1(relativePath))
rmRepoCmd := &removeRepository{
logger: logger,
virtualStorage: virtualStorageName,
relativePath: relativePath,
}
require.NoError(t, rmRepoCmd.Exec(flag.NewFlagSet("", flag.PanicOnError), conf))
// create the repo on Gitaly without Praefect knowing
require.NoError(t, createRepoThroughGitaly1(relativePath))
require.DirExists(t, filepath.Join(g1Cfg.Storages[0].Path, relativePath))
require.NoDirExists(t, filepath.Join(g2Cfg.Storages[0].Path, relativePath))
addRepoCmd := &trackRepository{
logger: logger,
virtualStorage: virtualStorageName,
relativePath: relativePath,
authoritativeStorage: tc.authoritativeStorage,
}
require.NoError(t, addRepoCmd.Exec(flag.NewFlagSet("", flag.PanicOnError), addCmdConf))
as := datastore.NewAssignmentStore(db, conf.StorageNames())
assignments, err := as.GetHostAssignments(ctx, virtualStorageName, relativePath)
require.NoError(t, err)
require.Len(t, assignments, 2)
assert.Contains(t, assignments, g1Cfg.Storages[0].Name)
assert.Contains(t, assignments, g2Cfg.Storages[0].Name)
exists, err := repoDS.RepositoryExists(ctx, virtualStorageName, relativePath)
require.NoError(t, err)
assert.True(t, exists)
})
t.Run("repository does not exist", func(t *testing.T) {
relativePath := fmt.Sprintf("path/to/test/repo_1_%s", tn)
cmd := &trackRepository{
logger: testhelper.NewTestLogger(t),
virtualStorage: "praefect",
relativePath: relativePath,
authoritativeStorage: tc.authoritativeStorage,
}
assert.EqualError(t, cmd.Exec(flag.NewFlagSet("", flag.PanicOnError), addCmdConf), errAuthoritativeRepositoryNotExist.Error())
})
t.Run("records already exist", func(t *testing.T) {
relativePath := fmt.Sprintf("path/to/test/repo_2_%s", tn)
require.NoError(t, createRepoThroughGitaly1(relativePath))
require.DirExists(t, filepath.Join(g1Cfg.Storages[0].Path, relativePath))
require.NoDirExists(t, filepath.Join(g2Cfg.Storages[0].Path, relativePath))
ds := datastore.NewPostgresRepositoryStore(db, conf.StorageNames())
require.NoError(t, err)
require.NoError(t, ds.CreateRepository(ctx, virtualStorageName, relativePath, g1Cfg.Storages[0].Name, nil, nil, true, true))
cmd := &trackRepository{
logger: testhelper.NewTestLogger(t),
virtualStorage: virtualStorageName,
relativePath: relativePath,
authoritativeStorage: tc.authoritativeStorage,
}
assert.NoError(t, cmd.Exec(flag.NewFlagSet("", flag.PanicOnError), addCmdConf))
})
})
}
}
|
