1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
|
package dnsresolver
import (
"fmt"
"net"
"testing"
"github.com/miekg/dns"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v16/internal/structerr"
"gitlab.com/gitlab-org/gitaly/v16/internal/testhelper"
)
func TestFindDNSLookup_default(t *testing.T) {
t.Parallel()
resolver, err := findDNSLookup("")
require.NoError(t, err)
require.Equal(t, net.DefaultResolver, resolver)
}
func TestFindDNSLookup_invalidAuthority(t *testing.T) {
t.Parallel()
resolver, err := findDNSLookup("this:is:not:good")
require.ErrorIs(t, structerr.New("dns resolver: %w", &net.AddrError{
Err: "too many colons in address",
Addr: "this:is:not:good:53",
}), err)
require.Nil(t, resolver)
}
func TestFindDNSLookup_validAuthority(t *testing.T) {
t.Parallel()
fakeServer := testhelper.NewFakeDNSServer(t).WithHandler(dns.TypeA, func(host string) []string {
if host == "grpc.test." {
return []string{"1.2.3.4"}
}
return nil
}).Start()
resolver, err := findDNSLookup(fakeServer.Addr())
require.NoError(t, err)
addrs, err := resolver.LookupHost(testhelper.Context(t), "grpc.test")
require.NoError(t, err)
require.Equal(t, []string{"1.2.3.4"}, addrs)
}
func TestValidateTarget(t *testing.T) {
t.Parallel()
tests := []struct {
target string
expectedErr error
}{
{target: "dns:google.com"},
{target: "dns:///google.com"},
{target: "dns://1.1.1.1/google.com"},
{target: "dns:google.com:50051"},
{target: "dns:///google.com:50051"},
{target: "dns://1.1.1.1:53/google.com:50051"},
{target: "dns:[2001:0db8:85a3:0000:0000:8a2e:0370:7334]"},
{target: "dns:///[2001:0db8:85a3:0000:0000:8a2e:0370:7334]"},
{target: "dns://1.1.1.1:53/[2001:0db8:85a3:0000:0000:8a2e:0370:7334]"},
{target: "dns:[2001:0db8:85a3:0000:0000:8a2e:0370:7334]:50051"},
{target: "dns:///[2001:0db8:85a3:0000:0000:8a2e:0370:7334]:50051"},
{target: "dns://1.1.1.1:53/[2001:0db8:85a3:0000:0000:8a2e:0370:7334]:50051"},
{target: "dns:[fe80::1ff:fe23:4567:890a]:50051"},
{target: "dns:///[fe80::1ff:fe23:4567:890a]:50051"},
{target: "dns://1.1.1.1:53/[fe80::1ff:fe23:4567:890a]:50051"},
{
target: "dns:[fe80::1ff:fe23:4567:890a]:",
expectedErr: structerr.New("dns resolver: missing port after port-separator colon"),
},
{
target: "tcp://[fe80::1ff:fe23:4567:890a]",
expectedErr: structerr.New("unexpected scheme: tcp"),
},
{
target: "",
expectedErr: structerr.New("empty address"),
},
}
for _, tc := range tests {
t.Run(fmt.Sprintf("target: %s", tc.target), func(t *testing.T) {
require.Equal(t, tc.expectedErr, ValidateURL(tc.target))
})
}
}
func TestParseTarget(t *testing.T) {
t.Parallel()
defaultPort := "443"
tests := []struct {
target string
expectedHost string
expectedPort string
expectedErr error
}{
{
target: "www.google.com",
expectedHost: "www.google.com",
expectedPort: "443",
},
{
target: "google.com:50051",
expectedHost: "google.com",
expectedPort: "50051",
},
{
target: "1.2.3.4",
expectedHost: "1.2.3.4",
expectedPort: "443",
},
{
target: "1.2.3.4:50051",
expectedHost: "1.2.3.4",
expectedPort: "50051",
},
{
target: "[2001:0db8:85a3:0000:0000:8a2e:0370:7334]",
expectedHost: "2001:0db8:85a3:0000:0000:8a2e:0370:7334",
expectedPort: "443",
},
{
target: "[fe80::1ff:fe23:4567:890a]:50051",
expectedHost: "fe80::1ff:fe23:4567:890a",
expectedPort: "50051",
},
{
target: "[fe80::1ff:fe23:4567:890a]:",
expectedErr: structerr.New("dns resolver: missing port after port-separator colon"),
},
{
target: ":50051",
expectedHost: "localhost",
expectedPort: "50051",
},
{
target: "",
expectedErr: structerr.New("dns resolver: missing address"),
},
{
target: "this:is:invalid:address",
expectedErr: structerr.New("dns resolver: %w", &net.AddrError{
Err: "too many colons in address",
Addr: "this:is:invalid:address:443",
}),
},
}
for _, tc := range tests {
t.Run(fmt.Sprintf("target: %s", tc.target), func(t *testing.T) {
host, port, err := parseTarget(tc.target, defaultPort)
require.Equal(t, tc.expectedErr, err)
require.Equal(t, tc.expectedHost, host)
require.Equal(t, tc.expectedPort, port)
})
}
}
func TestTryParseIP(t *testing.T) {
t.Parallel()
tests := []struct {
host string
port string
expectedAddr string
expectedOk bool
}{
{host: "google.com", port: "50051", expectedOk: false},
{host: "1.2.3", port: "50051", expectedOk: false},
{host: "1.2.3.4", port: "50051", expectedAddr: "1.2.3.4:50051", expectedOk: true},
{host: "64:ff9b::", port: "50051", expectedAddr: "[64:ff9b::]:50051", expectedOk: true},
{host: "2001:0db8:85a3:0000:0000:8a2e:0370:7334", port: "50051", expectedAddr: "[2001:0db8:85a3:0000:0000:8a2e:0370:7334]:50051", expectedOk: true},
}
for _, tc := range tests {
t.Run(fmt.Sprintf("host: %s, port: %s", tc.host, tc.port), func(t *testing.T) {
addr, ok := tryParseIP(tc.host, tc.port)
require.Equal(t, tc.expectedOk, ok)
require.Equal(t, tc.expectedAddr, addr)
})
}
}
|
