1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
|
package catfile
import (
"context"
"fmt"
"strings"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v15/internal/git"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v15/internal/helper"
"gitlab.com/gitlab-org/gitaly/v15/internal/metadata/featureflag"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v15/proto/go/gitalypb"
)
func TestGetTag(t *testing.T) {
t.Parallel()
testhelper.NewFeatureSets(featureflag.CatfileBatchCommand).Run(t, testGetTag)
}
func testGetTag(t *testing.T, ctx context.Context) {
cfg, objectReader, _, repoPath := setupObjectReader(t, ctx)
commitID := gittest.WriteCommit(t, cfg, repoPath)
for _, tc := range []struct {
tagName string
message string
}{
{
tagName: fmt.Sprintf("%s-v1.0.2", t.Name()),
message: strings.Repeat("a", helper.MaxCommitOrTagMessageSize+1) + "\n",
},
{
tagName: fmt.Sprintf("%s-v1.0.0", t.Name()),
message: "Prod Release v1.0.0\n",
},
{
tagName: fmt.Sprintf("%s-v1.0.1", t.Name()),
message: strings.Repeat("a", helper.MaxCommitOrTagMessageSize+1) + "\n",
},
} {
t.Run(tc.tagName, func(t *testing.T) {
tagID := gittest.WriteTag(t, cfg, repoPath, tc.tagName, commitID.Revision(), gittest.WriteTagConfig{Message: tc.message})
tag, err := GetTag(ctx, objectReader, git.Revision(tagID), tc.tagName)
require.NoError(t, err)
require.Equal(t, tc.message, string(tag.Message))
require.Equal(t, tc.tagName, string(tag.GetName()))
})
}
}
func TestTrimTag(t *testing.T) {
for _, tc := range []struct {
desc string
message string
expectedMessage string
expectedMessageSize int
}{
{
desc: "simple short message",
message: "foo",
expectedMessage: "foo",
expectedMessageSize: 3,
},
{
desc: "trailing newlines",
message: "foo\n\n",
expectedMessage: "foo",
expectedMessageSize: 3,
},
{
desc: "too long",
message: strings.Repeat("a", helper.MaxCommitOrTagMessageSize+1),
expectedMessage: strings.Repeat("a", helper.MaxCommitOrTagMessageSize),
expectedMessageSize: helper.MaxCommitOrTagMessageSize + 1,
},
{
desc: "too long with newlines at cutoff",
message: strings.Repeat("a", helper.MaxCommitOrTagMessageSize-1) + "\nsomething",
expectedMessage: strings.Repeat("a", helper.MaxCommitOrTagMessageSize-1) + "\n",
expectedMessageSize: helper.MaxCommitOrTagMessageSize - 1 + len("\nsomething"),
},
{
desc: "too long with trailing newline",
message: strings.Repeat("a", helper.MaxCommitOrTagMessageSize) + "foo\n",
expectedMessage: strings.Repeat("a", helper.MaxCommitOrTagMessageSize),
expectedMessageSize: helper.MaxCommitOrTagMessageSize + len("foo"),
},
} {
t.Run(tc.desc, func(t *testing.T) {
tag := &gitalypb.Tag{
Message: []byte(tc.message),
}
TrimTagMessage(tag)
require.Equal(t, tc.expectedMessage, string(tag.Message))
require.Equal(t, int64(tc.expectedMessageSize), tag.MessageSize)
})
}
}
|
