1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
|
package git_test
import (
"strings"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/git"
"gitlab.com/gitlab-org/gitaly/internal/metadata/featureflag"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/internal/transaction/txinfo"
)
func TestHooksPayload(t *testing.T) {
cfg, repo, _ := testcfg.BuildWithRepo(t)
tx := txinfo.Transaction{
ID: 1234,
Node: "primary",
Primary: true,
}
t.Run("envvar has proper name", func(t *testing.T) {
env, err := git.NewHooksPayload(cfg, repo, nil, nil, git.AllHooks, nil).Env()
require.NoError(t, err)
require.True(t, strings.HasPrefix(env, git.EnvHooksPayload+"="))
})
t.Run("roundtrip succeeds", func(t *testing.T) {
env, err := git.NewHooksPayload(cfg, repo, nil, nil, git.PreReceiveHook, featureflag.Raw{"flag-key": "flag-value"}).Env()
require.NoError(t, err)
payload, err := git.HooksPayloadFromEnv([]string{
"UNRELATED=value",
env,
"ANOTHOR=unrelated-value",
git.EnvHooksPayload + "_WITH_SUFFIX=is-ignored",
})
require.NoError(t, err)
require.Equal(t, git.HooksPayload{
Repo: repo,
RuntimeDir: cfg.RuntimeDir,
InternalSocket: cfg.InternalSocketPath(),
RequestedHooks: git.PreReceiveHook,
FeatureFlags: featureflag.Raw{"flag-key": "flag-value"},
}, payload)
})
t.Run("roundtrip with transaction succeeds", func(t *testing.T) {
env, err := git.NewHooksPayload(cfg, repo, &tx, nil, git.UpdateHook, nil).Env()
require.NoError(t, err)
payload, err := git.HooksPayloadFromEnv([]string{env})
require.NoError(t, err)
require.Equal(t, git.HooksPayload{
Repo: repo,
RuntimeDir: cfg.RuntimeDir,
InternalSocket: cfg.InternalSocketPath(),
Transaction: &tx,
RequestedHooks: git.UpdateHook,
}, payload)
})
t.Run("missing envvar", func(t *testing.T) {
_, err := git.HooksPayloadFromEnv([]string{"OTHER_ENV=foobar"})
require.Error(t, err)
require.Equal(t, git.ErrPayloadNotFound, err)
})
t.Run("bogus value", func(t *testing.T) {
_, err := git.HooksPayloadFromEnv([]string{git.EnvHooksPayload + "=foobar"})
require.Error(t, err)
})
t.Run("receive hooks payload", func(t *testing.T) {
env, err := git.NewHooksPayload(cfg, repo, nil, &git.ReceiveHooksPayload{
UserID: "1234",
Username: "user",
Protocol: "ssh",
}, git.PostReceiveHook, nil).Env()
require.NoError(t, err)
payload, err := git.HooksPayloadFromEnv([]string{
env,
"GL_ID=wrong",
"GL_USERNAME=wrong",
"GL_PROTOCOL=wrong",
})
require.NoError(t, err)
require.Equal(t, git.HooksPayload{
Repo: repo,
RuntimeDir: cfg.RuntimeDir,
InternalSocket: cfg.InternalSocketPath(),
InternalSocketToken: cfg.Auth.Token,
ReceiveHooksPayload: &git.ReceiveHooksPayload{
UserID: "1234",
Username: "user",
Protocol: "ssh",
},
RequestedHooks: git.PostReceiveHook,
}, payload)
})
}
func TestHooksPayload_IsHookRequested(t *testing.T) {
for _, tc := range []struct {
desc string
configured git.Hook
request git.Hook
expected bool
}{
{
desc: "exact match",
configured: git.PreReceiveHook,
request: git.PreReceiveHook,
expected: true,
},
{
desc: "hook matches a set",
configured: git.PreReceiveHook | git.PostReceiveHook,
request: git.PreReceiveHook,
expected: true,
},
{
desc: "no match",
configured: git.PreReceiveHook,
request: git.PostReceiveHook,
expected: false,
},
{
desc: "no match with a set",
configured: git.PreReceiveHook | git.UpdateHook,
request: git.PostReceiveHook,
expected: false,
},
{
desc: "no match with nothing set",
configured: 0,
request: git.PostReceiveHook,
expected: false,
},
{
desc: "pre-receive hook with AllHooks",
configured: git.AllHooks,
request: git.PreReceiveHook,
expected: true,
},
{
desc: "post-receive hook with AllHooks",
configured: git.AllHooks,
request: git.PostReceiveHook,
expected: true,
},
{
desc: "update hook with AllHooks",
configured: git.AllHooks,
request: git.UpdateHook,
expected: true,
},
{
desc: "reference-transaction hook with AllHooks",
configured: git.AllHooks,
request: git.ReferenceTransactionHook,
expected: true,
},
} {
t.Run(tc.desc, func(t *testing.T) {
actual := git.HooksPayload{
RequestedHooks: tc.configured,
}.IsHookRequested(tc.request)
require.Equal(t, tc.expected, actual)
})
}
}
|
