1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
|
package housekeeping_test
import (
"os"
"path/filepath"
"testing"
"github.com/grpc-ecosystem/go-grpc-middleware/logging/logrus/ctxlogrus"
"github.com/sirupsen/logrus"
"github.com/sirupsen/logrus/hooks/test"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/v14/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v14/internal/git/housekeeping"
"gitlab.com/gitlab-org/gitaly/v14/internal/git/localrepo"
"gitlab.com/gitlab-org/gitaly/v14/internal/gitaly/service/setup"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper/testcfg"
"gitlab.com/gitlab-org/gitaly/v14/internal/testhelper/testserver"
)
func TestPruneIfNeeded(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg := testcfg.Build(t)
cfg.SocketPath = testserver.RunGitalyServer(t, cfg, nil, setup.RegisterAll)
for _, tc := range []struct {
desc string
isPool bool
looseObjects []string
expectedPrune bool
}{
{
desc: "no objects",
looseObjects: nil,
expectedPrune: false,
},
{
desc: "object not in 17 shard",
looseObjects: []string{
filepath.Join("ab/12345"),
},
expectedPrune: false,
},
{
desc: "object in 17 shard",
looseObjects: []string{
filepath.Join("17/12345"),
},
expectedPrune: false,
},
{
desc: "objects in different shards",
looseObjects: []string{
filepath.Join("ab/12345"),
filepath.Join("cd/12345"),
filepath.Join("12/12345"),
filepath.Join("17/12345"),
},
expectedPrune: false,
},
{
desc: "boundary",
looseObjects: []string{
filepath.Join("17/1"),
filepath.Join("17/2"),
filepath.Join("17/3"),
filepath.Join("17/4"),
},
expectedPrune: false,
},
{
desc: "exceeding boundary should cause repack",
looseObjects: []string{
filepath.Join("17/1"),
filepath.Join("17/2"),
filepath.Join("17/3"),
filepath.Join("17/4"),
filepath.Join("17/5"),
},
expectedPrune: true,
},
{
desc: "exceeding boundary on pool",
isPool: true,
looseObjects: []string{
filepath.Join("17/1"),
filepath.Join("17/2"),
filepath.Join("17/3"),
filepath.Join("17/4"),
filepath.Join("17/5"),
},
expectedPrune: false,
},
} {
t.Run(tc.desc, func(t *testing.T) {
t.Parallel()
createRepoCfg := gittest.CreateRepositoryConfig{}
if tc.isPool {
createRepoCfg.RelativePath = gittest.NewObjectPoolName(t)
}
repoProto, repoPath := gittest.CreateRepository(ctx, t, cfg, createRepoCfg)
repo := localrepo.NewTestRepo(t, cfg, repoProto)
for _, looseObjectPath := range tc.looseObjects {
looseObjectPath := filepath.Join(repoPath, "objects", looseObjectPath)
require.NoError(t, os.MkdirAll(filepath.Dir(looseObjectPath), 0o755))
looseObjectFile, err := os.Create(looseObjectPath)
require.NoError(t, err)
testhelper.MustClose(t, looseObjectFile)
}
logger, hook := test.NewNullLogger()
ctx := ctxlogrus.ToContext(ctx, logrus.NewEntry(logger))
require.NoError(t, housekeeping.NewManager(cfg.Prometheus, nil).OptimizeRepository(ctx, repo))
expectedLogEntry := map[string]string{
"packed_objects_full": "success",
"written_bitmap": "success",
}
if tc.expectedPrune {
expectedLogEntry["pruned_objects"] = "success"
}
require.Equal(t, expectedLogEntry, hook.Entries[len(hook.Entries)-1].Data["optimizations"])
})
}
}
|
