1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
|
package log
import (
"bytes"
"os"
"testing"
"github.com/golang/protobuf/ptypes/timestamp"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/git/catfile"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/config"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/proto/go/gitalypb"
"google.golang.org/grpc/metadata"
)
func TestMain(m *testing.M) {
os.Exit(testMain(m))
}
func testMain(m *testing.M) int {
defer testhelper.MustHaveNoChildProcess()
cleanup := testhelper.Configure()
defer cleanup()
return m.Run()
}
func TestParseRawCommit(t *testing.T) {
info := &catfile.ObjectInfo{
Oid: "a984dfa4dee018c6d5f5f57ffec0d0e22763df16",
Type: "commit",
}
// Valid-but-interesting commits should be test at the FindCommit level.
// Invalid objects (that Git would complain about during fsck) can be
// tested here.
//
// Once a repository contains a pathological object it can be hard to get
// rid of it. Because of this I think it's nicer to ignore such objects
// than to throw hard errors.
testCases := []struct {
desc string
in []byte
out *gitalypb.GitCommit
}{
{
desc: "empty commit object",
in: []byte{},
out: &gitalypb.GitCommit{Id: info.Oid},
},
{
desc: "no email",
in: []byte("author Jane Doe"),
out: &gitalypb.GitCommit{
Id: info.Oid,
Author: &gitalypb.CommitAuthor{Name: []byte("Jane Doe")},
},
},
{
desc: "unmatched <",
in: []byte("author Jane Doe <janedoe@example.com"),
out: &gitalypb.GitCommit{
Id: info.Oid,
Author: &gitalypb.CommitAuthor{Name: []byte("Jane Doe")},
},
},
{
desc: "unmatched >",
in: []byte("author Jane Doe janedoe@example.com>"),
out: &gitalypb.GitCommit{
Id: info.Oid,
Author: &gitalypb.CommitAuthor{Name: []byte("Jane Doe janedoe@example.com>")},
},
},
{
desc: "missing date",
in: []byte("author Jane Doe <janedoe@example.com> "),
out: &gitalypb.GitCommit{
Id: info.Oid,
Author: &gitalypb.CommitAuthor{Name: []byte("Jane Doe"), Email: []byte("janedoe@example.com")},
},
},
{
desc: "date too high",
in: []byte("author Jane Doe <janedoe@example.com> 9007199254740993 +0200"),
out: &gitalypb.GitCommit{
Id: info.Oid,
Author: &gitalypb.CommitAuthor{
Name: []byte("Jane Doe"),
Email: []byte("janedoe@example.com"),
Date: ×tamp.Timestamp{Seconds: 9223371974719179007},
Timezone: []byte("+0200"),
},
},
},
{
desc: "date negative",
in: []byte("author Jane Doe <janedoe@example.com> -1 +0200"),
out: &gitalypb.GitCommit{
Id: info.Oid,
Author: &gitalypb.CommitAuthor{
Name: []byte("Jane Doe"),
Email: []byte("janedoe@example.com"),
Date: ×tamp.Timestamp{Seconds: 9223371974719179007},
Timezone: []byte("+0200"),
},
},
},
}
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
info.Size = int64(len(tc.in))
out, err := parseRawCommit(bytes.NewBuffer(tc.in), info)
require.NoError(t, err, "parse error")
require.Equal(t, tc.out, out)
})
}
}
func TestGetCommitCatfile(t *testing.T) {
ctx, cancel := testhelper.Context()
ctx = metadata.NewIncomingContext(ctx, metadata.MD{})
defer cancel()
testRepo, _, cleanup := testhelper.NewTestRepo(t)
defer cleanup()
const commitSha = "2d1db523e11e777e49377cfb22d368deec3f0793"
const commitMsg = "Correct test_env.rb path for adding branch\n"
const blobSha = "c60514b6d3d6bf4bec1030f70026e34dfbd69ad5"
testCases := []struct {
desc string
revision string
errStr string
}{
{
desc: "commit",
revision: commitSha,
},
{
desc: "not existing commit",
revision: "not existing revision",
errStr: "object not found",
},
{
desc: "blob sha",
revision: blobSha,
errStr: "object not found",
},
}
c, err := catfile.New(ctx, config.NewLocator(config.Config), testRepo)
require.NoError(t, err)
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
c, err := GetCommitCatfile(ctx, c, tc.revision)
if tc.errStr == "" {
require.NoError(t, err)
require.Equal(t, commitMsg, string(c.Body))
} else {
require.EqualError(t, err, tc.errStr)
}
})
}
}
|
