1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
|
package objectpool
import (
"bytes"
"fmt"
"gitlab.com/gitlab-org/gitaly/v15/structerr"
"os"
"path/filepath"
"testing"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/proto/v15/go/gitalypb"
"gitlab.com/gitlab-org/gitaly/v15/internal/backchannel"
"gitlab.com/gitlab-org/gitaly/v15/internal/git"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/catfile"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/housekeeping"
"gitlab.com/gitlab-org/gitaly/v15/internal/git/localrepo"
"gitlab.com/gitlab-org/gitaly/v15/internal/gitaly/config"
"gitlab.com/gitlab-org/gitaly/v15/internal/gitaly/transaction"
"gitlab.com/gitlab-org/gitaly/v15/internal/helper/perm"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/v15/internal/testhelper/testcfg"
)
func TestCreate(t *testing.T) {
t.Parallel()
ctx := testhelper.Context(t)
cfg := testcfg.Build(t)
repoProto, repoPath := gittest.CreateRepository(t, ctx, cfg, gittest.CreateRepositoryConfig{
SkipCreationViaService: true,
})
repo := localrepo.NewTestRepo(t, cfg, repoProto)
commitID := gittest.WriteCommit(t, cfg, repoPath, gittest.WithBranch("master"))
createPool := func(t *testing.T, poolProto *gitalypb.ObjectPool) (*ObjectPool, string, error) {
catfileCache := catfile.NewCache(cfg)
t.Cleanup(catfileCache.Stop)
txManager := transaction.NewManager(cfg, backchannel.NewRegistry())
pool, err := Create(
ctx,
config.NewLocator(cfg),
gittest.NewCommandFactory(t, cfg, git.WithSkipHooks()),
catfileCache,
txManager,
housekeeping.NewManager(cfg.Prometheus, txManager),
poolProto,
repo,
)
if err != nil {
return nil, "", err
}
return pool, gittest.RepositoryPath(t, pool), nil
}
t.Run("successful", func(t *testing.T) {
_, poolPath, err := createPool(t, &gitalypb.ObjectPool{
Repository: &gitalypb.Repository{
StorageName: cfg.Storages[0].Name,
RelativePath: gittest.NewObjectPoolName(t),
},
})
require.NoError(t, err)
// There should not be a "hooks" directory in the pool.
require.NoDirExists(t, filepath.Join(poolPath, "hooks"))
// The repository has no remote.
require.Empty(t, gittest.Exec(t, cfg, "-C", poolPath, "remote"))
// The "master" branch points to the same commit as in the pool member.
require.Equal(t, commitID, gittest.ResolveRevision(t, cfg, poolPath, "refs/heads/master"))
// Objects exist in the pool repository.
gittest.RequireObjectExists(t, cfg, poolPath, commitID)
})
t.Run("target exists", func(t *testing.T) {
relativePath := gittest.NewObjectPoolName(t)
fullPath := filepath.Join(cfg.Storages[0].Path, relativePath)
// We currently allow creating object pools when the target path is an empty
// directory. This can be considered a bug, but for now we abide.
require.NoError(t, os.MkdirAll(fullPath, perm.SharedDir))
_, _, err := createPool(t, &gitalypb.ObjectPool{
Repository: &gitalypb.Repository{
StorageName: cfg.Storages[0].Name,
RelativePath: relativePath,
},
})
testhelper.RequireGrpcError(t, structerr.NewFailedPrecondition("target path exists already"), err)
})
t.Run("consistency check", func(t *testing.T) {
// Write a tree into the repository that's known-broken.
treeID := gittest.WriteTree(t, cfg, repoPath, []gittest.TreeEntry{
{Content: "content", Path: "dup", Mode: "100644"},
{Content: "content", Path: "dup", Mode: "100644"},
})
gittest.WriteCommit(t, cfg, repoPath,
gittest.WithParents(),
gittest.WithBranch("master"),
gittest.WithTree(treeID),
)
// While git-clone(1) would normally complain about the broken tree we have just
// cloned, we don't expect the clone to fail. This is because we know that the tree
// is already in one of our repositories that we have locally, so raising an error
// now doesn't make a whole lot of sense in the first place.
//
// Note: this works because we use `git clone --local`, which only creates a copy of
// the repository without performing consistency checks.
_, poolPath, err := createPool(t, &gitalypb.ObjectPool{
Repository: &gitalypb.Repository{
StorageName: cfg.Storages[0].Name,
RelativePath: gittest.NewObjectPoolName(t),
},
})
require.NoError(t, err)
// Verify that the broken tree is indeed in the pool repository and that it is
// reported as broken by git-fsck(1).
var stderr bytes.Buffer
fsckCmd := gittest.NewCommand(t, cfg, "-C", poolPath, "fsck")
fsckCmd.Stderr = &stderr
require.EqualError(t, fsckCmd.Run(), "exit status 1")
require.Equal(t, fmt.Sprintf("error in tree %s: duplicateEntries: contains duplicate file entries\n", treeID), stderr.String())
})
}
|
