1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
|
package objectpool
import (
"os"
"path/filepath"
"strings"
"testing"
"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
"gitlab.com/gitlab-org/gitaly/internal/git/gittest"
"gitlab.com/gitlab-org/gitaly/internal/git/localrepo"
"gitlab.com/gitlab-org/gitaly/internal/gitaly/config"
"gitlab.com/gitlab-org/gitaly/internal/testhelper"
"gitlab.com/gitlab-org/gitaly/internal/testhelper/testcfg"
)
func TestNewObjectPool(t *testing.T) {
cfg := testcfg.Build(t)
locator := config.NewLocator(cfg)
_, err := NewObjectPool(locator, nil, nil, nil, nil, cfg.Storages[0].Name, gittest.NewObjectPoolName(t))
require.NoError(t, err)
_, err = NewObjectPool(locator, nil, nil, nil, nil, "mepmep", gittest.NewObjectPoolName(t))
require.Error(t, err, "creating pool in storage that does not exist should fail")
}
func TestNewFromRepoSuccess(t *testing.T) {
ctx := testhelper.Context(t)
cfg, pool, repoProto := setupObjectPool(t, ctx)
repo := localrepo.NewTestRepo(t, cfg, repoProto)
locator := config.NewLocator(cfg)
require.NoError(t, pool.Create(ctx, repo))
require.NoError(t, pool.Link(ctx, repo))
poolFromRepo, err := FromRepo(locator, pool.gitCmdFactory, nil, nil, nil, repo)
require.NoError(t, err)
require.Equal(t, pool.relativePath, poolFromRepo.relativePath)
require.Equal(t, pool.storageName, poolFromRepo.storageName)
}
func TestNewFromRepoNoObjectPool(t *testing.T) {
ctx := testhelper.Context(t)
cfg, pool, repoProto := setupObjectPool(t, ctx)
repo := localrepo.NewTestRepo(t, cfg, repoProto)
locator := config.NewLocator(cfg)
testRepoPath := filepath.Join(cfg.Storages[0].Path, repo.GetRelativePath())
// no alternates file
poolFromRepo, err := FromRepo(locator, pool.gitCmdFactory, nil, nil, nil, repo)
require.Equal(t, ErrAlternateObjectDirNotExist, err)
require.Nil(t, poolFromRepo)
// with an alternates file
testCases := []struct {
desc string
fileContent []byte
expectedErr error
}{
{
desc: "points to non existent path",
fileContent: []byte("/tmp/invalid_path"),
expectedErr: ErrInvalidPoolRepository,
},
{
desc: "empty file",
fileContent: nil,
expectedErr: nil,
},
{
desc: "first line commented out",
fileContent: []byte("#/tmp/invalid/path"),
expectedErr: ErrAlternateObjectDirNotExist,
},
}
require.NoError(t, os.MkdirAll(filepath.Join(testRepoPath, "objects", "info"), 0o755))
for _, tc := range testCases {
t.Run(tc.desc, func(t *testing.T) {
alternateFilePath := filepath.Join(testRepoPath, "objects", "info", "alternates")
require.NoError(t, os.WriteFile(alternateFilePath, tc.fileContent, 0o644))
poolFromRepo, err := FromRepo(locator, pool.gitCmdFactory, nil, nil, nil, repo)
require.Equal(t, tc.expectedErr, err)
require.Nil(t, poolFromRepo)
require.NoError(t, os.Remove(alternateFilePath))
})
}
}
func TestCreate(t *testing.T) {
ctx := testhelper.Context(t)
cfg, pool, repoProto := setupObjectPool(t, ctx)
repo := localrepo.NewTestRepo(t, cfg, repoProto)
testRepoPath := filepath.Join(cfg.Storages[0].Path, repo.GetRelativePath())
masterSha := gittest.Exec(t, cfg, "-C", testRepoPath, "show-ref", "master")
err := pool.Create(ctx, repo)
require.NoError(t, err)
defer func() {
require.NoError(t, pool.Remove(ctx))
}()
require.True(t, pool.IsValid())
// No hooks
assert.NoDirExists(t, filepath.Join(pool.FullPath(), "hooks"))
// origin is set
out := gittest.Exec(t, cfg, "-C", pool.FullPath(), "remote", "get-url", "origin")
assert.Equal(t, testRepoPath, strings.TrimRight(string(out), "\n"))
// refs exist
out = gittest.Exec(t, cfg, "-C", pool.FullPath(), "show-ref", "refs/heads/master")
assert.Equal(t, masterSha, out)
// No problems
out = gittest.Exec(t, cfg, "-C", pool.FullPath(), "cat-file", "-s", "55bc176024cfa3baaceb71db584c7e5df900ea65")
assert.Equal(t, "282\n", string(out))
}
func TestCreateSubDirsExist(t *testing.T) {
ctx := testhelper.Context(t)
cfg, pool, repoProto := setupObjectPool(t, ctx)
repo := localrepo.NewTestRepo(t, cfg, repoProto)
err := pool.Create(ctx, repo)
require.NoError(t, err)
require.NoError(t, pool.Remove(ctx))
// Recreate pool so the subdirs exist already
err = pool.Create(ctx, repo)
require.NoError(t, err)
}
func TestRemove(t *testing.T) {
ctx := testhelper.Context(t)
cfg, pool, repoProto := setupObjectPool(t, ctx)
repo := localrepo.NewTestRepo(t, cfg, repoProto)
err := pool.Create(ctx, repo)
require.NoError(t, err)
require.True(t, pool.Exists())
require.NoError(t, pool.Remove(ctx))
require.False(t, pool.Exists())
}
|
